SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #5] [MERGED] Combine IBM PC-CD options, misc fixes #897

New Issue
Open
opened 2026-01-29 16:24:10 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:10 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/5
Author: @mnadareski
Created: 5/14/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @undefined

Base: master ← Head: master

📝 Commits (5)

📊 Changes

2 files changed (+4 additions, -22 deletions)

View changed files

📝 MainWindow.xaml (+1 -4)
📝 MainWindow.xaml.cs (+3 -18)

📄 Description

This commit consolidates the 4 IBM PC-CD variants into a single option. This will reduce the amount of confusion to new users in the future since they will be able to dump any CD right off the bat. The other commits dealt with merge issues I had due to not syncing branches before making my changes. I believe I also added "bd" as the type for BD-Video and changed the Audio CD type to "cd", since the "audio" command is more fiddly than it seems.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/5 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 5/14/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`5b777c3`](https://github.com/SabreTools/MPF/commit/5b777c3bb5b33cc98618dfa19b8a0b440c2d3159) Combine IBM PC-CD options, fix "no copy protection" - [`bfca669`](https://github.com/SabreTools/MPF/commit/bfca66951d90f9e7cde483c37f30f41e445eccfc) Merge branch 'master' of https://github.com/mnadareski/DICUI - [`16ae5e1`](https://github.com/SabreTools/MPF/commit/16ae5e1c661b41e9b6f386e90e52946b7eb23f7c) Fix automatic merge issues - [`c0cf207`](https://github.com/SabreTools/MPF/commit/c0cf207776a7b87eeaf5c37af2315f90906ad3f0) Ensure tabbing stays the same with source - [`039cbf6`](https://github.com/SabreTools/MPF/commit/039cbf6de49c8c47fcfb6bbc83b2f4e7a3afaf93) Merge branch 'master' into master ### 📊 Changes **2 files changed** (+4 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml` (+1 -4) 📝 `MainWindow.xaml.cs` (+3 -18) </details> ### 📄 Description This commit consolidates the 4 IBM PC-CD variants into a single option. This will reduce the amount of confusion to new users in the future since they will be able to dump any CD right off the bat. The other commits dealt with merge issues I had due to not syncing branches before making my changes. I believe I also added "bd" as the type for BD-Video and changed the Audio CD type to "cd", since the "audio" command is more fiddly than it seems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#897
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?