[PR #6] [MERGED] Enable future settings use #898

New Issue

Closed

opened 2026-01-29 16:24:10 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:10 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/6
Author: @mnadareski
Created: 5/14/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @undefined

Base: master ← Head: master

---

📝 Commits (2)

• e2789dd Enable future settings use
• f3319f4 Untabify

📊 Changes

4 files changed (+36 additions, -11 deletions)

View changed files

📝 App.config (+12 -0)
📝 MainWindow.xaml.cs (+4 -5)
📝 Properties/Settings.Designer.cs (+13 -1)
📝 Properties/Settings.settings (+7 -5)

📄 Description

This change converts the static DIC path to one that is controlled by settings. Currently, nothing saves or changes these settings so nothing has changed in terms of what the workflow is. This will, however, enable these settings to be controlled through the UI in the future, and allow for settings persistence between sessions without having to rely on AppData or the registry.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/6 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 5/14/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`e2789dd`](https://github.com/SabreTools/MPF/commit/e2789ddd11dc5c47d8c525b20fe3664269d1e92e) Enable future settings use - [`f3319f4`](https://github.com/SabreTools/MPF/commit/f3319f4ee26037aa3b600deead71701684147563) Untabify ### 📊 Changes **4 files changed** (+36 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `App.config` (+12 -0) 📝 `MainWindow.xaml.cs` (+4 -5) 📝 `Properties/Settings.Designer.cs` (+13 -1) 📝 `Properties/Settings.settings` (+7 -5) </details> ### 📄 Description This change converts the static DIC path to one that is controlled by settings. Currently, nothing saves or changes these settings so nothing has changed in terms of what the workflow is. This will, however, enable these settings to be controlled through the UI in the future, and allow for settings persistence between sessions without having to rely on AppData or the registry. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:10 +00:00

claunia closed this issue 2026-01-29 16:24:10 +00:00

claunia referenced this issue 2026-01-29 16:26:08 +00:00

[PR #898] [CLOSED] [WIP] Language support #1220

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#898