SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #26] [MERGED] Disc Information Framework #900

New Issue
Open
opened 2026-01-29 16:24:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/26
Author: @mnadareski
Created: 6/12/2018
Status: ✅ Merged
Merged: 6/12/2018
Merged by: @undefined

Base: master ← Head: master

📝 Commits (10+)

  • de48c8f Add method to find the first (only) track of a dump
  • 9bdd2d6 First use of finding the first track
  • db4a785 Use path combination
  • eb69b74 Add check to ensure all output files are found
  • 2e52d00 Add TODO
  • 1dbf23c Add first iteration of getting output information (incomplete)
  • a37e6aa Add first two info extraction helpers
  • 17c283f Add a couple more info grabbers
  • fd855b9 More clariication of template, fix .dat reading
  • 5adbdd2 Add all CD-ROM info getters

📊 Changes

2 files changed (+514 additions, -24 deletions)

View changed files

📝 MainWindow.xaml.cs (+42 -24)
📝 Utilities.cs (+472 -0)

📄 Description

Provide a basic framework for getting all required disc information in one place.

Currently, this is not practically hooked up (just a Dictionary is populated), but in a future PR, this will result in an outputted file with all of the information correctly formatted.

Known issues with this commit:

  • Not all error counts (and warning counts) are correctly detected
  • Missing values are not handled gracefully (usually just set to null)
  • The Utilities class is starting to get bloated with too much disparate stuff

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/26 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/12/2018 **Status:** ✅ Merged **Merged:** 6/12/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`de48c8f`](https://github.com/SabreTools/MPF/commit/de48c8f0f93610f83635d11dcbcb79277a0d052b) Add method to find the first (only) track of a dump - [`9bdd2d6`](https://github.com/SabreTools/MPF/commit/9bdd2d69516ced839a451636632c5f3a3122932f) First use of finding the first track - [`db4a785`](https://github.com/SabreTools/MPF/commit/db4a785558df48c4f69963aecd9e495addfaa0e1) Use path combination - [`eb69b74`](https://github.com/SabreTools/MPF/commit/eb69b74b4a0620027eb09bd342a57ed3f204dc41) Add check to ensure all output files are found - [`2e52d00`](https://github.com/SabreTools/MPF/commit/2e52d001074597a5b31d8e9a47e205f1f6648e57) Add TODO - [`1dbf23c`](https://github.com/SabreTools/MPF/commit/1dbf23ca952986eec5fa049be084ee568f162be6) Add first iteration of getting output information (incomplete) - [`a37e6aa`](https://github.com/SabreTools/MPF/commit/a37e6aaf18ebccb59f93bce1631d41b1135971e9) Add first two info extraction helpers - [`17c283f`](https://github.com/SabreTools/MPF/commit/17c283ff67cec81dbdf9c9dbd35d8a6333d31486) Add a couple more info grabbers - [`fd855b9`](https://github.com/SabreTools/MPF/commit/fd855b9024f1e60ac6173faabcb7de48914e662e) More clariication of template, fix .dat reading - [`5adbdd2`](https://github.com/SabreTools/MPF/commit/5adbdd29e670c5d7d4d938d677d75ae12c3ebaac) Add all CD-ROM info getters ### 📊 Changes **2 files changed** (+514 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml.cs` (+42 -24) 📝 `Utilities.cs` (+472 -0) </details> ### 📄 Description Provide a basic framework for getting all required disc information in one place. Currently, this is not practically hooked up (just a Dictionary is populated), but in a future PR, this will result in an outputted file with all of the information correctly formatted. Known issues with this commit: - Not all error counts (and warning counts) are correctly detected - Missing values are not handled gracefully (usually just set to null) - The Utilities class is starting to get bloated with too much disparate stuff --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#900
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?