SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 05:37:45 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #25] [MERGED] Cleanup/Automation #901

New Issue
Open
opened 2026-01-29 16:24:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/25
Author: @mnadareski
Created: 6/11/2018
Status: ✅ Merged
Merged: 6/12/2018
Merged by: @undefined

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

3 files changed (+250 additions, -136 deletions)

View changed files

📝 MainWindow.xaml (+5 -12)
📝 MainWindow.xaml.cs (+196 -118)
📝 Utilities.cs (+49 -6)

📄 Description

This PR adds a bunch of generic cleanup that will allow for easier code addition in the future. This also adds the automatic population of the drive speed dropdown, similar to how the disc type is populated. This DOES remove the ability to put in a custom (non-standard) value, but it also reduces the amount of issues associated with such values.

Other changes include the removal of the creation of a single-line batch file with a direct invocation (or attempted invocation) of an external tool.

Edit: Okay, this change got massive. A lot of cleanup and error checking got added. I swear I'm done for this commit now.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/25 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/11/2018 **Status:** ✅ Merged **Merged:** 6/12/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`a2ac722`](https://github.com/SabreTools/MPF/commit/a2ac7222f91048be2e1613d71da8ec2cf0766279) Remove extra ECC check from PS1 - [`1d5d7b2`](https://github.com/SabreTools/MPF/commit/1d5d7b265e9a7488f6d99e2bd5b392f4dba67b8b) Remove one unnecessary batch file creation step - [`939174d`](https://github.com/SabreTools/MPF/commit/939174d8c4884f61f2a2afc23c4f7a472c0b11f6) Merge branch 'master' of https://github.com/mnadareski/DICUI - [`319f556`](https://github.com/SabreTools/MPF/commit/319f5563cb4371ed82db57bcebc4076672443abe) More descriptive process names - [`a7a2954`](https://github.com/SabreTools/MPF/commit/a7a295434d88077156c472a8450052cab94ca4cf) Simplification of rows, some renames - [`dd0dfc5`](https://github.com/SabreTools/MPF/commit/dd0dfc5cf5e5b6d2fc0b8632158a0de3025592c5) Move drive scanning to Utilities - [`97be13f`](https://github.com/SabreTools/MPF/commit/97be13f020c5d820067234aba3ec291607270f68) Make code more well-ordered, add default list of all drive speeds supported, privatize EVERYTHING - [`fae7a52`](https://github.com/SabreTools/MPF/commit/fae7a5254d41f96719fd8069ad0eedb393f244b3) Remove unnecessary event - [`d5d8ae0`](https://github.com/SabreTools/MPF/commit/d5d8ae0501496af550234494b48b7e3a4f233742) Fix build - [`87d5fc0`](https://github.com/SabreTools/MPF/commit/87d5fc0e66ae256f6bafb25c08ad1abaf5a95047) More reasonable default drive speed ### 📊 Changes **3 files changed** (+250 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml` (+5 -12) 📝 `MainWindow.xaml.cs` (+196 -118) 📝 `Utilities.cs` (+49 -6) </details> ### 📄 Description This PR adds a bunch of generic cleanup that will allow for easier code addition in the future. This also adds the automatic population of the drive speed dropdown, similar to how the disc type is populated. This DOES remove the ability to put in a custom (non-standard) value, but it also reduces the amount of issues associated with such values. Other changes include the removal of the creation of a single-line batch file with a direct invocation (or attempted invocation) of an external tool. Edit: Okay, this change got massive. A lot of cleanup and error checking got added. I swear I'm done for this commit now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#901
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?