SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-06 21:29:33 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #24] [MERGED] Add Enumerations; Helper Methods #902

New Issue
Open
opened 2026-01-29 16:24:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/24
Author: @mnadareski
Created: 6/8/2018
Status: ✅ Merged
Merged: 6/9/2018
Merged by: @undefined

Base: master ← Head: master

📝 Commits (10+)

  • 8b600a6 Add enumerations and unused methods
  • d9d61cf Fix build
  • f57b296 Add other string conversion, update comments
  • 8de2f1c Add helper function to make list of systems
  • dfba976 Fix minor formatting issues
  • a404a27 Make combobox entirely auto-generated
  • 928c996 Cleanup, make some things work more intended
  • 3575c43 Missed this one
  • a1c89d1 How did I miss this?
  • 7ff8483 Merge branch 'master' into master

📊 Changes

5 files changed (+782 additions, -365 deletions)

View changed files

📝 DICUI.csproj (+2 -0)
➕ Enumerations.cs (+107 -0)
📝 MainWindow.xaml (+1 -40)
📝 MainWindow.xaml.cs (+89 -325)
➕ Utilities.cs (+583 -0)

📄 Description

This PR adds enumerations, helper methods, and combobox automation to make the system more extensible in the future. This includes things like automatically getting the list of items in the box, setting default parameters better, and even filling in some previously-missing formats.

I encourage local testing to make sure that all items are still working as intended.

My merge with the main branch (Merge branch 'master') removes the unnecessary additional ECC check for CDs. If the EccEdc executable is in the folder with DIC, it will automatically run and create the required _eccEdc.txt file. I was trying to mention this in #21 but to no avail.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/24 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/8/2018 **Status:** ✅ Merged **Merged:** 6/9/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`8b600a6`](https://github.com/SabreTools/MPF/commit/8b600a6a354c68173096bac2c9c1d65cb30291a4) Add enumerations and unused methods - [`d9d61cf`](https://github.com/SabreTools/MPF/commit/d9d61cf66554a820adaf26f948dd79c1ae10d1ef) Fix build - [`f57b296`](https://github.com/SabreTools/MPF/commit/f57b29615b67538073c48530265dbd31dca4c5fc) Add other string conversion, update comments - [`8de2f1c`](https://github.com/SabreTools/MPF/commit/8de2f1c9bb28ab679c6d581e5d9289cfdeddbd60) Add helper function to make list of systems - [`dfba976`](https://github.com/SabreTools/MPF/commit/dfba97685a014426d3fb47ecdb33cc9be95843a9) Fix minor formatting issues - [`a404a27`](https://github.com/SabreTools/MPF/commit/a404a270f194a1cf3d2d06ff1d067e0996f9da92) Make combobox entirely auto-generated - [`928c996`](https://github.com/SabreTools/MPF/commit/928c9966faa0a7a0e7f350d10601f0f1c617f66f) Cleanup, make some things work more intended - [`3575c43`](https://github.com/SabreTools/MPF/commit/3575c43703e747cd5a391ad82f158062af26ba2e) Missed this one - [`a1c89d1`](https://github.com/SabreTools/MPF/commit/a1c89d17b8d0e95c561a3b2ef0a7d8c66d891e3f) How did I miss this? - [`7ff8483`](https://github.com/SabreTools/MPF/commit/7ff848347c7f8d93842f7b100827c3188b2feb62) Merge branch 'master' into master ### 📊 Changes **5 files changed** (+782 additions, -365 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.csproj` (+2 -0) ➕ `Enumerations.cs` (+107 -0) 📝 `MainWindow.xaml` (+1 -40) 📝 `MainWindow.xaml.cs` (+89 -325) ➕ `Utilities.cs` (+583 -0) </details> ### 📄 Description This PR adds enumerations, helper methods, and combobox automation to make the system more extensible in the future. This includes things like automatically getting the list of items in the box, setting default parameters better, and even filling in some previously-missing formats. I encourage local testing to make sure that all items are still working as intended. My merge with the main branch (Merge branch 'master') removes the unnecessary additional ECC check for CDs. If the EccEdc executable is in the folder with DIC, it will automatically run and create the required _eccEdc.txt file. I was trying to mention this in #21 but to no avail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#902
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?