[PR #25] Cleanup/Automation #906

New Issue

claunia · 2026-01-29T16:24:12Z

claunia commented

2026-01-29 16:24:12 +00:00

Original Pull Request: https://github.com/SabreTools/MPF/pull/25

State: closed
Merged: Yes

This PR adds a bunch of generic cleanup that will allow for easier code addition in the future. This also adds the automatic population of the drive speed dropdown, similar to how the disc type is populated. This DOES remove the ability to put in a custom (non-standard) value, but it also reduces the amount of issues associated with such values.

Other changes include the removal of the creation of a single-line batch file with a direct invocation (or attempted invocation) of an external tool.

Edit: Okay, this change got massive. A lot of cleanup and error checking got added. I swear I'm done for this commit now.

**Original Pull Request:** https://github.com/SabreTools/MPF/pull/25 **State:** closed **Merged:** Yes --- This PR adds a bunch of generic cleanup that will allow for easier code addition in the future. This also adds the automatic population of the drive speed dropdown, similar to how the disc type is populated. This DOES remove the ability to put in a custom (non-standard) value, but it also reduces the amount of issues associated with such values. Other changes include the removal of the creation of a single-line batch file with a direct invocation (or attempted invocation) of an external tool. Edit: Okay, this change got massive. A lot of cleanup and error checking got added. I swear I'm done for this commit now.

claunia added the pull-request label 2026-01-29 16:24:12 +00:00

claunia closed this issue

2026-01-29 16:24:13 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#906