[PR #29] [MERGED] Add Custom Parameter Support #908

New Issue

Open

opened 2026-01-29 16:24:14 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:14 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/29
Author: @mnadareski
Created: 6/13/2018
Status: ✅ Merged
Merged: 6/13/2018
Merged by: @undefined

Base: master ← Head: master

---

📝 Commits (2)

• 3f802e8 Consistent UI states
• ed67522 Add custom parameter support

📊 Changes

3 files changed (+62 additions, -22 deletions)

View changed files

📝 MainWindow.xaml (+9 -10)
📝 MainWindow.xaml.cs (+50 -12)
📝 Utilities.cs (+3 -0)

📄 Description

Addresses #14.

This change makes it so that the current commandline params are displayed in a disabled text box but when the custom option is selected, the other parts get disabled and you have full control over the commandline. This can allow any customization that users would like. It also simplifies the code that gets called when the DiscImageCreator instance gets run.

The changes to the xaml are incidental, they're just reordering (sans the addition of the new grid row for the custom parameters).

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/29 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/13/2018 **Status:** ✅ Merged **Merged:** 6/13/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3f802e8`](https://github.com/SabreTools/MPF/commit/3f802e85484064c0ace3fc20acadfba77f3562d3) Consistent UI states - [`ed67522`](https://github.com/SabreTools/MPF/commit/ed67522675765b8a3e13eae81028f4b21fbb9d3c) Add custom parameter support ### 📊 Changes **3 files changed** (+62 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml` (+9 -10) 📝 `MainWindow.xaml.cs` (+50 -12) 📝 `Utilities.cs` (+3 -0) </details> ### 📄 Description Addresses #14. This change makes it so that the current commandline params are displayed in a disabled text box but when the custom option is selected, the other parts get disabled and you have full control over the commandline. This can allow any customization that users would like. It also simplifies the code that gets called when the DiscImageCreator instance gets run. The changes to the xaml are incidental, they're just reordering (sans the addition of the new grid row for the custom parameters). --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:14 +00:00

claunia referenced this issue 2026-01-29 16:26:11 +00:00

[PR #908] [MERGED] Support UI Languages #1227

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#908