[PR #32] [MERGED] Enable validation of DIC parameters #909

New Issue

Open

opened 2026-01-29 16:24:14 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:14 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/32
Author: @mnadareski
Created: 6/13/2018
Status: ✅ Merged
Merged: 6/13/2018
Merged by: @mnadareski

Base: master ← Head: master

---

📝 Commits (4)

• 63e63a0 Add DIC command constants
• 207fdbb Start adding validation to DIC command line
• d549609 Add as many validations as humanly possible
• 9c7cee0 Fix validation, hook up to main dumping, fix dumping

📊 Changes

3 files changed (+701 additions, -20 deletions)

View changed files

📝 Constants.cs (+44 -0)
📝 MainWindow.xaml.cs (+6 -4)
📝 Utilities.cs (+651 -16)

📄 Description

This PR adds the ability to check DIC parameters which will be especially useful for the custom parameters. Even though DIC will just close if it's incorrect, this prevents needing to get to that point and provides a better mechanism.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/32 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/13/2018 **Status:** ✅ Merged **Merged:** 6/13/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`63e63a0`](https://github.com/SabreTools/MPF/commit/63e63a003313c1c35ff452ecbfc0c7cde2ecd714) Add DIC command constants - [`207fdbb`](https://github.com/SabreTools/MPF/commit/207fdbb49c3950193e832787e95f475e5d092356) Start adding validation to DIC command line - [`d549609`](https://github.com/SabreTools/MPF/commit/d549609a0f78afe33ae1caeb618491e4c05b8435) Add as many validations as humanly possible - [`9c7cee0`](https://github.com/SabreTools/MPF/commit/9c7cee0aa3d5728ef21541dad4bd91687a9d09a5) Fix validation, hook up to main dumping, fix dumping ### 📊 Changes **3 files changed** (+701 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `Constants.cs` (+44 -0) 📝 `MainWindow.xaml.cs` (+6 -4) 📝 `Utilities.cs` (+651 -16) </details> ### 📄 Description This PR adds the ability to check DIC parameters which will be especially useful for the custom parameters. Even though DIC will just close if it's incorrect, this prevents needing to get to that point and provides a better mechanism. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:14 +00:00

claunia referenced this issue 2026-01-29 16:26:12 +00:00

[PR #909] [MERGED] Be selective on which systems to enable skeleton #1228

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#909