[PR #44] [MERGED] Parameter Checking updates #929

New Issue

Open

opened 2026-01-29 16:24:21 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:21 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/44
Author: @mnadareski
Created: 6/14/2018
Status: ✅ Merged
Merged: 6/14/2018
Merged by: @mnadareski

Base: master ← Head: fix-o-tron

---

📝 Commits (2)

• c8b09bf Fix custom parameter parsing, rename to just "parameters"
• 8eb740e Consolodate and fix param checking code

📊 Changes

3 files changed (+545 additions, -499 deletions)

View changed files

📝 MainWindow.xaml (+2 -2)
📝 MainWindow.xaml.cs (+46 -21)
📝 Utilities.cs (+497 -476)

📄 Description

This updates parameter checking to allow for fully custom commandlines to be validated and an (attempted) match of output submission info will be created with it. This also cleans up a lot of the horrid duplicate code that was there before.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/44 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/14/2018 **Status:** ✅ Merged **Merged:** 6/14/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `fix-o-tron` --- ### 📝 Commits (2) - [`c8b09bf`](https://github.com/SabreTools/MPF/commit/c8b09bf2857eca2e430085d191a90df572276fb6) Fix custom parameter parsing, rename to just "parameters" - [`8eb740e`](https://github.com/SabreTools/MPF/commit/8eb740e047c10445dcb0827b5a268df34a3c78f4) Consolodate and fix param checking code ### 📊 Changes **3 files changed** (+545 additions, -499 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml` (+2 -2) 📝 `MainWindow.xaml.cs` (+46 -21) 📝 `Utilities.cs` (+497 -476) </details> ### 📄 Description This updates parameter checking to allow for fully custom commandlines to be validated and an (attempted) match of output submission info will be created with it. This also cleans up a lot of the horrid duplicate code that was there before. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:21 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#929