[PR #56] [MERGED] Separated of System and Disc Type #936

New Issue

claunia · 2026-01-29T16:24:23Z

claunia commented

2026-01-29 16:24:23 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/56
Author: @Jakz
Created: 6/18/2018
Status: ✅ Merged
Merged: 6/18/2018
Merged by: @mnadareski

Base: master ← Head: master

📝 Commits (8)

d68e186 Split type combobox into system combobox and disc type combobox
ffb53dd updated fork to head
21969f9 corrected indentation for xaml file
d296b9a fixed merge with head
596e26e fixed format
20243dc fixed issues for PR, added KnownSystem.CUSTOM
5ba23b9 removed Updater.cs which ended by error in commit
66d06f1 fixed GetOuptutName() for new drive/system combobox

📊 Changes

7 files changed (+156 additions, -106 deletions)

View changed files

📝 Constants.cs (+1 -1)
📝 Enumerations.cs (+2 -0)
📝 MainWindow.xaml (+4 -3)
📝 MainWindow.xaml.cs (+117 -68)
📝 Utilities/Converters.cs (+4 -1)
📝 Utilities/DumpInformation.cs (+3 -3)
📝 Utilities/Validation.cs (+25 -30)

📄 Description

As proposed and discussed before this PR separates choosing a system from choosing a disk type in the UI so that it is managed by two different combo boxes.

Fixes #51

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/56 **Author:** [@Jakz](https://github.com/Jakz) **Created:** 6/18/2018 **Status:** ✅ Merged **Merged:** 6/18/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`d68e186`](https://github.com/SabreTools/MPF/commit/d68e1869f5889756a0017328fa9d173f5f204560) Split type combobox into system combobox and disc type combobox - [`ffb53dd`](https://github.com/SabreTools/MPF/commit/ffb53dde7a176aa046ce0df435ae830d4ee4d347) updated fork to head - [`21969f9`](https://github.com/SabreTools/MPF/commit/21969f951d4bcf5bf8e9d7746dc304a1c7270dcf) corrected indentation for xaml file - [`d296b9a`](https://github.com/SabreTools/MPF/commit/d296b9a92fe9899bcde4d90609dae4ddb78de55e) fixed merge with head - [`596e26e`](https://github.com/SabreTools/MPF/commit/596e26e8d25298e4d906592f27a46fe9ee79a8b1) fixed format - [`20243dc`](https://github.com/SabreTools/MPF/commit/20243dcec9883ce6d60faf9cb27f5d600584618b) fixed issues for PR, added KnownSystem.CUSTOM - [`5ba23b9`](https://github.com/SabreTools/MPF/commit/5ba23b9c22a94d7436d024a0ec4a8e226d27110b) removed Updater.cs which ended by error in commit - [`66d06f1`](https://github.com/SabreTools/MPF/commit/66d06f16aeed1910270c1cb72ec50446229951f9) fixed GetOuptutName() for new drive/system combobox ### 📊 Changes **7 files changed** (+156 additions, -106 deletions) <details> <summary>View changed files</summary> 📝 `Constants.cs` (+1 -1) 📝 `Enumerations.cs` (+2 -0) 📝 `MainWindow.xaml` (+4 -3) 📝 `MainWindow.xaml.cs` (+117 -68) 📝 `Utilities/Converters.cs` (+4 -1) 📝 `Utilities/DumpInformation.cs` (+3 -3) 📝 `Utilities/Validation.cs` (+25 -30) </details> ### 📄 Description As proposed and discussed before this PR separates choosing a system from choosing a disk type in the UI so that it is managed by two different combo boxes. Fixes #51 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:24:23 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#936