[PR #58] [MERGED] Formats and Types #938

New Issue

claunia · 2026-01-29T16:24:24Z

claunia commented

2026-01-29 16:24:24 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/58
Author: @mnadareski
Created: 6/19/2018
Status: ✅ Merged
Merged: 6/20/2018
Merged by: @mnadareski

Base: master ← Head: odp

📝 Commits (6)

d60566b Combine single/dual-layer disc types
b29d649 Add silly formats
9b81a8f Minor tweaks to disc type population
26f820e Make codepath slightly less complex
755afa1 Fix null error on dump
97cf0ce Update strings that looked wrong in output

📊 Changes

6 files changed (+191 additions, -246 deletions)

View changed files

📝 Constants.cs (+3 -3)
📝 Enumerations.cs (+11 -7)
📝 MainWindow.xaml.cs (+31 -37)
📝 Utilities/Converters.cs (+33 -38)
📝 Utilities/DumpInformation.cs (+58 -68)
📝 Utilities/Validation.cs (+55 -93)

📄 Description

This PR addresses the following:

Fixes #52 - This needs testing, but I have combined the single- and dual-layer disc types into a single enum value each. This is achieved by checking for the presence of the layerbreak field in the output data. At the moment, this means that it is entirely transparent to the user what type of disc this is. Followup item (possibly for this PR): Output the disc type to either the name of the file OR a field within the submission info file.
Fixes #53 - A few more undumpable formats have been added to the internal list along with the migration of HD-DVD out of the valid formats for X360 (XDG2/3). This should address any semantic issues as well as allow for some fairly interesting cases later when more options arise besides DIC to backup media.
Cleanup and bugfixes for the split system and disc types. The code was good, I just had a couple of cleanups to reduce the amount of duplicate code and one null fix that was missed in the initial PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/58 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/19/2018 **Status:** ✅ Merged **Merged:** 6/20/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `odp` --- ### 📝 Commits (6) - [`d60566b`](https://github.com/SabreTools/MPF/commit/d60566b6d1eb7a67b1cb0c6d44c9cf4db224672a) Combine single/dual-layer disc types - [`b29d649`](https://github.com/SabreTools/MPF/commit/b29d6492fc48cd7f4d5d219a79fe0faa632f5302) Add silly formats - [`9b81a8f`](https://github.com/SabreTools/MPF/commit/9b81a8fb848a44b42b44872a9c31ab55531d065b) Minor tweaks to disc type population - [`26f820e`](https://github.com/SabreTools/MPF/commit/26f820ee04841247a6fe05ce75adf68425c69b04) Make codepath slightly less complex - [`755afa1`](https://github.com/SabreTools/MPF/commit/755afa146322c6db654b7e10901f902665ef311b) Fix null error on dump - [`97cf0ce`](https://github.com/SabreTools/MPF/commit/97cf0cea9f982ba1eaf12072515a83e1c5116857) Update strings that looked wrong in output ### 📊 Changes **6 files changed** (+191 additions, -246 deletions) <details> <summary>View changed files</summary> 📝 `Constants.cs` (+3 -3) 📝 `Enumerations.cs` (+11 -7) 📝 `MainWindow.xaml.cs` (+31 -37) 📝 `Utilities/Converters.cs` (+33 -38) 📝 `Utilities/DumpInformation.cs` (+58 -68) 📝 `Utilities/Validation.cs` (+55 -93) </details> ### 📄 Description This PR addresses the following: - Fixes #52 - This needs testing, but I have combined the single- and dual-layer disc types into a single enum value each. This is achieved by checking for the presence of the layerbreak field in the output data. At the moment, this means that it is entirely transparent to the user what type of disc this is. Followup item (possibly for this PR): Output the disc type to either the name of the file OR a field within the submission info file. - Fixes #53 - A few more undumpable formats have been added to the internal list along with the migration of HD-DVD out of the valid formats for X360 (XDG2/3). This should address any semantic issues as well as allow for some fairly interesting cases later when more options arise besides DIC to backup media. - Cleanup and bugfixes for the split system and disc types. The code was good, I just had a couple of cleanups to reduce the amount of duplicate code and one null fix that was missed in the initial PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:24:24 +00:00

claunia closed this issue

2026-01-29 16:24:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#938