[PR #63] [MERGED] Enhancement of options management #940

New Issue

Open

opened 2026-01-29 16:24:25 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:25 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/63
Author: @Jakz
Created: 6/20/2018
Status: ✅ Merged
Merged: 6/20/2018
Merged by: @mnadareski

Base: master ← Head: properties_ui_to_xaml

---

📝 Commits (10+)

• d68e186 Split type combobox into system combobox and disc type combobox
• ffb53dd updated fork to head
• 21969f9 corrected indentation for xaml file
• d296b9a fixed merge with head
• 596e26e fixed format
• 20243dc fixed issues for PR, added KnownSystem.CUSTOM
• 5ba23b9 removed Updater.cs which ended by error in commit
• 66d06f1 fixed GetOuptutName() for new drive/system combobox
• 217a064 added OptionsFrame that will manage all applicaton settings and implemented path browse buttons
• 6003b0d removed old properties code, added Options to manage all the program options, implemented interactions with OptionsWindow

📊 Changes

6 files changed (+305 additions, -239 deletions)

View changed files

📝 DICUI.csproj (+8 -0)
📝 MainWindow.xaml (+7 -7)
📝 MainWindow.xaml.cs (+34 -232)
➕ Options.cs (+58 -0)
➕ OptionsWindow.xaml (+72 -0)
➕ OptionsWindow.xaml.cs (+126 -0)

📄 Description

This pull request refactors the management of current path properties:

• properties are moved in a dedicated Options file which also manage persistence
• the handmade UI for options is removed and a dedicated OptionsWindow.xaml file is created
• all the current interactions are bridged through new options management

This refactor is not meant to be final since Options currently relies on reflection for a fast replacement solution of actual management, but we'll fix this successively.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/63 **Author:** [@Jakz](https://github.com/Jakz) **Created:** 6/20/2018 **Status:** ✅ Merged **Merged:** 6/20/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `properties_ui_to_xaml` --- ### 📝 Commits (10+) - [`d68e186`](https://github.com/SabreTools/MPF/commit/d68e1869f5889756a0017328fa9d173f5f204560) Split type combobox into system combobox and disc type combobox - [`ffb53dd`](https://github.com/SabreTools/MPF/commit/ffb53dde7a176aa046ce0df435ae830d4ee4d347) updated fork to head - [`21969f9`](https://github.com/SabreTools/MPF/commit/21969f951d4bcf5bf8e9d7746dc304a1c7270dcf) corrected indentation for xaml file - [`d296b9a`](https://github.com/SabreTools/MPF/commit/d296b9a92fe9899bcde4d90609dae4ddb78de55e) fixed merge with head - [`596e26e`](https://github.com/SabreTools/MPF/commit/596e26e8d25298e4d906592f27a46fe9ee79a8b1) fixed format - [`20243dc`](https://github.com/SabreTools/MPF/commit/20243dcec9883ce6d60faf9cb27f5d600584618b) fixed issues for PR, added KnownSystem.CUSTOM - [`5ba23b9`](https://github.com/SabreTools/MPF/commit/5ba23b9c22a94d7436d024a0ec4a8e226d27110b) removed Updater.cs which ended by error in commit - [`66d06f1`](https://github.com/SabreTools/MPF/commit/66d06f16aeed1910270c1cb72ec50446229951f9) fixed GetOuptutName() for new drive/system combobox - [`217a064`](https://github.com/SabreTools/MPF/commit/217a064b96df6621e4d2955ac7f4ab42ad68d6b4) added OptionsFrame that will manage all applicaton settings and implemented path browse buttons - [`6003b0d`](https://github.com/SabreTools/MPF/commit/6003b0d6e0ff7cab9a5f1e092752710137d95c3b) removed old properties code, added Options to manage all the program options, implemented interactions with OptionsWindow ### 📊 Changes **6 files changed** (+305 additions, -239 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.csproj` (+8 -0) 📝 `MainWindow.xaml` (+7 -7) 📝 `MainWindow.xaml.cs` (+34 -232) ➕ `Options.cs` (+58 -0) ➕ `OptionsWindow.xaml` (+72 -0) ➕ `OptionsWindow.xaml.cs` (+126 -0) </details> ### 📄 Description This pull request refactors the management of current path properties: - properties are moved in a dedicated `Options` file which also manage persistence - the handmade UI for options is removed and a dedicated `OptionsWindow.xaml` file is created - all the current interactions are bridged through new options management This refactor is not meant to be final since `Options` currently relies on reflection for a fast replacement solution of actual management, but we'll fix this successively. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:25 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#940