SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #70] [MERGED] Bits and Pieces #944

New Issue
Closed
opened 2026-01-29 16:24:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/70
Author: @mnadareski
Created: 6/21/2018
Status: ✅ Merged
Merged: 6/21/2018
Merged by: @mnadareski

Base: master ← Head: little-bits

📝 Commits (9)

📊 Changes

13 files changed (+782 additions, -445 deletions)

View changed files

➕ CHANGELIST.md (+62 -0)
📝 Constants.cs (+1 -0)
📝 DICUI.csproj (+2 -0)
📝 Enumerations.cs (+5 -5)
➕ External/IOrderedDictionary.cs (+10 -0)
➕ External/OrderedDictionary.cs (+326 -0)
📝 MainWindow.xaml (+2 -2)
📝 MainWindow.xaml.cs (+90 -77)
📝 Options.cs (+0 -4)
📝 README.md (+13 -94)
📝 Utilities/Converters.cs (+73 -72)
📝 Utilities/DumpInformation.cs (+38 -38)
📝 Utilities/Validation.cs (+160 -153)

📄 Description

  • Renamed DiscType to MediaType to better reflect the enum values (fixes #67)
  • Created CHANGELIST.md for a better, centralized experience (edited README.md in the process) (fixes #68)
  • Remove as many usages of tuple as possible for the time being (fixes #66)
    • Added the OrderedDictionary<TKey, TValue> type for future use. This is a generic version of the System.Collections.Specialized.OrderedDictionary type
  • Add string replacement for both . and & until a better solution can be found (fixes #54) (fixes #59)
    • As of now, both characters are replaced by _. This can be changed in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/70 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/21/2018 **Status:** ✅ Merged **Merged:** 6/21/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `little-bits` --- ### 📝 Commits (9) - [`f0ccb87`](https://github.com/SabreTools/MPF/commit/f0ccb879d0453ebca6f1664b193dc151c7f9e5b6) DiscType -> MediaType - [`d9a5e17`](https://github.com/SabreTools/MPF/commit/d9a5e177ee9a494573bb81e3ec061a13d1e5fffc) Fix bulk find/replace - [`afffb18`](https://github.com/SabreTools/MPF/commit/afffb180a1c1bbc6a5c27e94530baac74a11db0f) Add OrderedDictionary - [`435e34e`](https://github.com/SabreTools/MPF/commit/435e34e9b93d2ddb161c7822ac9e49b1eda1e436) Stage 1 of moving off of Tuples - [`c0a32ad`](https://github.com/SabreTools/MPF/commit/c0a32adb50fc10d65a41c70289b77adb8006c167) Add CHANGELIST.md - [`7638248`](https://github.com/SabreTools/MPF/commit/763824803ac7b5c827901a4fe98162fe18948775) Stage 2 of Tuple removal - [`fc71409`](https://github.com/SabreTools/MPF/commit/fc71409fdb0b7f37c68e4796f2ad3b3743f1de9c) String replacement for output paths - [`9a9d6b3`](https://github.com/SabreTools/MPF/commit/9a9d6b39447de206f828c46fa060ec5d0489d91a) Stage 3 of Tuple removal - [`aba13ff`](https://github.com/SabreTools/MPF/commit/aba13ff297ad383a8bd932972cb63b2b6cd98bde) Slight reordering ### 📊 Changes **13 files changed** (+782 additions, -445 deletions) <details> <summary>View changed files</summary> ➕ `CHANGELIST.md` (+62 -0) 📝 `Constants.cs` (+1 -0) 📝 `DICUI.csproj` (+2 -0) 📝 `Enumerations.cs` (+5 -5) ➕ `External/IOrderedDictionary.cs` (+10 -0) ➕ `External/OrderedDictionary.cs` (+326 -0) 📝 `MainWindow.xaml` (+2 -2) 📝 `MainWindow.xaml.cs` (+90 -77) 📝 `Options.cs` (+0 -4) 📝 `README.md` (+13 -94) 📝 `Utilities/Converters.cs` (+73 -72) 📝 `Utilities/DumpInformation.cs` (+38 -38) 📝 `Utilities/Validation.cs` (+160 -153) </details> ### 📄 Description - Renamed `DiscType` to `MediaType` to better reflect the enum values (fixes #67) - Created CHANGELIST.md for a better, centralized experience (edited README.md in the process) (fixes #68) - Remove as many usages of tuple as possible for the time being (fixes #66) - Added the `OrderedDictionary<TKey, TValue>` type for future use. This is a generic version of the `System.Collections.Specialized.OrderedDictionary` type - Add string replacement for both `.` and `&` until a better solution can be found (fixes #54) (fixes #59) - As of now, both characters are replaced by `_`. This can be changed in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#944
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?