SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-10 21:30:29 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #73] [MERGED] Usability Updates #946

New Issue
Closed
opened 2026-01-29 16:24:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/73
Author: @mnadareski
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/25/2018
Merged by: @mnadareski

Base: master ← Head: drivespeed

📝 Commits (8)

📊 Changes

7 files changed (+372 additions, -50 deletions)

View changed files

📝 DICUI.csproj (+24 -3)
📝 Data/Constants.cs (+1 -1)
📝 Data/Enumerations.cs (+28 -28)
📝 MainWindow.xaml.cs (+71 -12)
📝 Utilities/Converters.cs (+43 -5)
📝 Utilities/DumpInformation.cs (+1 -0)
📝 Utilities/Validators.cs (+204 -1)

📄 Description

This PR is a combination cleanup and feature update, including some WIP items that are not hooked up.

Starts the framework for the following:

  • Checking drive speed without the need for DIC (#69)
    • There are a couple different prototypes for this currently, there's no guarantee that either of them will be the ultimate solution
  • Report if a disc is XDG3 (#71) - this is by virtue of the next item

Adds the following abilities:

  • Detecting disc type automatically (fixes #49) - this is not 100% complete as DVD-based discs will show up as DVD only (XBOX/360 discs especially)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/73 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/25/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `drivespeed` --- ### 📝 Commits (8) - [`2213cdc`](https://github.com/SabreTools/MPF/commit/2213cdc09046277fcacae1e1ce2fd28e7d206e95) Checkpoint - [`1b3f9d4`](https://github.com/SabreTools/MPF/commit/1b3f9d4fd079daf85b16618536e7b3a6b77c90d1) Add notes - [`df091b1`](https://github.com/SabreTools/MPF/commit/df091b18a38f9db4bca35137f223d3962e8be628) Rename Validation -> Validators - [`bb46d4e`](https://github.com/SabreTools/MPF/commit/bb46d4ec09d1079ebdfcac93670508c16b200540) Move data to Data folder - [`13df85a`](https://github.com/SabreTools/MPF/commit/13df85a89b6d43bcd9237529ee3d2b98dd0b39c4) Get current disk type - [`f01e41c`](https://github.com/SabreTools/MPF/commit/f01e41cc8c99cce559773f9fdcc87ed7b4181d76) Automatically detect disc type - [`7ed4e99`](https://github.com/SabreTools/MPF/commit/7ed4e99acd752f4d1daa530511d13681e5cc8cf3) Comment out WIP code - [`0c2d983`](https://github.com/SabreTools/MPF/commit/0c2d9834eb5645a97a26d8c068859ce6c69d56e7) Add more prototype ### 📊 Changes **7 files changed** (+372 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.csproj` (+24 -3) 📝 `Data/Constants.cs` (+1 -1) 📝 `Data/Enumerations.cs` (+28 -28) 📝 `MainWindow.xaml.cs` (+71 -12) 📝 `Utilities/Converters.cs` (+43 -5) 📝 `Utilities/DumpInformation.cs` (+1 -0) 📝 `Utilities/Validators.cs` (+204 -1) </details> ### 📄 Description This PR is a combination cleanup and feature update, including some WIP items that are not hooked up. Starts the framework for the following: - Checking drive speed without the need for DIC (#69) - There are a couple different prototypes for this currently, there's no guarantee that either of them will be the ultimate solution - Report if a disc is XDG3 (#71) - this is by virtue of the next item Adds the following abilities: - Detecting disc type automatically (fixes #49) - this is not 100% complete as DVD-based discs will show up as DVD only (XBOX/360 discs especially) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?