SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #78] [MERGED] Streamline Callbacks and Ensure MediaType #950

New Issue
Open
opened 2026-01-29 16:24:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:27 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/78
Author: @mnadareski
Created: 6/28/2018
Status: ✅ Merged
Merged: 6/28/2018
Merged by: @mnadareski

Base: master ← Head: r1

📝 Commits (10+)

  • 58371c2 Separate drive speeds; better ensuring of media type
  • 268cd1f Multiple medium
  • b91020f Add more drive speed prototyping
  • cf7b9c9 Strip out redundant calls
  • 09716c5 Separate drive speeds; better ensuring of media type
  • 935d28d Multiple medium
  • 5d7adb1 Add more drive speed prototyping
  • c20e69c Strip out redundant calls
  • 7308524 Merge with master
  • 34da12a Streamline merge

📊 Changes

4 files changed (+99 additions, -76 deletions)

View changed files

📝 Data/Constants.cs (+12 -6)
📝 MainWindow.xaml.cs (+44 -50)
📝 Utilities/Converters.cs (+2 -1)
📝 Utilities/Validators.cs (+41 -19)

📄 Description

This PR does three major things:

  • Strips out a lot of redundant calls (due to callbacks firing) as well as reducing the amount of separate helper methods (by one, but it counts)
  • Makes the currently detected / selected media type "stickier" so that it persists more properly across changing systems. This also has the ability of showing the "detected disc was X but system does not support it" message in more relevant cases now.
  • Makes HD-DVD a first-class citizen, since apparently DiscImageCreator can dump it using the dvd command

On the side, this also adds more prototype code and notes for removing DIC as the way to get drive speeds.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/78 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/28/2018 **Status:** ✅ Merged **Merged:** 6/28/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r1` --- ### 📝 Commits (10+) - [`58371c2`](https://github.com/SabreTools/MPF/commit/58371c2f064a7dd859a17c731ed6dbab579718f3) Separate drive speeds; better ensuring of media type - [`268cd1f`](https://github.com/SabreTools/MPF/commit/268cd1f083ba8ce644c424c9c399beff6b0e1e4c) Multiple medium - [`b91020f`](https://github.com/SabreTools/MPF/commit/b91020fc186159e7ce476267d5c0e425edf6289f) Add more drive speed prototyping - [`cf7b9c9`](https://github.com/SabreTools/MPF/commit/cf7b9c921a91e56fef9e19185eed63431ac9ba8e) Strip out redundant calls - [`09716c5`](https://github.com/SabreTools/MPF/commit/09716c5a34d34b7339f72540a7960b7d4fe0ff6e) Separate drive speeds; better ensuring of media type - [`935d28d`](https://github.com/SabreTools/MPF/commit/935d28d748f57cca4609c0a02c29e9e8498195d1) Multiple medium - [`5d7adb1`](https://github.com/SabreTools/MPF/commit/5d7adb1366a0ec11acd73180d13b4dbf26721c38) Add more drive speed prototyping - [`c20e69c`](https://github.com/SabreTools/MPF/commit/c20e69cf6fe9b8b2b037b96b7105a85fec2b559c) Strip out redundant calls - [`7308524`](https://github.com/SabreTools/MPF/commit/7308524f76be22ae471ab391b94d9522f026b88e) Merge with master - [`34da12a`](https://github.com/SabreTools/MPF/commit/34da12a3344ed9cf57f17a8602cd44203f7f5336) Streamline merge ### 📊 Changes **4 files changed** (+99 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `Data/Constants.cs` (+12 -6) 📝 `MainWindow.xaml.cs` (+44 -50) 📝 `Utilities/Converters.cs` (+2 -1) 📝 `Utilities/Validators.cs` (+41 -19) </details> ### 📄 Description This PR does three major things: - Strips out a lot of redundant calls (due to callbacks firing) as well as reducing the amount of separate helper methods (by one, but it counts) - Makes the currently detected / selected media type "stickier" so that it persists more properly across changing systems. This also has the ability of showing the "detected disc was X but system does not support it" message in more relevant cases now. - Makes HD-DVD a first-class citizen, since apparently DiscImageCreator can dump it using the `dvd` command On the side, this also adds more prototype code and notes for removing DIC as the way to get drive speeds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?