[PR #79] [MERGED] Add Test Project #951

New Issue

Closed

opened 2026-01-29 16:24:27 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:27 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/79
Author: @mnadareski
Created: 6/28/2018
Status: ✅ Merged
Merged: 6/29/2018
Merged by: @mnadareski

Base: master ← Head: r2

---

📝 Commits (10+)

• 1e72a8e Add Test project; Migrate so there's not an external folder
• 5b27619 Add Test project; Migrate so that there's not an external folder
• 79d1394 Fix build; Add remaining test classes (skeletons)
• d7e3fcd Fix more paths
• f6f5b01 Make unit tests runnable, fix issue found by unit tests
• 1b9d768 Add more tests, fix more things found by tests
• 3a17eaa Add skeleton for ValidatorsTest, fix OrderedDictionary
• e99fb3d Add UIElementsTest
• 6154045 Add new test classes, slightly update Result
• 43dcadd Implement DumpEnvirionment tests; fix minor things from testing

📊 Changes

33 files changed (+979 additions, -452 deletions)

View changed files

➕ DICUI.Test/DICUI.Test.csproj (+101 -0)
➕ DICUI.Test/Data/UIElementsTest.cs (+21 -0)
➕ DICUI.Test/DumpEnvironmentTest.cs (+74 -0)
➕ DICUI.Test/Properties/AssemblyInfo.cs (+20 -0)
➕ DICUI.Test/ResultTest.cs (+39 -0)
➕ DICUI.Test/TasksTest.cs (+30 -0)
➕ DICUI.Test/Utilities/ConvertersTest.cs (+123 -0)
➕ DICUI.Test/Utilities/DumpInformationTest.cs (+61 -0)
➕ DICUI.Test/Utilities/KnownSystemExtensionsTest.cs (+21 -0)
➕ DICUI.Test/Utilities/MediaTypeExtensionsTest.cs (+48 -0)
➕ DICUI.Test/Utilities/ValidatorsTest.cs (+76 -0)
➕ DICUI.Test/packages.config (+14 -0)
📝 DICUI.sln (+7 -1)
📝 DICUI/App.config (+0 -0)
📝 DICUI/App.xaml (+0 -0)
📝 DICUI/App.xaml.cs (+0 -0)
📝 DICUI/DICUI.csproj (+0 -0)
📝 DICUI/Data/Constants.cs (+0 -1)
📝 DICUI/Data/Enumerations.cs (+0 -0)
📝 DICUI/External/IOrderedDictionary.cs (+0 -0)

...and 13 more files

📄 Description

The main purpose of this PR is to add a testing project based on xUnit to DICUI. This will give us the ability to add unit tests for any new code and help check if any changes that are made will break the program in a notable way. This is not currently set up to be run automatically on pull requests, mostly because I have no idea how to set that up.

Most of the code is currently tested, though there are some that rely on external programs or external files that will have to be added later, possibly using the Moq framework.

Additionally, there have been multiple small bugfixes that were found during the process of writing and running the unit tests, including but not limited to:

• Unhandled/improperly handled null and blank values
• Incorrectly handled enums
• Confusing method invocations

Fixes #48

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/79 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 6/28/2018 **Status:** ✅ Merged **Merged:** 6/29/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r2` --- ### 📝 Commits (10+) - [`1e72a8e`](https://github.com/SabreTools/MPF/commit/1e72a8ee9f56536c3c6faa4830f19b0b573d09b1) Add Test project; Migrate so there's not an external folder - [`5b27619`](https://github.com/SabreTools/MPF/commit/5b27619c7f86a4505e8daa8ee85a2cfdc4e48f65) Add Test project; Migrate so that there's not an external folder - [`79d1394`](https://github.com/SabreTools/MPF/commit/79d1394a3bd5eb85273053d32d865b2a1a34d477) Fix build; Add remaining test classes (skeletons) - [`d7e3fcd`](https://github.com/SabreTools/MPF/commit/d7e3fcd226926ac89b3c5c8b30e4da9126e10545) Fix more paths - [`f6f5b01`](https://github.com/SabreTools/MPF/commit/f6f5b01b5701dd43c88f1d95679b07fbff72943b) Make unit tests runnable, fix issue found by unit tests - [`1b9d768`](https://github.com/SabreTools/MPF/commit/1b9d768c060351a09554e0981ffc34ef5943cb2e) Add more tests, fix more things found by tests - [`3a17eaa`](https://github.com/SabreTools/MPF/commit/3a17eaaf8b7a299840643a8b019ae3219425ff70) Add skeleton for ValidatorsTest, fix OrderedDictionary - [`e99fb3d`](https://github.com/SabreTools/MPF/commit/e99fb3d32cdd35b325ed8c3b831cbd07c33796ef) Add UIElementsTest - [`6154045`](https://github.com/SabreTools/MPF/commit/615404515ae1c80d32c2a9d981ba50be732cf8cd) Add new test classes, slightly update Result - [`43dcadd`](https://github.com/SabreTools/MPF/commit/43dcadd23a9f503258df63ab25f80db5465aa35c) Implement DumpEnvirionment tests; fix minor things from testing ### 📊 Changes **33 files changed** (+979 additions, -452 deletions) <details> <summary>View changed files</summary> ➕ `DICUI.Test/DICUI.Test.csproj` (+101 -0) ➕ `DICUI.Test/Data/UIElementsTest.cs` (+21 -0) ➕ `DICUI.Test/DumpEnvironmentTest.cs` (+74 -0) ➕ `DICUI.Test/Properties/AssemblyInfo.cs` (+20 -0) ➕ `DICUI.Test/ResultTest.cs` (+39 -0) ➕ `DICUI.Test/TasksTest.cs` (+30 -0) ➕ `DICUI.Test/Utilities/ConvertersTest.cs` (+123 -0) ➕ `DICUI.Test/Utilities/DumpInformationTest.cs` (+61 -0) ➕ `DICUI.Test/Utilities/KnownSystemExtensionsTest.cs` (+21 -0) ➕ `DICUI.Test/Utilities/MediaTypeExtensionsTest.cs` (+48 -0) ➕ `DICUI.Test/Utilities/ValidatorsTest.cs` (+76 -0) ➕ `DICUI.Test/packages.config` (+14 -0) 📝 `DICUI.sln` (+7 -1) 📝 `DICUI/App.config` (+0 -0) 📝 `DICUI/App.xaml` (+0 -0) 📝 `DICUI/App.xaml.cs` (+0 -0) 📝 `DICUI/DICUI.csproj` (+0 -0) 📝 `DICUI/Data/Constants.cs` (+0 -1) 📝 `DICUI/Data/Enumerations.cs` (+0 -0) 📝 `DICUI/External/IOrderedDictionary.cs` (+0 -0) _...and 13 more files_ </details> ### 📄 Description The main purpose of this PR is to add a testing project based on xUnit to DICUI. This will give us the ability to add unit tests for any new code and help check if any changes that are made will break the program in a notable way. This is not currently set up to be run automatically on pull requests, mostly because I have no idea how to set that up. Most of the code is currently tested, though there are some that rely on external programs or external files that will have to be added later, possibly using the Moq framework. Additionally, there have been multiple small bugfixes that were found during the process of writing and running the unit tests, including but not limited to: - Unhandled/improperly handled null and blank values - Incorrectly handled enums - Confusing method invocations Fixes #48 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:27 +00:00

claunia closed this issue 2026-01-29 16:24:28 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#951