[PR #78] Streamline Callbacks and Ensure MediaType #952

New Issue

claunia · 2026-01-29T16:24:28Z

claunia commented

2026-01-29 16:24:28 +00:00

Original Pull Request: https://github.com/SabreTools/MPF/pull/78

State: closed
Merged: Yes

This PR does three major things:

Strips out a lot of redundant calls (due to callbacks firing) as well as reducing the amount of separate helper methods (by one, but it counts)
Makes the currently detected / selected media type "stickier" so that it persists more properly across changing systems. This also has the ability of showing the "detected disc was X but system does not support it" message in more relevant cases now.
Makes HD-DVD a first-class citizen, since apparently DiscImageCreator can dump it using the dvd command

On the side, this also adds more prototype code and notes for removing DIC as the way to get drive speeds.

**Original Pull Request:** https://github.com/SabreTools/MPF/pull/78 **State:** closed **Merged:** Yes --- This PR does three major things: - Strips out a lot of redundant calls (due to callbacks firing) as well as reducing the amount of separate helper methods (by one, but it counts) - Makes the currently detected / selected media type "stickier" so that it persists more properly across changing systems. This also has the ability of showing the "detected disc was X but system does not support it" message in more relevant cases now. - Makes HD-DVD a first-class citizen, since apparently DiscImageCreator can dump it using the `dvd` command On the side, this also adds more prototype code and notes for removing DIC as the way to get drive speeds.

claunia added the pull-request label 2026-01-29 16:24:28 +00:00

claunia closed this issue

2026-01-29 16:24:28 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#952