SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 21:30:16 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #85] [MERGED] Cleanups and Mixups #953

New Issue
Open
opened 2026-01-29 16:24:29 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:29 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/85
Author: @mnadareski
Created: 7/6/2018
Status: ✅ Merged
Merged: 7/6/2018
Merged by: @mnadareski

Base: master ← Head: r4

📝 Commits (10+)

📊 Changes

9 files changed (+338 additions, -326 deletions)

View changed files

📝 DICUI.Test/Utilities/KnownSystemExtensionsTest.cs (+6 -14)
📝 DICUI/DICUI.csproj (+1 -0)
📝 DICUI/External/ProtectionFind.cs (+51 -68)
📝 DICUI/MainWindow.xaml.cs (+28 -111)
📝 DICUI/Tasks.cs (+68 -1)
📝 DICUI/Utilities/Converters.cs (+0 -113)
📝 DICUI/Utilities/DumpEnvironment.cs (+20 -0)
➕ DICUI/Utilities/Extensions.cs (+116 -0)
📝 DICUI/Utilities/Validators.cs (+48 -19)

📄 Description

This PR is a grab-bag of changes. In no particular order:

  • Cleanup a bunch of comments, whitespaces, and some minor syntactic things
  • Fix scanning for SecuROM 4 and 5 and getting the version number properly (a la #83)
  • Added the Zzxzz copy protection to the list of known ones
  • Made disc speed finding into a non-blocking task and added a check for the DIC firmware issue (fixes #81)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/85 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/6/2018 **Status:** ✅ Merged **Merged:** 7/6/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r4` --- ### 📝 Commits (10+) - [`2cfce39`](https://github.com/SabreTools/MPF/commit/2cfce3943a6a7d9ff689b8cf5d79050a606c847f) Class reorganization - [`74da1a0`](https://github.com/SabreTools/MPF/commit/74da1a054a8cf3314b6c0f096111de20c09a8556) Fix SecuROM 4/5 version finding - [`72efe57`](https://github.com/SabreTools/MPF/commit/72efe57368f6597ec8a732d87a77d953e88266bf) Fix commented VB code - [`6b4dfb8`](https://github.com/SabreTools/MPF/commit/6b4dfb81132253b4017220c07d175f42c206986f) Clean up var declarations - [`048045a`](https://github.com/SabreTools/MPF/commit/048045accf8f6a03f39e06b6d822ca2c356f30ce) Fix space - [`19869ce`](https://github.com/SabreTools/MPF/commit/19869cecad32795cb4c645119e67c095c7f3f2da) Add Zzxzz to path detectors - [`d9bee25`](https://github.com/SabreTools/MPF/commit/d9bee2556db83b143de5f6eb4e0f977a7c3997c5) Minor cleanups - [`619ec48`](https://github.com/SabreTools/MPF/commit/619ec48c4a7512d4664e95f48333c01daa4021ee) Remove TODO in lieu of #83 - [`d77c6bb`](https://github.com/SabreTools/MPF/commit/d77c6bba74c82394233cf4ff7b0e0ae2e5570bed) Add placehold if-statements - [`bb754b0`](https://github.com/SabreTools/MPF/commit/bb754b0eb8153b9b8a324532dcb689e15767fa0c) If no drives, then we can't copy protect scan either ### 📊 Changes **9 files changed** (+338 additions, -326 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Test/Utilities/KnownSystemExtensionsTest.cs` (+6 -14) 📝 `DICUI/DICUI.csproj` (+1 -0) 📝 `DICUI/External/ProtectionFind.cs` (+51 -68) 📝 `DICUI/MainWindow.xaml.cs` (+28 -111) 📝 `DICUI/Tasks.cs` (+68 -1) 📝 `DICUI/Utilities/Converters.cs` (+0 -113) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+20 -0) ➕ `DICUI/Utilities/Extensions.cs` (+116 -0) 📝 `DICUI/Utilities/Validators.cs` (+48 -19) </details> ### 📄 Description This PR is a grab-bag of changes. In no particular order: - Cleanup a bunch of comments, whitespaces, and some minor syntactic things - Fix scanning for SecuROM 4 and 5 and getting the version number properly (a la #83) - Added the Zzxzz copy protection to the list of known ones - Made disc speed finding into a non-blocking task and added a check for the DIC firmware issue (fixes #81) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?