SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 05:37:45 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #88] [MERGED] Bits and Bobs #956

New Issue
Closed
opened 2026-01-29 16:24:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:30 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/88
Author: @mnadareski
Created: 7/7/2018
Status: ✅ Merged
Merged: 7/7/2018
Merged by: @mnadareski

Base: master ← Head: r6

📝 Commits (10+)

  • c10a624 Finally overhaul UI element naming
  • 1ee52fc Re-enable disk scan button
  • 69e2438 Add cabfile scanning
  • a295cec Fix csproj
  • 46c4151 Fix TODO
  • b23e8a9 Add a couple more protections, disable one for now
  • e4a4127 Fix SecuROM 7 detection
  • 3b9ed81 No beep for eject and speed check
  • 7d463c1 Fix Options after renames
  • 8e65d45 Ensure disc information in couple places again

📊 Changes

11 files changed (+224 additions, -151 deletions)

View changed files

📝 DICUI/App.config (+3 -3)
📝 DICUI/DICUI.csproj (+12 -0)
📝 DICUI/External/ProtectionFind.cs (+53 -5)
📝 DICUI/MainWindow.xaml (+13 -13)
📝 DICUI/MainWindow.xaml.cs (+106 -98)
📝 DICUI/Options.cs (+6 -6)
📝 DICUI/OptionsWindow.xaml (+12 -12)
📝 DICUI/OptionsWindow.xaml.cs (+10 -10)
📝 DICUI/Utilities/DumpEnvironment.cs (+4 -4)
➕ DICUI/mspack.dll (+0 -0)
➕ DICUI/packages.config (+5 -0)

📄 Description

Disclaimer: Nobody named Bob was harmed in the making of this PR

This PR is (again) a bunch of small stuff that I wanted to throw in all at once:

  • Renamed all the UI elements internally to fit the proper naming scheme
  • Re-enabled the disk scanning button (my bad)
  • Added and fixed a couple protections including being able to scan in MS CAB files
  • Disabled beep for eject and speed check

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/88 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/7/2018 **Status:** ✅ Merged **Merged:** 7/7/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r6` --- ### 📝 Commits (10+) - [`c10a624`](https://github.com/SabreTools/MPF/commit/c10a62421983ee899be06b0c0471dc49a05b437a) Finally overhaul UI element naming - [`1ee52fc`](https://github.com/SabreTools/MPF/commit/1ee52fc985765ac1de035b20bf134de52c723450) Re-enable disk scan button - [`69e2438`](https://github.com/SabreTools/MPF/commit/69e243850cc78e9bcaccb1c18ed233855dd762a5) Add cabfile scanning - [`a295cec`](https://github.com/SabreTools/MPF/commit/a295cec3b55df0a4743ecedcd97cea9b57fc6456) Fix csproj - [`46c4151`](https://github.com/SabreTools/MPF/commit/46c4151cad96af443d47c9b18738dff8ccf8d582) Fix TODO - [`b23e8a9`](https://github.com/SabreTools/MPF/commit/b23e8a9146d11dff8f3de7571529d8a5cae5dfcf) Add a couple more protections, disable one for now - [`e4a4127`](https://github.com/SabreTools/MPF/commit/e4a4127d81685ec7ad9480e7dbcdccb9268a3927) Fix SecuROM 7 detection - [`3b9ed81`](https://github.com/SabreTools/MPF/commit/3b9ed810b1721b4e857b17f7adf4446b1706e08a) No beep for eject and speed check - [`7d463c1`](https://github.com/SabreTools/MPF/commit/7d463c1d2f59e2f6a38c327ff10f57adfac90192) Fix Options after renames - [`8e65d45`](https://github.com/SabreTools/MPF/commit/8e65d45716598837d315672cdd756200f79bb4a3) Ensure disc information in couple places again ### 📊 Changes **11 files changed** (+224 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/App.config` (+3 -3) 📝 `DICUI/DICUI.csproj` (+12 -0) 📝 `DICUI/External/ProtectionFind.cs` (+53 -5) 📝 `DICUI/MainWindow.xaml` (+13 -13) 📝 `DICUI/MainWindow.xaml.cs` (+106 -98) 📝 `DICUI/Options.cs` (+6 -6) 📝 `DICUI/OptionsWindow.xaml` (+12 -12) 📝 `DICUI/OptionsWindow.xaml.cs` (+10 -10) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+4 -4) ➕ `DICUI/mspack.dll` (+0 -0) ➕ `DICUI/packages.config` (+5 -0) </details> ### 📄 Description **Disclaimer:** Nobody named Bob was harmed in the making of this PR This PR is (again) a bunch of small stuff that I wanted to throw in all at once: - Renamed all the UI elements internally to fit the proper naming scheme - Re-enabled the disk scanning button (my bad) - Added and fixed a couple protections including being able to scan in MS CAB files - Disabled beep for eject and speed check --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?