SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #84] Refactor of ComboBox underlying types #957

New Issue
Closed
opened 2026-01-29 16:24:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:30 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/SabreTools/MPF/pull/84

State: closed
Merged: Yes

This PR is aimed to solve how ComboBox were populated. The old approach used tuples to just wrap together values but without any semantic.

This has been refactored:

  • added KnownSystemCategory enum
  • added KnownSystem special marker values to split KnownSystems into categories
  • added KnownSystemComboBoxItem which can hold a KnownSystem or a KnownSystemCategory
  • rewrote system population function (and split the actual population for the UI only, with headers)
  • adjusted ComboBox bindings to use this new approach
  • added Drive class to store letter, volume label and isFloppy flag
  • adjusted drives ComboBox to use this new object
  • modified DumpEnvironment to use Drive instead that separated attributes
  • removed OrderedDictionary (not needed anymore and hopefully we won't need it again)

DICUI is now 100% KeyValuePair/Tuple free! :)

**Original Pull Request:** https://github.com/SabreTools/MPF/pull/84 **State:** closed **Merged:** Yes --- This PR is aimed to solve how ComboBox were populated. The old approach used tuples to just wrap together values but without any semantic. This has been refactored: - added `KnownSystemCategory` enum - added `KnownSystem` special marker values to split `KnownSystems` into categories - added `KnownSystemComboBoxItem` which can hold a `KnownSystem` or a `KnownSystemCategory` - rewrote system population function (and split the actual population for the UI only, with headers) - adjusted `ComboBox` bindings to use this new approach - added `Drive` class to store letter, volume label and `isFloppy` flag - adjusted drives `ComboBox` to use this new object - modified `DumpEnvironment` to use `Drive` instead that separated attributes - removed `OrderedDictionary` (not needed anymore and hopefully we won't need it again) DICUI is now 100% `KeyValuePair`/`Tuple` free! :)
claunia added the pull-request label 2026-01-29 16:24:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#957
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?