[PR #89] [MERGED] Remove Disable Beep; Handle Error Case #958

New Issue

Closed

opened 2026-01-29 16:24:32 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:32 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/89
Author: @mnadareski
Created: 7/7/2018
Status: ✅ Merged
Merged: 7/7/2018
Merged by: @mnadareski

Base: master ← Head: r7

---

📝 Commits (3)

• cd5bdf0 Disable beep not supported for these
• 86cdb4e Remove testing code
• 3ba8e63 Extra fixing for process issues

📊 Changes

1 file changed (+25 additions, -6 deletions)

View changed files

📝 DICUI/Utilities/DumpEnvironment.cs (+25 -6)

📄 Description

This PR removes the "disable beep" flag from the Eject and Get Drive Speed calls to DIC, since it's not supported for those. This was found from seeing a couple dozen instances of DiscImageCreator sitting in Task Manager after testing. This also makes the drive speed finding more robust so that it tries to fail fast.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/89 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/7/2018 **Status:** ✅ Merged **Merged:** 7/7/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r7` --- ### 📝 Commits (3) - [`cd5bdf0`](https://github.com/SabreTools/MPF/commit/cd5bdf07beb0d7edc66e76842c1f062ae20cb2a8) Disable beep not supported for these - [`86cdb4e`](https://github.com/SabreTools/MPF/commit/86cdb4eca2b7c07cfce095d798447391831df697) Remove testing code - [`3ba8e63`](https://github.com/SabreTools/MPF/commit/3ba8e632e5aed54943948d8cb7dca924db1af121) Extra fixing for process issues ### 📊 Changes **1 file changed** (+25 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/Utilities/DumpEnvironment.cs` (+25 -6) </details> ### 📄 Description This PR removes the "disable beep" flag from the Eject and Get Drive Speed calls to DIC, since it's not supported for those. This was found from seeing a couple dozen instances of DiscImageCreator sitting in Task Manager after testing. This also makes the drive speed finding more robust so that it tries to fail fast. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:32 +00:00

claunia closed this issue 2026-01-29 16:24:32 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#958