[PR #90] [MERGED] Added new options #959

New Issue

claunia · 2026-01-29T16:24:32Z

claunia commented

2026-01-29 16:24:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/90
Author: @Jakz
Created: 7/9/2018
Status: ✅ Merged
Merged: 7/10/2018
Merged by: @mnadareski

Base: master ← Head: extra_options

📝 Commits (10+)

d68e186 Split type combobox into system combobox and disc type combobox
ffb53dd updated fork to head
21969f9 corrected indentation for xaml file
d296b9a fixed merge with head
596e26e fixed format
20243dc fixed issues for PR, added KnownSystem.CUSTOM
5ba23b9 removed Updater.cs which ended by error in commit
66d06f1 fixed GetOuptutName() for new drive/system combobox
b4400fb Merge branch 'master' of github.com:reignstumble/DICUI
2bac147 Merge branch 'master' of github.com:reignstumble/DICUI

📊 Changes

12 files changed (+195 additions, -36 deletions)

View changed files

📝 DICUI.Test/Utilities/ConvertersTest.cs (+19 -11)
📝 DICUI.Test/Utilities/ValidatorsTest.cs (+1 -1)
📝 DICUI/App.config (+2 -0)
📝 DICUI/DICUI.csproj (+1 -0)
📝 DICUI/MainWindow.xaml (+2 -1)
📝 DICUI/MainWindow.xaml.cs (+15 -1)
📝 DICUI/Options.cs (+14 -9)
📝 DICUI/OptionsWindow.xaml (+54 -4)
➕ DICUI/UI/ViewModels.cs (+52 -0)
📝 DICUI/Utilities/Converters.cs (+22 -6)
📝 DICUI/Utilities/DumpEnvironment.cs (+12 -2)
📝 DICUI/Utilities/Validators.cs (+1 -1)

📄 Description

This PR adds some customization to the DIC process, it adds 4 options which can be changed in specific window.

Fixed Unknown system which wasn't present anymore in combobox
Created new ViewModels file which should contain all the view models needed by the UI
Added Quiet mode option to disable DIC sounds
Added Paranoid mode option which should enable all pedantic flags
Added Disable Media Type Detection to disable detection at startup (which is not always needed and can slow down startup by a lot
Added configurable /c2 flag reread amount value

This PR is also a proof of concept about how binding between data and views should be done in WPF (so that we should follow this approach in general).

I left 2 TODOs, both relative to KnownSystemAndMediaTypeToParameters since paranoid flags and their tests should be handled by someone with a better knowledge of flag meanings (I choose you @mnadareski!)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/90 **Author:** [@Jakz](https://github.com/Jakz) **Created:** 7/9/2018 **Status:** ✅ Merged **Merged:** 7/10/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `extra_options` --- ### 📝 Commits (10+) - [`d68e186`](https://github.com/SabreTools/MPF/commit/d68e1869f5889756a0017328fa9d173f5f204560) Split type combobox into system combobox and disc type combobox - [`ffb53dd`](https://github.com/SabreTools/MPF/commit/ffb53dde7a176aa046ce0df435ae830d4ee4d347) updated fork to head - [`21969f9`](https://github.com/SabreTools/MPF/commit/21969f951d4bcf5bf8e9d7746dc304a1c7270dcf) corrected indentation for xaml file - [`d296b9a`](https://github.com/SabreTools/MPF/commit/d296b9a92fe9899bcde4d90609dae4ddb78de55e) fixed merge with head - [`596e26e`](https://github.com/SabreTools/MPF/commit/596e26e8d25298e4d906592f27a46fe9ee79a8b1) fixed format - [`20243dc`](https://github.com/SabreTools/MPF/commit/20243dcec9883ce6d60faf9cb27f5d600584618b) fixed issues for PR, added KnownSystem.CUSTOM - [`5ba23b9`](https://github.com/SabreTools/MPF/commit/5ba23b9c22a94d7436d024a0ec4a8e226d27110b) removed Updater.cs which ended by error in commit - [`66d06f1`](https://github.com/SabreTools/MPF/commit/66d06f16aeed1910270c1cb72ec50446229951f9) fixed GetOuptutName() for new drive/system combobox - [`b4400fb`](https://github.com/SabreTools/MPF/commit/b4400fb6bb830563c87eac07aad28bb56da90366) Merge branch 'master' of github.com:reignstumble/DICUI - [`2bac147`](https://github.com/SabreTools/MPF/commit/2bac14716f6f7f73d40fec25bcef49254aa33c3f) Merge branch 'master' of github.com:reignstumble/DICUI ### 📊 Changes **12 files changed** (+195 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Test/Utilities/ConvertersTest.cs` (+19 -11) 📝 `DICUI.Test/Utilities/ValidatorsTest.cs` (+1 -1) 📝 `DICUI/App.config` (+2 -0) 📝 `DICUI/DICUI.csproj` (+1 -0) 📝 `DICUI/MainWindow.xaml` (+2 -1) 📝 `DICUI/MainWindow.xaml.cs` (+15 -1) 📝 `DICUI/Options.cs` (+14 -9) 📝 `DICUI/OptionsWindow.xaml` (+54 -4) ➕ `DICUI/UI/ViewModels.cs` (+52 -0) 📝 `DICUI/Utilities/Converters.cs` (+22 -6) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+12 -2) 📝 `DICUI/Utilities/Validators.cs` (+1 -1) </details> ### 📄 Description This PR adds some customization to the DIC process, it adds 4 options which can be changed in specific window. - Fixed `Unknown` system which wasn't present anymore in combobox - Created new `ViewModels` file which should contain all the view models needed by the UI - Added Quiet mode option to disable DIC sounds - Added Paranoid mode option which should enable all pedantic flags - Added Disable Media Type Detection to disable detection at startup (which is not always needed and can slow down startup by a lot - Added configurable /c2 flag reread amount value This PR is also a proof of concept about how binding between data and views should be done in WPF (so that we should follow this approach in general). I left 2 TODOs, both relative to `KnownSystemAndMediaTypeToParameters` since paranoid flags and their tests should be handled by someone with a better knowledge of flag meanings (I choose you @mnadareski!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:24:32 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#959