SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #91] [MERGED] Create Parameters Class #960

New Issue
Open
opened 2026-01-29 16:24:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/91
Author: @mnadareski
Created: 7/10/2018
Status: ✅ Merged
Merged: 7/10/2018
Merged by: @mnadareski

Base: master ← Head: r9

📝 Commits (10+)

📊 Changes

21 files changed (+1879 additions, -795 deletions)

View changed files

📝 DICUI.Test/DICUI.Test.csproj (+3 -0)
📝 DICUI.Test/Utilities/ConvertersTest.cs (+34 -65)
➕ DICUI.Test/Utilities/DICCommandExtensionsTest.cs (+23 -0)
➕ DICUI.Test/Utilities/DICFlagExtensionsTest.cs (+23 -0)
📝 DICUI.Test/Utilities/DumpEnvironmentTest.cs (+3 -3)
➕ DICUI.Test/Utilities/ParametersTest.cs (+82 -0)
📝 DICUI.Test/Utilities/ValidatorsTest.cs (+1 -32)
📝 DICUI/App.config (+2 -0)
📝 DICUI/DICUI.csproj (+2 -0)
📝 DICUI/Data/Constants.cs (+3 -3)
📝 DICUI/Data/Enumerations.cs (+55 -0)
📝 DICUI/MainWindow.xaml (+2 -1)
📝 DICUI/MainWindow.xaml.cs (+16 -2)
📝 DICUI/Options.cs (+14 -9)
📝 DICUI/OptionsWindow.xaml (+54 -4)
➕ DICUI/UI/ViewModels.cs (+52 -0)
📝 DICUI/Utilities/Converters.cs (+143 -146)
📝 DICUI/Utilities/DumpEnvironment.cs (+20 -17)
📝 DICUI/Utilities/Extensions.cs (+22 -0)
➕ DICUI/Utilities/Parameters.cs (+1324 -0)

...and 1 more files

📄 Description

This PR creates a Parameters class to wrap all of the possible flag and command combinations that could be created. It has currently replaced the original instances of the string parameters, but essentially does nothing more than that did before. There should be no remaining duplicate code.

This change can be used to extend the flag combinations and user inputs that are possible through the UI, since every possible flag is accounted for, by default.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/91 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/10/2018 **Status:** ✅ Merged **Merged:** 7/10/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r9` --- ### 📝 Commits (10+) - [`577d462`](https://github.com/SabreTools/MPF/commit/577d462935dc4c84663f48b457d6e6eec807a8df) Update commented code - [`f46a1ef`](https://github.com/SabreTools/MPF/commit/f46a1efbf68c945a278cda30de02378e65eba711) Add Parameters class - [`1afc8fd`](https://github.com/SabreTools/MPF/commit/1afc8fd51f128d8a44d9bb8a09973267a69a80b0) Add better documentation - [`c59dee9`](https://github.com/SabreTools/MPF/commit/c59dee91deccdf5d3e327f4790829ce331c62d5b) Add and use DICFlag enumeration - [`906a227`](https://github.com/SabreTools/MPF/commit/906a2274332d5297f3e6f9bb2ee7c1f33d15d5b9) Port more things to Parameter-specific version - [`dca73c5`](https://github.com/SabreTools/MPF/commit/dca73c554d625d4ca3df158dbacd8a3368475d3f) Add commented code for later - [`d51adcc`](https://github.com/SabreTools/MPF/commit/d51adccab40e53e9b28774a6765d811950c45aeb) Added new options (#90) - [`a16138b`](https://github.com/SabreTools/MPF/commit/a16138b5efc103111973289813b95242985b9ed9) Update commented code - [`825968c`](https://github.com/SabreTools/MPF/commit/825968cdb940691a4d40d01b70e8a07640636a32) Add Parameters class - [`5b8eee3`](https://github.com/SabreTools/MPF/commit/5b8eee3a333f52ac1a00f7b8b218b66c19d47761) Add better documentation ### 📊 Changes **21 files changed** (+1879 additions, -795 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Test/DICUI.Test.csproj` (+3 -0) 📝 `DICUI.Test/Utilities/ConvertersTest.cs` (+34 -65) ➕ `DICUI.Test/Utilities/DICCommandExtensionsTest.cs` (+23 -0) ➕ `DICUI.Test/Utilities/DICFlagExtensionsTest.cs` (+23 -0) 📝 `DICUI.Test/Utilities/DumpEnvironmentTest.cs` (+3 -3) ➕ `DICUI.Test/Utilities/ParametersTest.cs` (+82 -0) 📝 `DICUI.Test/Utilities/ValidatorsTest.cs` (+1 -32) 📝 `DICUI/App.config` (+2 -0) 📝 `DICUI/DICUI.csproj` (+2 -0) 📝 `DICUI/Data/Constants.cs` (+3 -3) 📝 `DICUI/Data/Enumerations.cs` (+55 -0) 📝 `DICUI/MainWindow.xaml` (+2 -1) 📝 `DICUI/MainWindow.xaml.cs` (+16 -2) 📝 `DICUI/Options.cs` (+14 -9) 📝 `DICUI/OptionsWindow.xaml` (+54 -4) ➕ `DICUI/UI/ViewModels.cs` (+52 -0) 📝 `DICUI/Utilities/Converters.cs` (+143 -146) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+20 -17) 📝 `DICUI/Utilities/Extensions.cs` (+22 -0) ➕ `DICUI/Utilities/Parameters.cs` (+1324 -0) _...and 1 more files_ </details> ### 📄 Description This PR creates a Parameters class to wrap all of the possible flag and command combinations that could be created. It has currently replaced the original instances of the string parameters, but essentially does nothing more than that did before. There should be no remaining duplicate code. This change can be used to extend the flag combinations and user inputs that are possible through the UI, since every possible flag is accounted for, by default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#960
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?