SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #92] [MERGED] Protection Is Key #961

New Issue
Open
opened 2026-01-29 16:24:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/92
Author: @mnadareski
Created: 7/10/2018
Status: ✅ Merged
Merged: 7/10/2018
Merged by: @mnadareski

Base: master ← Head: r10

📝 Commits (3)

📊 Changes

11 files changed (+177 additions, -35 deletions)

View changed files

📝 DICUI/DICUI.csproj (+12 -2)
📝 DICUI/External/BurnOut/EVORE.cs (+1 -1)
📝 DICUI/External/BurnOut/ProtectionFind.cs (+59 -31)
➕ DICUI/External/iXcomp/IXComp.cs (+104 -0)
➕ DICUI/Programs/ZD50149.DLL (+0 -0)
➕ DICUI/Programs/ZD51145.DLL (+0 -0)
➕ DICUI/Programs/ZD55131.DLL (+0 -0)
➕ DICUI/Programs/i3comp.exe (+0 -0)
➕ DICUI/Programs/i5comp.exe (+0 -0)
➕ DICUI/Programs/i6comp.exe (+0 -0)
📝 DICUI/Utilities/Validators.cs (+1 -1)

📄 Description

This PR does two major things:

  1. Fixes SafeDisc protection detection (especially for version numbers)
  2. Adds a semi-closed source solution to extracting and scanning InstallShield CAB files (part of #83)

This PR opens a few questions, unfortunately:

  • Can a fully open-source solution be used for InstallShield CAB files?
  • Are the protections that include a position--; statement in them accurate?
  • How to handle even newer InstallShield CAB/installer files?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/92 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/10/2018 **Status:** ✅ Merged **Merged:** 7/10/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r10` --- ### 📝 Commits (3) - [`a6d7b49`](https://github.com/SabreTools/MPF/commit/a6d7b49d1b40f2db9b0b49a1de5e9904389594ed) Fix some protections, start adding IS scanning - [`a27ef5b`](https://github.com/SabreTools/MPF/commit/a27ef5b88b980846276c1c4dcf7d542a1cc81089) Fix IS CAB - [`7ac7ad4`](https://github.com/SabreTools/MPF/commit/7ac7ad44e07f2a3a7814e3713f93bb1e9a8bb2f9) Update TODO ### 📊 Changes **11 files changed** (+177 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/DICUI.csproj` (+12 -2) 📝 `DICUI/External/BurnOut/EVORE.cs` (+1 -1) 📝 `DICUI/External/BurnOut/ProtectionFind.cs` (+59 -31) ➕ `DICUI/External/iXcomp/IXComp.cs` (+104 -0) ➕ `DICUI/Programs/ZD50149.DLL` (+0 -0) ➕ `DICUI/Programs/ZD51145.DLL` (+0 -0) ➕ `DICUI/Programs/ZD55131.DLL` (+0 -0) ➕ `DICUI/Programs/i3comp.exe` (+0 -0) ➕ `DICUI/Programs/i5comp.exe` (+0 -0) ➕ `DICUI/Programs/i6comp.exe` (+0 -0) 📝 `DICUI/Utilities/Validators.cs` (+1 -1) </details> ### 📄 Description This PR does two major things: 1. Fixes SafeDisc protection detection (especially for version numbers) 2. Adds a semi-closed source solution to extracting and scanning InstallShield CAB files (part of #83) This PR opens a few questions, unfortunately: - Can a fully open-source solution be used for InstallShield CAB files? - Are the protections that include a `position--;` statement in them accurate? - How to handle even newer InstallShield CAB/installer files? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?