SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 21:30:16 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #93] [MERGED] Protection, Progress, and (Possibly) Empty Drives #962

New Issue
Open
opened 2026-01-29 16:24:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:33 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/93
Author: @mnadareski
Created: 7/12/2018
Status: ✅ Merged
Merged: 7/14/2018
Merged by: @mnadareski

Base: master ← Head: r11

📝 Commits (10+)

📊 Changes

30 files changed (+2170 additions, -197 deletions)

View changed files

📝 DICUI.Test/Utilities/DriveTest.cs (+1 -1)
📝 DICUI.Test/Utilities/DumpEnvironmentTest.cs (+1 -1)
📝 DICUI/DICUI.csproj (+15 -10)
📝 DICUI/Data/Constants.cs (+1 -0)
📝 DICUI/External/BurnOut/ProtectionFind.cs (+106 -58)
➕ DICUI/External/Unshield/CabDescriptor.cs (+15 -0)
➕ DICUI/External/Unshield/CommonHeader.cs (+48 -0)
➕ DICUI/External/Unshield/FileDescriptor.cs (+17 -0)
➕ DICUI/External/Unshield/Header.cs (+240 -0)
➕ DICUI/External/Unshield/LICENSE (+24 -0)
➕ DICUI/External/Unshield/OffsetList.cs (+9 -0)
➕ DICUI/External/Unshield/StringBuffer.cs (+8 -0)
➕ DICUI/External/Unshield/UnshieldCabinet.cs (+1180 -0)
➕ DICUI/External/Unshield/UnshieldComponent.cs (+61 -0)
➕ DICUI/External/Unshield/UnshieldFileGroup.cs (+36 -0)
➕ DICUI/External/Unshield/UnshieldReader.cs (+327 -0)
➕ DICUI/External/Unshield/VolumeHeader.cs (+22 -0)
➖ DICUI/External/iXcomp/IXComp.cs (+0 -104)
📝 DICUI/MainWindow.xaml.cs (+16 -4)
➖ DICUI/Programs/ZD50149.DLL (+0 -0)

...and 10 more files

📄 Description

This PR is four-pronged:

  • Fixes for protection scanning, specifically for SolidShield 1 and a more accurate way of determining file type other than the extensions (where possible) (reference #83 )
  • Added a rudimentary progress indicator callback for the dumping process (this will probably be removed in the future when the integrated commandline window gets added)
  • Added support for selecting drives that Windows sees as empty. This should allow non-WIndows filesystems such as HFS and 3DO to be dumped properly, even if we don't know if there's a disc there
    • This change makes it so that the first known active drive is selected even if all drives are listed
    • This change also adds a check before dumping a "missing" disc just so the users know that there may not be anything actually in the drive
  • Added a C# implementation of Unshield and removed the iXcomp external calls in the process

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/93 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/12/2018 **Status:** ✅ Merged **Merged:** 7/14/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r11` --- ### 📝 Commits (10+) - [`d310b69`](https://github.com/SabreTools/MPF/commit/d310b697c9531d475ffd021e8f115afc7f264dee) Include but mark inactive drives (fixes #87) - [`df9268c`](https://github.com/SabreTools/MPF/commit/df9268c639f0a586542e628dc97a333b3f8574b8) Add more checks for the active flag - [`19e2faa`](https://github.com/SabreTools/MPF/commit/19e2faae9f336ee9ad000bd8692989c41ac68efa) Force users to choose on dump - [`df4c9fa`](https://github.com/SabreTools/MPF/commit/df4c9fa682ed2480744747040ae36312e2740126) Fix quotes - [`637b872`](https://github.com/SabreTools/MPF/commit/637b8729e7bf08381112b59309687d799a0d7da0) Update SolidShield 1 - [`ee67bea`](https://github.com/SabreTools/MPF/commit/ee67beab7462fc67e42666cc25e433159f4c737b) Select first active by default - [`2895f72`](https://github.com/SabreTools/MPF/commit/2895f72495086ae56d15a168e70767f1d2b55bf2) Add TODO - [`92e874e`](https://github.com/SabreTools/MPF/commit/92e874e5c703a85bdf227125a63ca92bc2f5804f) Add dumping progress indicator - [`d203335`](https://github.com/SabreTools/MPF/commit/d203335c5a641795d513dc5cfbd338e2830259bf) Clamp runtime - [`74ae5bf`](https://github.com/SabreTools/MPF/commit/74ae5bf8be3c1e570e0e3e6aea7c83c00fcffdec) Add first textfile scans; EA CdKey ### 📊 Changes **30 files changed** (+2170 additions, -197 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Test/Utilities/DriveTest.cs` (+1 -1) 📝 `DICUI.Test/Utilities/DumpEnvironmentTest.cs` (+1 -1) 📝 `DICUI/DICUI.csproj` (+15 -10) 📝 `DICUI/Data/Constants.cs` (+1 -0) 📝 `DICUI/External/BurnOut/ProtectionFind.cs` (+106 -58) ➕ `DICUI/External/Unshield/CabDescriptor.cs` (+15 -0) ➕ `DICUI/External/Unshield/CommonHeader.cs` (+48 -0) ➕ `DICUI/External/Unshield/FileDescriptor.cs` (+17 -0) ➕ `DICUI/External/Unshield/Header.cs` (+240 -0) ➕ `DICUI/External/Unshield/LICENSE` (+24 -0) ➕ `DICUI/External/Unshield/OffsetList.cs` (+9 -0) ➕ `DICUI/External/Unshield/StringBuffer.cs` (+8 -0) ➕ `DICUI/External/Unshield/UnshieldCabinet.cs` (+1180 -0) ➕ `DICUI/External/Unshield/UnshieldComponent.cs` (+61 -0) ➕ `DICUI/External/Unshield/UnshieldFileGroup.cs` (+36 -0) ➕ `DICUI/External/Unshield/UnshieldReader.cs` (+327 -0) ➕ `DICUI/External/Unshield/VolumeHeader.cs` (+22 -0) ➖ `DICUI/External/iXcomp/IXComp.cs` (+0 -104) 📝 `DICUI/MainWindow.xaml.cs` (+16 -4) ➖ `DICUI/Programs/ZD50149.DLL` (+0 -0) _...and 10 more files_ </details> ### 📄 Description This PR is four-pronged: - Fixes for protection scanning, specifically for SolidShield 1 and a more accurate way of determining file type other than the extensions (where possible) (reference #83 ) - Added a rudimentary progress indicator callback for the dumping process (this will probably be removed in the future when the integrated commandline window gets added) - Added support for selecting drives that Windows sees as empty. This should allow non-WIndows filesystems such as HFS and 3DO to be dumped properly, even if we don't know if there's a disc there - This change makes it so that the first known active drive is selected even if all drives are listed - This change also adds a check before dumping a "missing" disc just so the users know that there may not be anything actually in the drive - Added a C# implementation of [Unshield](https://github.com/twogood/unshield) and removed the iXcomp external calls in the process --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?