[PR #91] Create Parameters Class #964

New Issue

Closed

opened 2026-01-29 16:24:33 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:33 +00:00

Owner

Copy Link

Original Pull Request: https://github.com/SabreTools/MPF/pull/91

State: closed
Merged: Yes

---

This PR creates a Parameters class to wrap all of the possible flag and command combinations that could be created. It has currently replaced the original instances of the string parameters, but essentially does nothing more than that did before. There should be no remaining duplicate code.

This change can be used to extend the flag combinations and user inputs that are possible through the UI, since every possible flag is accounted for, by default.

**Original Pull Request:** https://github.com/SabreTools/MPF/pull/91 **State:** closed **Merged:** Yes --- This PR creates a Parameters class to wrap all of the possible flag and command combinations that could be created. It has currently replaced the original instances of the string parameters, but essentially does nothing more than that did before. There should be no remaining duplicate code. This change can be used to extend the flag combinations and user inputs that are possible through the UI, since every possible flag is accounted for, by default.

claunia added the pull-request label 2026-01-29 16:24:33 +00:00

claunia closed this issue 2026-01-29 16:24:33 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#964