SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #92] Protection Is Key #965

New Issue
Closed
opened 2026-01-29 16:24:33 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:33 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/SabreTools/MPF/pull/92

State: closed
Merged: Yes

This PR does two major things:

  1. Fixes SafeDisc protection detection (especially for version numbers)
  2. Adds a semi-closed source solution to extracting and scanning InstallShield CAB files (part of #83)

This PR opens a few questions, unfortunately:

  • Can a fully open-source solution be used for InstallShield CAB files?
  • Are the protections that include a position--; statement in them accurate?
  • How to handle even newer InstallShield CAB/installer files?
**Original Pull Request:** https://github.com/SabreTools/MPF/pull/92 **State:** closed **Merged:** Yes --- This PR does two major things: 1. Fixes SafeDisc protection detection (especially for version numbers) 2. Adds a semi-closed source solution to extracting and scanning InstallShield CAB files (part of #83) This PR opens a few questions, unfortunately: - Can a fully open-source solution be used for InstallShield CAB files? - Are the protections that include a `position--;` statement in them accurate? - How to handle even newer InstallShield CAB/installer files?
claunia added the pull-request label 2026-01-29 16:24:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?