SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-13 05:35:26 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #95] [MERGED] Log Window enhancements #966

New Issue
Open
opened 2026-01-29 16:24:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/95
Author: @Jakz
Created: 7/14/2018
Status: ✅ Merged
Merged: 7/14/2018
Merged by: @mnadareski

Base: master ← Head: log_window

📝 Commits (10+)

  • d68e186 Split type combobox into system combobox and disc type combobox
  • ffb53dd updated fork to head
  • 21969f9 corrected indentation for xaml file
  • d296b9a fixed merge with head
  • 596e26e fixed format
  • 20243dc fixed issues for PR, added KnownSystem.CUSTOM
  • 5ba23b9 removed Updater.cs which ended by error in commit
  • 66d06f1 fixed GetOuptutName() for new drive/system combobox
  • b4400fb Merge branch 'master' of github.com:reignstumble/DICUI
  • 2bac147 Merge branch 'master' of github.com:reignstumble/DICUI

📊 Changes

5 files changed (+20 additions, -5 deletions)

View changed files

📝 DICUI/DICUI.csproj (+1 -0)
📝 DICUI/Data/Constants.cs (+2 -0)
📝 DICUI/LogWindow.xaml.cs (+2 -1)
📝 DICUI/MainWindow.xaml (+1 -1)
📝 DICUI/MainWindow.xaml.cs (+14 -3)

📄 Description

Added precise position calculation of MainWindow when LogWindow is shown at startup and fixed bring to top behavior of LogWindow

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/95 **Author:** [@Jakz](https://github.com/Jakz) **Created:** 7/14/2018 **Status:** ✅ Merged **Merged:** 7/14/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `log_window` --- ### 📝 Commits (10+) - [`d68e186`](https://github.com/SabreTools/MPF/commit/d68e1869f5889756a0017328fa9d173f5f204560) Split type combobox into system combobox and disc type combobox - [`ffb53dd`](https://github.com/SabreTools/MPF/commit/ffb53dde7a176aa046ce0df435ae830d4ee4d347) updated fork to head - [`21969f9`](https://github.com/SabreTools/MPF/commit/21969f951d4bcf5bf8e9d7746dc304a1c7270dcf) corrected indentation for xaml file - [`d296b9a`](https://github.com/SabreTools/MPF/commit/d296b9a92fe9899bcde4d90609dae4ddb78de55e) fixed merge with head - [`596e26e`](https://github.com/SabreTools/MPF/commit/596e26e8d25298e4d906592f27a46fe9ee79a8b1) fixed format - [`20243dc`](https://github.com/SabreTools/MPF/commit/20243dcec9883ce6d60faf9cb27f5d600584618b) fixed issues for PR, added KnownSystem.CUSTOM - [`5ba23b9`](https://github.com/SabreTools/MPF/commit/5ba23b9c22a94d7436d024a0ec4a8e226d27110b) removed Updater.cs which ended by error in commit - [`66d06f1`](https://github.com/SabreTools/MPF/commit/66d06f16aeed1910270c1cb72ec50446229951f9) fixed GetOuptutName() for new drive/system combobox - [`b4400fb`](https://github.com/SabreTools/MPF/commit/b4400fb6bb830563c87eac07aad28bb56da90366) Merge branch 'master' of github.com:reignstumble/DICUI - [`2bac147`](https://github.com/SabreTools/MPF/commit/2bac14716f6f7f73d40fec25bcef49254aa33c3f) Merge branch 'master' of github.com:reignstumble/DICUI ### 📊 Changes **5 files changed** (+20 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/DICUI.csproj` (+1 -0) 📝 `DICUI/Data/Constants.cs` (+2 -0) 📝 `DICUI/LogWindow.xaml.cs` (+2 -1) 📝 `DICUI/MainWindow.xaml` (+1 -1) 📝 `DICUI/MainWindow.xaml.cs` (+14 -3) </details> ### 📄 Description Added precise position calculation of MainWindow when LogWindow is shown at startup and fixed bring to top behavior of LogWindow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#966
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?