SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #97] [MERGED] Whole Cleanup #968

New Issue
Closed
opened 2026-01-29 16:24:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/97
Author: @mnadareski
Created: 7/16/2018
Status: ✅ Merged
Merged: 7/16/2018
Merged by: @mnadareski

Base: master ← Head: r12

📝 Commits (8)

📊 Changes

8 files changed (+116 additions, -53 deletions)

View changed files

📝 DICUI/DICUI.csproj (+1 -0)
📝 DICUI/External/BurnOut/ProtectionFind.cs (+4 -15)
📝 DICUI/External/Unshield/UnshieldComponent.cs (+1 -1)
📝 DICUI/LogWindow.xaml.cs (+0 -6)
📝 DICUI/MainWindow.xaml.cs (+1 -7)
📝 DICUI/UI/ViewModels.cs (+0 -6)
➕ DICUI/Utilities/CaseInsensitiveDictionary.cs (+95 -0)
📝 DICUI/Utilities/DumpEnvironment.cs (+14 -18)

📄 Description

This PR is mostly cleanup but has the following notable additions:

  • Added the CaseInsensitiveDictionary wrapper class for easier matching for filenames
  • Fixed the Eject After Dump option
  • Made the default "couldn't find a volume name" include the proper extension
  • Fixed layerbreak finding for dual-layer discs (sorry everyone)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/97 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/16/2018 **Status:** ✅ Merged **Merged:** 7/16/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r12` --- ### 📝 Commits (8) - [`4564277`](https://github.com/SabreTools/MPF/commit/456427748c242d10fabcd5fba57146a04e96ab44) Cleanup TODOs - [`5908807`](https://github.com/SabreTools/MPF/commit/5908807c5809b5f1de3ef2c6ea723a11e7ff1dc2) Remove more TODOs - [`db65d7c`](https://github.com/SabreTools/MPF/commit/db65d7c4d5d1092e40302b00d7132ca2676f73d0) Add case-insensitive dictionary for protection scans - [`e939995`](https://github.com/SabreTools/MPF/commit/e9399953f07b6e9e10212a6e2d5607266e8b2ed3) Namespace cleanups - [`2058b25`](https://github.com/SabreTools/MPF/commit/2058b2586e94dac9e521dafbabd23b904af44f23) Space - [`c59dbda`](https://github.com/SabreTools/MPF/commit/c59dbda26a5db3c05188fb696e9bf1e51bb2df11) Minor fixes - [`702429d`](https://github.com/SabreTools/MPF/commit/702429d9663a352c566a750a576889baa3f9f6b1) Oops - [`33182da`](https://github.com/SabreTools/MPF/commit/33182da6efcc70eab0a5951c443936a2abecbe07) Change layerbreak detect value ### 📊 Changes **8 files changed** (+116 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/DICUI.csproj` (+1 -0) 📝 `DICUI/External/BurnOut/ProtectionFind.cs` (+4 -15) 📝 `DICUI/External/Unshield/UnshieldComponent.cs` (+1 -1) 📝 `DICUI/LogWindow.xaml.cs` (+0 -6) 📝 `DICUI/MainWindow.xaml.cs` (+1 -7) 📝 `DICUI/UI/ViewModels.cs` (+0 -6) ➕ `DICUI/Utilities/CaseInsensitiveDictionary.cs` (+95 -0) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+14 -18) </details> ### 📄 Description This PR is mostly cleanup but has the following notable additions: - Added the `CaseInsensitiveDictionary` wrapper class for easier matching for filenames - Fixed the Eject After Dump option - Made the default "couldn't find a volume name" include the proper extension - Fixed layerbreak finding for dual-layer discs (sorry everyone) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#968
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?