[PR #101] [MERGED] Goodbye drive speed finders #970

New Issue

Closed

opened 2026-01-29 16:24:35 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:35 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/101
Author: @mnadareski
Created: 7/17/2018
Status: ✅ Merged
Merged: 7/18/2018
Merged by: @mnadareski

Base: master ← Head: r14

---

📝 Commits (3)

• b60a72a Goodbye drive speed finders
• ad0adec More accurate scaling
• c94a888 Ensure disposal

📊 Changes

3 files changed (+57 additions, -269 deletions)

View changed files

📝 DICUI/MainWindow.xaml.cs (+47 -63)
📝 DICUI/Utilities/DumpEnvironment.cs (+10 -42)
📝 DICUI/Utilities/Validators.cs (+0 -164)

📄 Description

This PR mainly exists to remove the code related to finding the current drive speed in order to determine the dumping speed. This seems to be mostly unused as nearly all vocal users end up setting the value manually or have set their preferred value in the options.

As an additional bonus, this also cleans up the DPI scaling a bit to have less P/Invoke.

Fixes #69
Fixes #55

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/101 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 7/17/2018 **Status:** ✅ Merged **Merged:** 7/18/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `r14` --- ### 📝 Commits (3) - [`b60a72a`](https://github.com/SabreTools/MPF/commit/b60a72a377a6277e8756142514505693b10dccd1) Goodbye drive speed finders - [`ad0adec`](https://github.com/SabreTools/MPF/commit/ad0adec9896904244ca50a4538387bba0e45ca74) More accurate scaling - [`c94a888`](https://github.com/SabreTools/MPF/commit/c94a888a3296cb37a3e7fd0b9d5c3a6ebf204666) Ensure disposal ### 📊 Changes **3 files changed** (+57 additions, -269 deletions) <details> <summary>View changed files</summary> 📝 `DICUI/MainWindow.xaml.cs` (+47 -63) 📝 `DICUI/Utilities/DumpEnvironment.cs` (+10 -42) 📝 `DICUI/Utilities/Validators.cs` (+0 -164) </details> ### 📄 Description This PR mainly exists to remove the code related to finding the current drive speed in order to determine the dumping speed. This seems to be mostly unused as nearly all vocal users end up setting the value manually or have set their preferred value in the options. As an additional bonus, this also cleans up the DPI scaling a bit to have less P/Invoke. Fixes #69 Fixes #55 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:35 +00:00

claunia closed this issue 2026-01-29 16:24:35 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#970