SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #122] [MERGED] Abstract out non-UI code to separate DLL #974

New Issue
Closed
opened 2026-01-29 16:24:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/122
Author: @mnadareski
Created: 10/2/2018
Status: ✅ Merged
Merged: 10/8/2018
Merged by: @mnadareski

Base: master ← Head: library

📝 Commits (5)

  • f5cfa9f Abstract out non-UI code to separate DLL
  • c7d72f5 Remove MessageBox from library
  • a612972 Options is more UI-related
  • b391893 Fix Nuget references in csproj
  • eebf77d Add Winforms UI

📊 Changes

50 files changed (+5087 additions, -257 deletions)

View changed files

➕ DICUI.Forms/App.config (+6 -0)
📝 DICUI.Forms/Constants.cs (+12 -7)
➕ DICUI.Forms/DICUI.Forms.csproj (+116 -0)
➕ DICUI.Forms/EnumDescriptionConverter.cs (+33 -0)
➕ DICUI.Forms/Icon.ico (+0 -0)
➕ DICUI.Forms/KnownSystemComboBoxItem.cs (+35 -0)
➕ DICUI.Forms/Options.cs (+97 -0)
➕ DICUI.Forms/Program.cs (+20 -0)
➕ DICUI.Forms/Properties/AssemblyInfo.cs (+36 -0)
➕ DICUI.Forms/Properties/Settings1.Designer.cs (+26 -0)
➕ DICUI.Forms/Properties/Settings1.settings (+6 -0)
➕ DICUI.Forms/ViewModels.cs (+107 -0)
➕ DICUI.Forms/Windows/LogWindow.Designer.cs (+175 -0)
➕ DICUI.Forms/Windows/LogWindow.cs (+380 -0)
➕ DICUI.Forms/Windows/LogWindow.resx (+123 -0)
➕ DICUI.Forms/Windows/MainWindow.Designer.cs (+530 -0)
➕ DICUI.Forms/Windows/MainWindow.cs (+723 -0)
➕ DICUI.Forms/Windows/MainWindow.resx (+1395 -0)
➕ DICUI.Forms/Windows/OptionsWindow.Designer.cs (+565 -0)
➕ DICUI.Forms/Windows/OptionsWindow.cs (+179 -0)

...and 30 more files

📄 Description

This change seems rather large, but it's mostly just moving anything that is not directly driving the UI to its own, separate library. This will make it easier at a later date for any UI improvements or changes as well as making the code much more discrete.

The end goal of this change is to be able to get a mono-compatible or .NET Core-driven UI, especially since there's a linux build of DiscImageCreator now.

This change now contains a proof-of-concept UI created in Winforms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/122 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 10/2/2018 **Status:** ✅ Merged **Merged:** 10/8/2018 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `library` --- ### 📝 Commits (5) - [`f5cfa9f`](https://github.com/SabreTools/MPF/commit/f5cfa9fb3401c45fc8ec30757b29c6fd628cac00) Abstract out non-UI code to separate DLL - [`c7d72f5`](https://github.com/SabreTools/MPF/commit/c7d72f5b216e2d0e26563dbba393f16c9822dcd0) Remove MessageBox from library - [`a612972`](https://github.com/SabreTools/MPF/commit/a612972a0781e0595022558b3d1a60a89e371387) Options is more UI-related - [`b391893`](https://github.com/SabreTools/MPF/commit/b3918931c95261ee4198af410a7c3beed6d6bdde) Fix Nuget references in csproj - [`eebf77d`](https://github.com/SabreTools/MPF/commit/eebf77d186a9b1b8634c62baa2fb367fec5e44be) Add Winforms UI ### 📊 Changes **50 files changed** (+5087 additions, -257 deletions) <details> <summary>View changed files</summary> ➕ `DICUI.Forms/App.config` (+6 -0) 📝 `DICUI.Forms/Constants.cs` (+12 -7) ➕ `DICUI.Forms/DICUI.Forms.csproj` (+116 -0) ➕ `DICUI.Forms/EnumDescriptionConverter.cs` (+33 -0) ➕ `DICUI.Forms/Icon.ico` (+0 -0) ➕ `DICUI.Forms/KnownSystemComboBoxItem.cs` (+35 -0) ➕ `DICUI.Forms/Options.cs` (+97 -0) ➕ `DICUI.Forms/Program.cs` (+20 -0) ➕ `DICUI.Forms/Properties/AssemblyInfo.cs` (+36 -0) ➕ `DICUI.Forms/Properties/Settings1.Designer.cs` (+26 -0) ➕ `DICUI.Forms/Properties/Settings1.settings` (+6 -0) ➕ `DICUI.Forms/ViewModels.cs` (+107 -0) ➕ `DICUI.Forms/Windows/LogWindow.Designer.cs` (+175 -0) ➕ `DICUI.Forms/Windows/LogWindow.cs` (+380 -0) ➕ `DICUI.Forms/Windows/LogWindow.resx` (+123 -0) ➕ `DICUI.Forms/Windows/MainWindow.Designer.cs` (+530 -0) ➕ `DICUI.Forms/Windows/MainWindow.cs` (+723 -0) ➕ `DICUI.Forms/Windows/MainWindow.resx` (+1395 -0) ➕ `DICUI.Forms/Windows/OptionsWindow.Designer.cs` (+565 -0) ➕ `DICUI.Forms/Windows/OptionsWindow.cs` (+179 -0) _...and 30 more files_ </details> ### 📄 Description This change seems rather large, but it's mostly just moving anything that is not directly driving the UI to its own, separate library. This will make it easier at a later date for any UI improvements or changes as well as making the code much more discrete. ~~The end goal of this change is to be able to get a mono-compatible or .NET Core-driven UI, especially since there's a linux build of DiscImageCreator now.~~ This change now contains a proof-of-concept UI created in Winforms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?