SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #161] [MERGED] Even More Info #978

New Issue
Open
opened 2026-01-29 16:24:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/161
Author: @mnadareski
Created: 9/17/2019
Status: ✅ Merged
Merged: 9/18/2019
Merged by: @mnadareski

Base: master ← Head: even-more-info

📝 Commits (8)

  • 3b320d8 Add (currently) hidden setting for disc info
  • 14c6e84 Show setting in Options menu
  • 2faaff3 Fix new window
  • f6c0784 New place for combo box items
  • aceff65 Fixes to outputs
  • a3146a6 Add category, fix a few things
  • 025358f Actually use the custom converter
  • dea85ac Allow tabs in ringcode

📊 Changes

16 files changed (+1127 additions, -461 deletions)

View changed files

📝 DICUI.Check/Program.cs (+1 -0)
📝 DICUI.Library/Data/Enumerations.cs (+10 -0)
📝 DICUI.Library/Data/SubmissionInfo.cs (+293 -241)
📝 DICUI.Library/Utilities/Converters.cs (+133 -3)
📝 DICUI.Library/Utilities/DumpEnvironment.cs (+222 -204)
➕ DICUI/ComboBoxItems/CategoryComboBoxItem.cs (+29 -0)
📝 DICUI/ComboBoxItems/KnownSystemComboBoxItem.cs (+0 -0)
➕ DICUI/ComboBoxItems/LanguageComboBoxItem.cs (+29 -0)
📝 DICUI/ComboBoxItems/MediaTypeComboBoxItem.cs (+0 -0)
➕ DICUI/ComboBoxItems/RegionComboBoxItem.cs (+30 -0)
📝 DICUI/DICUI.csproj (+12 -2)
📝 DICUI/Options.cs (+2 -0)
➕ DICUI/Windows/DiscInformationWindow.xaml (+156 -0)
➕ DICUI/Windows/DiscInformationWindow.xaml.cs (+163 -0)
📝 DICUI/Windows/MainWindow.xaml.cs (+29 -0)
📝 DICUI/Windows/OptionsWindow.xaml (+18 -11)

📄 Description

This change does a lot of stuff, most of which is not worth talking about:

  • It rearranges SubmissionInfo to make it more modular. Doesn't take advantage of it, though.
  • It adds a new window so you can type in disc info. It's mostly functional.
  • Made sure that this doesn't screw up DICUI-Check. Because we don't want UI in our CLI.

It also might have screwed up other things, but hey, that's what the people who test are there to find.

Closes https://github.com/SabreTools/DICUI/issues/159 at least for the time being

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/161 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 9/17/2019 **Status:** ✅ Merged **Merged:** 9/18/2019 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `even-more-info` --- ### 📝 Commits (8) - [`3b320d8`](https://github.com/SabreTools/MPF/commit/3b320d8d98e97092659b71b11070c4946042e3bb) Add (currently) hidden setting for disc info - [`14c6e84`](https://github.com/SabreTools/MPF/commit/14c6e84a39715488cd8b6999025d95003192090a) Show setting in Options menu - [`2faaff3`](https://github.com/SabreTools/MPF/commit/2faaff3b11b6f606d7b8dc7d76dc11ee75332596) Fix new window - [`f6c0784`](https://github.com/SabreTools/MPF/commit/f6c07848c0076f567c1b94a9df4559d654e6905f) New place for combo box items - [`aceff65`](https://github.com/SabreTools/MPF/commit/aceff655ab414d6963e63ba80ac42a022b273cb2) Fixes to outputs - [`a3146a6`](https://github.com/SabreTools/MPF/commit/a3146a6bce767b87ba60cebb80c264ebf77e7fec) Add category, fix a few things - [`025358f`](https://github.com/SabreTools/MPF/commit/025358f5df4c9dbfb8d0c66455370e1d4c2cc2e4) Actually use the custom converter - [`dea85ac`](https://github.com/SabreTools/MPF/commit/dea85ac3994ba24c46842c6093f91f0a3043f9f5) Allow tabs in ringcode ### 📊 Changes **16 files changed** (+1127 additions, -461 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Check/Program.cs` (+1 -0) 📝 `DICUI.Library/Data/Enumerations.cs` (+10 -0) 📝 `DICUI.Library/Data/SubmissionInfo.cs` (+293 -241) 📝 `DICUI.Library/Utilities/Converters.cs` (+133 -3) 📝 `DICUI.Library/Utilities/DumpEnvironment.cs` (+222 -204) ➕ `DICUI/ComboBoxItems/CategoryComboBoxItem.cs` (+29 -0) 📝 `DICUI/ComboBoxItems/KnownSystemComboBoxItem.cs` (+0 -0) ➕ `DICUI/ComboBoxItems/LanguageComboBoxItem.cs` (+29 -0) 📝 `DICUI/ComboBoxItems/MediaTypeComboBoxItem.cs` (+0 -0) ➕ `DICUI/ComboBoxItems/RegionComboBoxItem.cs` (+30 -0) 📝 `DICUI/DICUI.csproj` (+12 -2) 📝 `DICUI/Options.cs` (+2 -0) ➕ `DICUI/Windows/DiscInformationWindow.xaml` (+156 -0) ➕ `DICUI/Windows/DiscInformationWindow.xaml.cs` (+163 -0) 📝 `DICUI/Windows/MainWindow.xaml.cs` (+29 -0) 📝 `DICUI/Windows/OptionsWindow.xaml` (+18 -11) </details> ### 📄 Description This change does a lot of stuff, most of which is not worth talking about: - It rearranges SubmissionInfo to make it more modular. Doesn't take advantage of it, though. - It adds a new window so you can type in disc info. It's mostly functional. - Made sure that this doesn't screw up DICUI-Check. Because we don't want UI in our CLI. It also might have screwed up other things, but hey, that's what the people who test are there to find. Closes https://github.com/SabreTools/DICUI/issues/159 at least for the time being --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?