SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 21:30:16 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #188] [MERGED] Preliminary Support for DiscImageChef #982

New Issue
Closed
opened 2026-01-29 16:24:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/188
Author: @mnadareski
Created: 2/2/2020
Status: ✅ Merged
Merged: 2/3/2020
Merged by: @mnadareski

Base: master ← Head: cooks-in-the-kitchen

📝 Commits (10+)

📊 Changes

19 files changed (+3480 additions, -304 deletions)

View changed files

📝 DICUI.Library/Data/Constants.cs (+452 -1)
📝 DICUI.Library/Data/Enumerations.cs (+137 -1)
➕ DICUI.Library/Utilities/ChefParameters.cs (+1970 -0)
📝 DICUI.Library/Utilities/Converters.cs (+380 -3)
📝 DICUI.Library/Utilities/CreatorParameters.cs (+221 -190)
📝 DICUI.Library/Utilities/DumpEnvironment.cs (+154 -28)
📝 DICUI.Library/Utilities/Extensions.cs (+9 -0)
📝 DICUI.Test/Utilities/ConvertersTest.cs (+1 -1)
📝 DICUI.Test/Utilities/MediaTypeExtensionsTest.cs (+1 -1)
📝 DICUI/App.config (+4 -2)
📝 DICUI/EnumDescriptionConverter.cs (+5 -1)
📝 DICUI/Options.cs (+9 -2)
📝 DICUI/ViewModels.cs (+6 -0)
📝 DICUI/Windows/MainWindow.xaml (+1 -1)
📝 DICUI/Windows/MainWindow.xaml.cs (+90 -49)
📝 DICUI/Windows/OptionsWindow.xaml (+17 -12)
📝 DICUI/Windows/OptionsWindow.xaml.cs (+1 -1)
📝 README.md (+8 -4)
📝 appveyor.yml (+14 -7)

📄 Description

This PR is a massive amount of work to support DiscImageChef to the same base level as DiscImageCreator. Here is a list of things that it does and does not do:

  • Adds paths, command, and flag validation specific to DiscImageChef
  • Add nearly all constants and enumerations required for current and future work
  • Update other parts of code with improvements from the DiscImageChef parameter work
  • Add non-UI setting for enabling DiscImageChef dumping
  • NO submission info generation or output file parsing
  • NO split file outputs to correspond to DiscImageCreator compatibility
  • Edited default paths for both DiscImageCreator and Subdump to reflect the possibility of more supported programs in the future
  • Updated DiscImageCreator version for automated builds
  • NO automatic building or pulling of DiscImageChef test versions
  • Assumes DICF output for all current purposes. Additional format output support will have to take a lot of extra effort
  • Unexpectedly does some work for Creator since the version updated again during the course of this PR. One flag was removed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/188 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 2/2/2020 **Status:** ✅ Merged **Merged:** 2/3/2020 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `cooks-in-the-kitchen` --- ### 📝 Commits (10+) - [`ea3dea7`](https://github.com/SabreTools/MPF/commit/ea3dea7a42af61c66a796ad163eb26078eb7291e) Professional cook - [`1c5e364`](https://github.com/SabreTools/MPF/commit/1c5e364e3851e5fa3926a6ff69408dca1cd1dea5) Accuracy improvements - [`98657f0`](https://github.com/SabreTools/MPF/commit/98657f0d490623855cd5070df8cad07ba9b904e1) Better yet - [`aabe389`](https://github.com/SabreTools/MPF/commit/aabe3891c64a51edfa8d5f0e4e0a3323bd033ce0) Spicy - [`a1eb2f0`](https://github.com/SabreTools/MPF/commit/a1eb2f07608b49729af0c717a8a98420d034315b) Simplify and reduce - [`1638294`](https://github.com/SabreTools/MPF/commit/16382941487cbabd6afe057fb3aba1732676bfe6) You eye note - [`d77420a`](https://github.com/SabreTools/MPF/commit/d77420a6e0af8ac11192c5f95173de8616accc68) More info for validation - [`2966ab1`](https://github.com/SabreTools/MPF/commit/2966ab16dbe51cf5a185d857a57e43e646b8bd74) Read you - [`1ed241f`](https://github.com/SabreTools/MPF/commit/1ed241f87101665d4113c36272a06f76e031ec9d) Verbose - [`adc8cde`](https://github.com/SabreTools/MPF/commit/adc8cdef24c739f620bacdaa2c154f99b654fd0d) Typo ### 📊 Changes **19 files changed** (+3480 additions, -304 deletions) <details> <summary>View changed files</summary> 📝 `DICUI.Library/Data/Constants.cs` (+452 -1) 📝 `DICUI.Library/Data/Enumerations.cs` (+137 -1) ➕ `DICUI.Library/Utilities/ChefParameters.cs` (+1970 -0) 📝 `DICUI.Library/Utilities/Converters.cs` (+380 -3) 📝 `DICUI.Library/Utilities/CreatorParameters.cs` (+221 -190) 📝 `DICUI.Library/Utilities/DumpEnvironment.cs` (+154 -28) 📝 `DICUI.Library/Utilities/Extensions.cs` (+9 -0) 📝 `DICUI.Test/Utilities/ConvertersTest.cs` (+1 -1) 📝 `DICUI.Test/Utilities/MediaTypeExtensionsTest.cs` (+1 -1) 📝 `DICUI/App.config` (+4 -2) 📝 `DICUI/EnumDescriptionConverter.cs` (+5 -1) 📝 `DICUI/Options.cs` (+9 -2) 📝 `DICUI/ViewModels.cs` (+6 -0) 📝 `DICUI/Windows/MainWindow.xaml` (+1 -1) 📝 `DICUI/Windows/MainWindow.xaml.cs` (+90 -49) 📝 `DICUI/Windows/OptionsWindow.xaml` (+17 -12) 📝 `DICUI/Windows/OptionsWindow.xaml.cs` (+1 -1) 📝 `README.md` (+8 -4) 📝 `appveyor.yml` (+14 -7) </details> ### 📄 Description This PR is a massive amount of work to support DiscImageChef to the same base level as DiscImageCreator. Here is a list of things that it does and does not do: - Adds paths, command, and flag validation specific to DiscImageChef - Add nearly all constants and enumerations required for current and future work - Update other parts of code with improvements from the DiscImageChef parameter work - Add non-UI setting for enabling DiscImageChef dumping - **NO** submission info generation or output file parsing - **NO** split file outputs to correspond to DiscImageCreator compatibility - Edited default paths for both DiscImageCreator and Subdump to reflect the possibility of more supported programs in the future - Updated DiscImageCreator version for automated builds - **NO** automatic building or pulling of DiscImageChef test versions - Assumes DICF output for all current purposes. Additional format output support will have to take a lot of extra effort - Unexpectedly does some work for Creator since the version updated *again* during the course of this PR. One flag was removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#982
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?