[PR #172] [MERGED] Advanced Support #983

Closed
opened 2026-01-29 16:24:40 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/172
Author: @mnadareski
Created: 11/17/2019
Status: Merged
Merged: 11/17/2019
Merged by: @mnadareski

Base: masterHead: advanced


📝 Commits (9)

  • 17d829d Who doesn't like drives?
  • 6244a76 Add another TODO
  • cfe59d9 Use built in stuff, it's quicker
  • a3fd5ca More special handling for floppies, easier this time
  • 6e14645 Fix broken test
  • c73b492 Set active drive priority, String -> string
  • 8885418 Track reason for no scanning
  • da084db Merge branch 'master' into advanced
  • 0cef4d5 Update DIC version and release notes

📊 Changes

14 files changed (+178 additions, -97 deletions)

View changed files

📝 CHANGELIST.md (+6 -0)
📝 DICUI.Library/Data/Enumerations.cs (+15 -0)
📝 DICUI.Library/Utilities/Converters.cs (+26 -0)
📝 DICUI.Library/Utilities/Drive.cs (+36 -25)
📝 DICUI.Library/Utilities/DumpEnvironment.cs (+18 -13)
📝 DICUI.Library/Utilities/Parameters.cs (+10 -8)
📝 DICUI.Library/Utilities/Validators.cs (+33 -16)
📝 DICUI.Library/Web/CookieAwareWebClient.cs (+1 -1)
DICUI.Test/Utilities/DriveTest.cs (+0 -15)
📝 DICUI.Test/Utilities/DumpEnvironmentTest.cs (+5 -2)
📝 DICUI/Properties/AssemblyInfo.cs (+2 -2)
📝 DICUI/Windows/LogWindow.xaml.cs (+2 -2)
📝 DICUI/Windows/MainWindow.xaml.cs (+19 -8)
📝 appveyor.yml (+5 -5)

📄 Description

Add advanced drive support, because it's fun.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/172 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 11/17/2019 **Status:** ✅ Merged **Merged:** 11/17/2019 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `advanced` --- ### 📝 Commits (9) - [`17d829d`](https://github.com/SabreTools/MPF/commit/17d829da40d6be4eb7f93c357cb4b151e4cfae7b) Who doesn't like drives? - [`6244a76`](https://github.com/SabreTools/MPF/commit/6244a76ff6f0e268b1f3fbd782c7bdf64717be94) Add another TODO - [`cfe59d9`](https://github.com/SabreTools/MPF/commit/cfe59d93a5e4b91fee9246f6fa96d88c497d0e49) Use built in stuff, it's quicker - [`a3fd5ca`](https://github.com/SabreTools/MPF/commit/a3fd5caa3ec00c705f7bef6ed1c10319a3fbeda0) More special handling for floppies, easier this time - [`6e14645`](https://github.com/SabreTools/MPF/commit/6e146454dc05802bb138cb14855742ce2b855f8b) Fix broken test - [`c73b492`](https://github.com/SabreTools/MPF/commit/c73b4929069a202d3806460043f0a3bf7b8c6ff1) Set active drive priority, String -> string - [`8885418`](https://github.com/SabreTools/MPF/commit/8885418fb79cb8541ad13e41657eea23b164ce0e) Track reason for no scanning - [`da084db`](https://github.com/SabreTools/MPF/commit/da084dbe785d2d166552195a0d3974d6570ad89c) Merge branch 'master' into advanced - [`0cef4d5`](https://github.com/SabreTools/MPF/commit/0cef4d5d3dbfb22f87605db3286ff38de2964c14) Update DIC version and release notes ### 📊 Changes **14 files changed** (+178 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+6 -0) 📝 `DICUI.Library/Data/Enumerations.cs` (+15 -0) 📝 `DICUI.Library/Utilities/Converters.cs` (+26 -0) 📝 `DICUI.Library/Utilities/Drive.cs` (+36 -25) 📝 `DICUI.Library/Utilities/DumpEnvironment.cs` (+18 -13) 📝 `DICUI.Library/Utilities/Parameters.cs` (+10 -8) 📝 `DICUI.Library/Utilities/Validators.cs` (+33 -16) 📝 `DICUI.Library/Web/CookieAwareWebClient.cs` (+1 -1) ➖ `DICUI.Test/Utilities/DriveTest.cs` (+0 -15) 📝 `DICUI.Test/Utilities/DumpEnvironmentTest.cs` (+5 -2) 📝 `DICUI/Properties/AssemblyInfo.cs` (+2 -2) 📝 `DICUI/Windows/LogWindow.xaml.cs` (+2 -2) 📝 `DICUI/Windows/MainWindow.xaml.cs` (+19 -8) 📝 `appveyor.yml` (+5 -5) </details> ### 📄 Description Add advanced drive support, because it's fun. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:40 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#983