[PR #197] Cleanup and Upgrades #984

New Issue

claunia · 2026-01-29T16:24:40Z

claunia commented

2026-01-29 16:24:40 +00:00

Original Pull Request: https://github.com/SabreTools/MPF/pull/197

State: closed
Merged: Yes

This PR ended up being a monster in terms of what it's actually doing, so here's an attempt at what's going on:

Updated the .NET Core 3.0 build to the more stable .NET Core 3.1. In the process, remove .NET Framework-specific things from the .NET Core build so that they don't fail quite as miserably. Unfortunately, it's still not feature-complete compared, but at least it should run.
Added .NET 4.8 as a new build target. This is honestly a "just because" addition, but it's one step closer to the mythical .NET 5.0 that should be coming out at some point
A LOT of cleanup happened with poorly named, arranged, coded, and otherwise bad code. This came from me just hacking everything together at certain points, so this was long-overdue
Aaru (formerly DiscImageChef) support has been further enhanced. Based on the idea that DICUI is not only going to be a frontend for DIC and Aaru in the future (I'd love to add dd support at some point), I needed to make sure that the code was ready for new commandline programs. This meant a lot of restructuring, a lot of renaming, and a lot of broken code. This should be all set now.
Remove "CD Check" from the list out outputted protections. For the purposes of Redump (the project that makes the most heavy use of this program), including "CD Check" in the list of copy protections is actually a bit misleading. It may be correct that it looks for the disc, but it's not a copy protection by itself. Therefore, for the time being, all "CD Check" instances are being removed from the list of outputted protections. If this is requested back in the future, I will try to add a flag for it.
As a last-minute addition to this, DIC has also been updated to the most recent version (which adds some bugfixes, extra output info, and better support for VideoNow XP)

**Original Pull Request:** https://github.com/SabreTools/MPF/pull/197 **State:** closed **Merged:** Yes --- This PR ended up being a monster in terms of what it's actually doing, so here's an attempt at what's going on: - Updated the .NET Core 3.0 build to the more stable .NET Core 3.1. In the process, remove .NET Framework-specific things from the .NET Core build so that they don't fail quite as miserably. Unfortunately, it's still not feature-complete compared, but at least it should run. - Added .NET 4.8 as a new build target. This is honestly a "just because" addition, but it's one step closer to the mythical .NET 5.0 that should be coming out at some point - A LOT of cleanup happened with poorly named, arranged, coded, and otherwise bad code. This came from me just hacking everything together at certain points, so this was long-overdue - Aaru (formerly DiscImageChef) support has been further enhanced. Based on the idea that DICUI is not only going to be a frontend for DIC and Aaru in the future (I'd love to add `dd` support at some point), I needed to make sure that the code was ready for new commandline programs. This meant a lot of restructuring, a lot of renaming, and a lot of broken code. This should be all set now. - Remove "CD Check" from the list out outputted protections. For the purposes of Redump (the project that makes the most heavy use of this program), including "CD Check" in the list of copy protections is actually a bit misleading. It may be correct that it looks for the disc, but it's not a copy protection by itself. Therefore, for the time being, all "CD Check" instances are being removed from the list of outputted protections. If this is requested back in the future, I will try to add a flag for it. - As a last-minute addition to this, DIC has also been updated to the most recent version (which adds some bugfixes, extra output info, and better support for VideoNow XP)

claunia added the pull-request label 2026-01-29 16:24:40 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#984