[PR #269] [MERGED] Add option to compress log files after dumping #988

New Issue

Open

opened 2026-01-29 16:24:41 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:41 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/269
Author: @mnadareski
Created: 4/3/2021
Status: ✅ Merged
Merged: 4/3/2021
Merged by: @mnadareski

Base: master ← Head: logjam

---

📝 Commits (10+)

• da0bf64 Add log compression option
• 01bf3c9 Add log file compression
• 96fa8d8 Add DiscImageCreator log paths
• 3230d59 Fix options window
• ad5cd5b Only encode artifacts if we're outputting JSON
• 096a8a6 Add Aaru log file paths, remove TODO in DIC
• 4fd51db Default to false, for now
• 742db4c Change default archive name
• 1a52a3a Add Check parameter for compression
• 7e5952b Add log file lsits for CleanRip and UIC

📊 Changes

12 files changed (+369 additions, -82 deletions)

View changed files

📝 CHANGELIST.md (+1 -0)
📝 MPF.Check/Program.cs (+9 -1)
📝 MPF.Library/Aaru/Parameters.cs (+59 -14)
📝 MPF.Library/CleanRIp/Parameters.cs (+29 -6)
📝 MPF.Library/DD/Parameters.cs (+1 -1)
📝 MPF.Library/Data/BaseParameters.cs (+9 -1)
📝 MPF.Library/Data/DumpEnvironment.cs (+57 -1)
📝 MPF.Library/Data/Options.cs (+9 -0)
📝 MPF.Library/DiscImageCreator/Parameters.cs (+154 -48)
📝 MPF.Library/MPF.Library.csproj (+1 -0)
📝 MPF.Library/UmdImageCreator/Parameters.cs (+35 -10)
📝 MPF/Windows/OptionsWindow.xaml (+5 -0)

📄 Description

This has been a long-requested feature that we finally have room in the options menu to support. This new option allows for all files considered "log files" to be compressed into a zip file after dumping, deleting the uncompressed versions. This helps save on space and helps with submissions. This option currently defaults to disabled.

Both Aaru and DiscImageCreator currently support this, as they're the only ones that have log files and dumping support combined. This has been tested to ensure that all log files (including the dreaded new command file in DIC) are archived. Edit: As of one of the more recent commits, Check support has been added so compression can be applied after the fact. This also means that both CleanRip and UmdImageCreator both can have their logs compressed as well.

This also fixes another related issue where if users don't want to output the JSON, we shouldn't collect the artifact information. This can potentially lead to memory issues.

Fixes https://github.com/SabreTools/MPF/issues/22

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/269 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 4/3/2021 **Status:** ✅ Merged **Merged:** 4/3/2021 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `logjam` --- ### 📝 Commits (10+) - [`da0bf64`](https://github.com/SabreTools/MPF/commit/da0bf64e94e93f5e74fe9871d8f5bfa39e8c28bd) Add log compression option - [`01bf3c9`](https://github.com/SabreTools/MPF/commit/01bf3c9efb76b6d15892e4aa34e38c4f446b714b) Add log file compression - [`96fa8d8`](https://github.com/SabreTools/MPF/commit/96fa8d8cef4374a791134198d6a1ec3ad47ada56) Add DiscImageCreator log paths - [`3230d59`](https://github.com/SabreTools/MPF/commit/3230d59f6abac163092dd6faa22494fb3d4ab4fb) Fix options window - [`ad5cd5b`](https://github.com/SabreTools/MPF/commit/ad5cd5b8f9ba6c12e1ab0641b80a1379f8c775ca) Only encode artifacts if we're outputting JSON - [`096a8a6`](https://github.com/SabreTools/MPF/commit/096a8a6a06dac9cf77b1377de09663a489252bf8) Add Aaru log file paths, remove TODO in DIC - [`4fd51db`](https://github.com/SabreTools/MPF/commit/4fd51dbe4528bb3f5b423277cac7fd1a9c4b73d2) Default to false, for now - [`742db4c`](https://github.com/SabreTools/MPF/commit/742db4c8546bd158e2c92a6131104e8e709be25d) Change default archive name - [`1a52a3a`](https://github.com/SabreTools/MPF/commit/1a52a3a205c84e12904a35c4eb39035af1237897) Add Check parameter for compression - [`7e5952b`](https://github.com/SabreTools/MPF/commit/7e5952bbb8ec557d3a7cd28565d21084439075b4) Add log file lsits for CleanRip and UIC ### 📊 Changes **12 files changed** (+369 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELIST.md` (+1 -0) 📝 `MPF.Check/Program.cs` (+9 -1) 📝 `MPF.Library/Aaru/Parameters.cs` (+59 -14) 📝 `MPF.Library/CleanRIp/Parameters.cs` (+29 -6) 📝 `MPF.Library/DD/Parameters.cs` (+1 -1) 📝 `MPF.Library/Data/BaseParameters.cs` (+9 -1) 📝 `MPF.Library/Data/DumpEnvironment.cs` (+57 -1) 📝 `MPF.Library/Data/Options.cs` (+9 -0) 📝 `MPF.Library/DiscImageCreator/Parameters.cs` (+154 -48) 📝 `MPF.Library/MPF.Library.csproj` (+1 -0) 📝 `MPF.Library/UmdImageCreator/Parameters.cs` (+35 -10) 📝 `MPF/Windows/OptionsWindow.xaml` (+5 -0) </details> ### 📄 Description This has been a long-requested feature that we finally have room in the options menu to support. This new option allows for all files considered "log files" to be compressed into a zip file after dumping, deleting the uncompressed versions. This helps save on space and helps with submissions. This option currently defaults to disabled. Both Aaru and DiscImageCreator currently support this, as they're the only ones that have log files and dumping support combined. This has been tested to ensure that all log files (including the dreaded new command file in DIC) are archived. **Edit:** As of one of the more recent commits, Check support has been added so compression can be applied after the fact. This also means that both CleanRip and UmdImageCreator both can have their logs compressed as well. This also fixes another related issue where if users don't want to output the JSON, we shouldn't collect the artifact information. This can potentially lead to memory issues. Fixes https://github.com/SabreTools/MPF/issues/22 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:41 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#988