mirror of
https://github.com/SabreTools/MPF.git
synced 2026-07-02 17:24:48 +00:00
[PR #269] Add option to compress log files after dumping #991
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/SabreTools/MPF/pull/269
State: closed
Merged: Yes
This has been a long-requested feature that we finally have room in the options menu to support. This new option allows for all files considered "log files" to be compressed into a zip file after dumping, deleting the uncompressed versions. This helps save on space and helps with submissions. This option currently defaults to disabled.
Both Aaru and DiscImageCreator currently support this, as they're the only ones that have log files and dumping support combined. This has been tested to ensure that all log files (including the dreaded new command file in DIC) are archived. Edit: As of one of the more recent commits, Check support has been added so compression can be applied after the fact. This also means that both CleanRip and UmdImageCreator both can have their logs compressed as well.
This also fixes another related issue where if users don't want to output the JSON, we shouldn't collect the artifact information. This can potentially lead to memory issues.
Fixes https://github.com/SabreTools/MPF/issues/22