SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 05:40:06 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[PR #300] [MERGED] MVVM Overhaul #997

New Issue
Closed
opened 2026-01-29 16:24:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:24:44 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/300
Author: @mnadareski
Created: 8/4/2021
Status: ✅ Merged
Merged: 8/4/2021
Merged by: @mnadareski

Base: master ← Head: mvvm

📝 Commits (10+)

  • 08ab56e Start migrating to MVVM
  • ab58450 Finish gutting LogOutput
  • 503910a Remove now-useless regions
  • 3b00731 Incremental initialization of the UI
  • e4b072c Add options directly to App-level
  • 037f274 Move options globally
  • 59e93c9 Accept -> OK
  • 1c22375 Add future work notes to App.xaml.cs
  • 82e0aee Add back cancel to DiscInformationWindow
  • 5adc435 Enable/Disable instead of Add/Remove

📊 Changes

26 files changed (+2990 additions, -2510 deletions)

View changed files

📝 MPF.Check/Program.cs (+1 -0)
📝 MPF.Library/Data/DumpEnvironment.cs (+5 -2)
📝 MPF.Library/Data/Options.cs (+9 -1)
📝 MPF.Library/Data/SubmissionInfo.cs (+169 -15)
📝 MPF.Library/Utilities/Validators.cs (+6 -0)
📝 MPF/App.xaml (+9 -5)
📝 MPF/App.xaml.cs (+49 -0)
➕ MPF/OptionsLoader.cs (+44 -0)
📝 MPF/UserControls/LogOutput.xaml (+4 -4)
📝 MPF/UserControls/LogOutput.xaml.cs (+5 -532)
📝 MPF/UserControls/UserInput.xaml (+16 -8)
📝 MPF/UserControls/UserInput.xaml.cs (+88 -9)
➖ MPF/ViewModels.cs (+0 -38)
➕ MPF/ViewModels/DiscInformationViewModel.cs (+283 -0)
➕ MPF/ViewModels/LogViewModel.cs (+577 -0)
➕ MPF/ViewModels/MainViewModel.cs (+1322 -0)
➕ MPF/ViewModels/OptionsViewModel.cs (+263 -0)
📝 MPF/Windows/DiscInformationWindow.xaml (+36 -36)
📝 MPF/Windows/DiscInformationWindow.xaml.cs (+7 -337)
📝 MPF/Windows/MainWindow.xaml (+18 -13)

...and 6 more files

📄 Description

This PR migrates the internals over to a pseudo-MVVM layout. The intent is to be able to more easily add and remove things in the future in terms of functionality.

This is currently not full MVVM because it does not use Commands internally, rather setting normal event handlers through the view models. This needs to be cleaned up in the future.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/300 **Author:** [@mnadareski](https://github.com/mnadareski) **Created:** 8/4/2021 **Status:** ✅ Merged **Merged:** 8/4/2021 **Merged by:** [@mnadareski](https://github.com/mnadareski) **Base:** `master` ← **Head:** `mvvm` --- ### 📝 Commits (10+) - [`08ab56e`](https://github.com/SabreTools/MPF/commit/08ab56ec9739bc38a6b6087e8fe4ee18f99e80cc) Start migrating to MVVM - [`ab58450`](https://github.com/SabreTools/MPF/commit/ab584504da81a136e7bf1e67e959b64ac3ac3b28) Finish gutting LogOutput - [`503910a`](https://github.com/SabreTools/MPF/commit/503910ad95726bbdc08fc801633ce43f31c49d19) Remove now-useless regions - [`3b00731`](https://github.com/SabreTools/MPF/commit/3b0073193776122f161d9c4ae56ea4ae9088e0f1) Incremental initialization of the UI - [`e4b072c`](https://github.com/SabreTools/MPF/commit/e4b072cb551f717e009bdce24c3634f5e5e7444b) Add options directly to App-level - [`037f274`](https://github.com/SabreTools/MPF/commit/037f2747b5166080ca9940c77a11890b39cfdcfd) Move options globally - [`59e93c9`](https://github.com/SabreTools/MPF/commit/59e93c910865e758866d5a7265834231990b0779) Accept -> OK - [`1c22375`](https://github.com/SabreTools/MPF/commit/1c2237561dc1ac54b2b3495b8fa2d302cdbf8a44) Add future work notes to App.xaml.cs - [`82e0aee`](https://github.com/SabreTools/MPF/commit/82e0aee476788ece9fa28a7a04ecd975720cba1c) Add back cancel to DiscInformationWindow - [`5adc435`](https://github.com/SabreTools/MPF/commit/5adc43539a5b1ef191dcbc3ad6c23f97b87c49c9) Enable/Disable instead of Add/Remove ### 📊 Changes **26 files changed** (+2990 additions, -2510 deletions) <details> <summary>View changed files</summary> 📝 `MPF.Check/Program.cs` (+1 -0) 📝 `MPF.Library/Data/DumpEnvironment.cs` (+5 -2) 📝 `MPF.Library/Data/Options.cs` (+9 -1) 📝 `MPF.Library/Data/SubmissionInfo.cs` (+169 -15) 📝 `MPF.Library/Utilities/Validators.cs` (+6 -0) 📝 `MPF/App.xaml` (+9 -5) 📝 `MPF/App.xaml.cs` (+49 -0) ➕ `MPF/OptionsLoader.cs` (+44 -0) 📝 `MPF/UserControls/LogOutput.xaml` (+4 -4) 📝 `MPF/UserControls/LogOutput.xaml.cs` (+5 -532) 📝 `MPF/UserControls/UserInput.xaml` (+16 -8) 📝 `MPF/UserControls/UserInput.xaml.cs` (+88 -9) ➖ `MPF/ViewModels.cs` (+0 -38) ➕ `MPF/ViewModels/DiscInformationViewModel.cs` (+283 -0) ➕ `MPF/ViewModels/LogViewModel.cs` (+577 -0) ➕ `MPF/ViewModels/MainViewModel.cs` (+1322 -0) ➕ `MPF/ViewModels/OptionsViewModel.cs` (+263 -0) 📝 `MPF/Windows/DiscInformationWindow.xaml` (+36 -36) 📝 `MPF/Windows/DiscInformationWindow.xaml.cs` (+7 -337) 📝 `MPF/Windows/MainWindow.xaml` (+18 -13) _...and 6 more files_ </details> ### 📄 Description This PR migrates the internals over to a pseudo-MVVM layout. The intent is to be able to more easily add and remove things in the future in terms of functionality. This is currently not full MVVM because it does not use Commands internally, rather setting normal event handlers through the view models. This needs to be cleaned up in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:24:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?