Allow 0-byte reads at the end of a byte array (#3)

* Allow 0-byte reads at the end of a byte array

ReadBytes(ref offset, 0) threw ArgumentOutOfRangeException when offset
was equal to the array length, before the 0-byte case was handled. The
same happened for a 0-byte read from an empty array, and TryReadBytes
with a count of 0 at the end threw instead of returning true. The offset
check now accepts the end of the array for a 0-byte read only; reads past
the end still throw.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Handle 0-byte reads before the offset check

Same order as the stream version of ReadExactlyToBuffer, applied to
both byte array copies (Numerics.Extensions and IO.Extensions).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
gmipf
2026-10-15 03:20:30 +02:00
committed by GitHub
parent 4235315f58
commit f6b6aa1e14
3 changed files with 42 additions and 8 deletions

View File

@@ -70,6 +70,31 @@ namespace SabreTools.Numerics.Extensions.Test
Assert.True(read.SequenceEqual(_bytes.Take(length)));
}
[Fact]
public void ReadBytesZeroLengthAtEndTest()
{
int offset = _bytes.Length;
byte[] read = _bytes.ReadBytes(ref offset, 0);
Assert.Empty(read);
Assert.Equal(_bytes.Length, offset);
}
[Fact]
public void ReadBytesZeroLengthEmptyArrayTest()
{
int offset = 0;
byte[] read = Array.Empty<byte>().ReadBytes(ref offset, 0);
Assert.Empty(read);
Assert.Equal(0, offset);
}
[Fact]
public void ReadBytesPastEndTest()
{
int offset = _bytes.Length;
Assert.Throws<ArgumentOutOfRangeException>(() => _bytes.ReadBytes(ref offset, 1));
}
[Fact]
public void ReadSByteTest()
{
@@ -1443,6 +1468,15 @@ namespace SabreTools.Numerics.Extensions.Test
Assert.Empty(read);
}
[Fact]
public void TryReadBytesZeroLengthAtEndTest()
{
int offset = _bytes.Length;
bool actual = _bytes.TryReadBytes(ref offset, 0, out byte[] read);
Assert.True(actual);
Assert.Empty(read);
}
[Fact]
public void TryReadSByteTest()
{