Remove LayoutKind.Sequential

This may be replaced in the future when byte-serialzable types are more well-defined
2026-08-01 05:28:44 +00:00 · 2023-09-10 21:33:22 -04:00
parent 670b8428c2
commit 41a90278d5
71 changed files with 74 additions and 290 deletions
--- a/LinearExecutable/DebugInformation.cs
+++ b/LinearExecutable/DebugInformation.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The debug information is defined by the debugger and is not controlled by
@@ -13,7 +11,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class DebugInformation
    {
        /// <summary>
--- a/LinearExecutable/EntryTableBundle.cs
+++ b/LinearExecutable/EntryTableBundle.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The entry table contains object and offset information that is used to resolve
@@ -17,7 +15,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class EntryTableBundle
    {
        /// <summary>
--- a/LinearExecutable/FixupPageTableEntry.cs
+++ b/LinearExecutable/FixupPageTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The Fixup Page Table provides a simple mapping of a logical page number
@@ -17,7 +15,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class FixupPageTableEntry
    {
        /// <summary>
--- a/LinearExecutable/ImportModuleNameTableEntry.cs
+++ b/LinearExecutable/ImportModuleNameTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The import module name table defines the module name strings imported through
@@ -17,7 +15,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ImportModuleNameTableEntry
    {
        /// <summary>
--- a/LinearExecutable/ImportProcedureNameTableEntry.cs
+++ b/LinearExecutable/ImportProcedureNameTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The import procedure name table defines the procedure name strings imported
@@ -20,7 +18,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ImportModuleProcedureNameTableEntry
    {
        /// <summary>
--- a/LinearExecutable/InformationBlock.cs
+++ b/LinearExecutable/InformationBlock.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The `information block` in the LE header contains the linker version number,
@@ -12,7 +10,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class InformationBlock
    {
        /// <summary>
--- a/LinearExecutable/ModuleFormatDirectivesTableEntry.cs
+++ b/LinearExecutable/ModuleFormatDirectivesTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The Module Format Directives Table is an optional table that allows additional
@@ -15,7 +13,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ModuleFormatDirectivesTableEntry
    {
        /// <summary>
--- a/LinearExecutable/NonResidentNamesTableEntry.cs
+++ b/LinearExecutable/NonResidentNamesTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The resident and non-resident name tables define the ASCII names and ordinal
@@ -27,7 +25,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class NonResidentNamesTableEntry
    {
        /// <summary>
--- a/LinearExecutable/ObjectPageMapEntry.cs
+++ b/LinearExecutable/ObjectPageMapEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The Object page table provides information about a logical page in an object.
@@ -15,7 +13,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ObjectPageMapEntry
    {
        /// <summary>
--- a/LinearExecutable/ObjectTableEntry.cs
+++ b/LinearExecutable/ObjectTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The object table contains information that describes each segment in
@@ -14,7 +12,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </remarks>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ObjectTableEntry
    {
        /// <summary>
--- a/LinearExecutable/PerPageChecksumTableEntry.cs
+++ b/LinearExecutable/PerPageChecksumTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The Per-Page Checksum table provides space for a cryptographic checksum for
@@ -13,7 +11,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class PerPageChecksumTableEntry
    {
        /// <summary>
--- a/LinearExecutable/ResidentNamesTableEntry.cs
+++ b/LinearExecutable/ResidentNamesTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The resident and non-resident name tables define the ASCII names and ordinal
@@ -27,7 +25,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ResidentNamesTableEntry
    {
        /// <summary>
--- a/LinearExecutable/ResourceTableEntry.cs
+++ b/LinearExecutable/ResourceTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The resource table is an array of resource table entries. Each resource table
@@ -15,7 +13,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class ResourceTableEntry
    {
        /// <summary>
--- a/LinearExecutable/VerifyRecordDirectiveTableEntry.cs
+++ b/LinearExecutable/VerifyRecordDirectiveTableEntry.cs
@@ -1,6 +1,4 @@
-using System.Runtime.InteropServices;
-
-namespace SabreTools.Models.LinearExecutable
+namespace SabreTools.Models.LinearExecutable
 {
    /// <summary>
    /// The Verify Record Directive Table is an optional table. It maintains a record
@@ -11,7 +9,6 @@ namespace SabreTools.Models.LinearExecutable
    /// </summary>
    /// <see href="https://faydoc.tripod.com/formats/exe-LE.htm"/>
    /// <see href="http://www.edm2.com/index.php/LX_-_Linear_eXecutable_Module_Format_Description"/>
-    [StructLayout(LayoutKind.Sequential)]
    public sealed class VerifyRecordDirectiveTableEntry
    {
        /// <summary>