From eeac28e7589b485c171b22288d60dc564a231cdd Mon Sep 17 00:00:00 2001
From: Matt Nadareski <mnadareski@outlook.com>
Date: Mon, 2 Mar 2026 00:33:20 -0500
Subject: [PATCH] Start filling in URL builder tests

---
 .../Web/UrlBuilderTests.cs                    | 43 +++++++++++++++----
 SabreTools.RedumpLib/Web/UrlBuilder.cs        |  4 +-
 2 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/SabreTools.RedumpLib.Test/Web/UrlBuilderTests.cs b/SabreTools.RedumpLib.Test/Web/UrlBuilderTests.cs
index 451638c..54d51fa 100644
--- a/SabreTools.RedumpLib.Test/Web/UrlBuilderTests.cs
+++ b/SabreTools.RedumpLib.Test/Web/UrlBuilderTests.cs
@@ -1,7 +1,3 @@
-using System;
-using System.Collections.Generic;
-using System.Data;
-using System.Linq;
 using SabreTools.RedumpLib.Web;
 using Xunit;
 
@@ -11,6 +7,15 @@ namespace SabreTools.RedumpLib.Test.Web
     {
         #region BuildDiscUrl
 
+        [Theory]
+        [InlineData(1, 1)]
+        [InlineData(-1, 1)]
+        public void BuildDiscUrl_AlwaysPositive(int id, int expected)
+        {
+            string actual = UrlBuilder.BuildDiscUrl(id);
+            Assert.Equal($"http://redump.org/disc/{expected}/", actual);
+        }
+
         // TODO: Implement
 
         #endregion
@@ -23,13 +28,23 @@ namespace SabreTools.RedumpLib.Test.Web
 
         #region BuildDiscsWipUrl
 
-        // TODO: Implement
+        [Fact]
+        public void BuildDiscsWipUrl_Constant()
+        {
+            string actual = UrlBuilder.BuildDiscsWipUrl();
+            Assert.Equal("http://redump.org/discs-wip/", actual);
+        }
 
         #endregion
 
         #region BuildDownloadsUrl
 
-        // TODO: Implement
+        [Fact]
+        public void BuildDownloadsUrl_Constant()
+        {
+            string actual = UrlBuilder.BuildDownloadsUrl();
+            Assert.Equal("http://redump.org/downloads/", actual);
+        }
 
         #endregion
 
@@ -41,13 +56,25 @@ namespace SabreTools.RedumpLib.Test.Web
 
         #region BuildMemberPromotionUrl
 
-        // TODO: Implement
+        [Fact]
+        public void BuildMemberPromotionUrl_Constant()
+        {
+            string actual = UrlBuilder.BuildMemberPromotionUrl();
+            Assert.Equal("http://redump.org/member2dumper/", actual);
+        }
 
         #endregion
 
         #region BuildNewDiscUrl
 
-        // TODO: Implement
+        [Theory]
+        [InlineData(1, 1)]
+        [InlineData(-1, 1)]
+        public void BuildNewDiscUrl_AlwaysPositive(int id, int expected)
+        {
+            string actual = UrlBuilder.BuildNewDiscUrl(id);
+            Assert.Equal($"http://redump.org/newdisc/{expected}/", actual);
+        }
 
         #endregion
 
diff --git a/SabreTools.RedumpLib/Web/UrlBuilder.cs b/SabreTools.RedumpLib/Web/UrlBuilder.cs
index a40d0cb..8fba43f 100644
--- a/SabreTools.RedumpLib/Web/UrlBuilder.cs
+++ b/SabreTools.RedumpLib/Web/UrlBuilder.cs
@@ -181,7 +181,7 @@ namespace SabreTools.RedumpLib.Web
             var sb = new StringBuilder();
 
             sb.Append(SiteBaseUrl);
-            sb.AppendFormat(DiscPath, +id);
+            sb.AppendFormat(DiscPath, Math.Abs(id));
 
             if (changes)
                 sb.Append(DiscPathChangesSubpath);
@@ -498,7 +498,7 @@ namespace SabreTools.RedumpLib.Web
             var sb = new StringBuilder();
 
             sb.Append(SiteBaseUrl);
-            sb.AppendFormat(NewDiscPath, +id);
+            sb.AppendFormat(NewDiscPath, Math.Abs(id));
 
             return sb.ToString();
         }