From 0458489a4fb74ff72b1ea5f31aeed8976dbcd3f2 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Sat, 4 Apr 2026 13:13:16 -0400 Subject: [PATCH] Remove two places where DeepClone wasn't needed --- SabreTools.Metadata.DatItems.Test/DatItemTests.cs | 2 +- SabreTools.Metadata.DatItems/Machine.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/SabreTools.Metadata.DatItems.Test/DatItemTests.cs b/SabreTools.Metadata.DatItems.Test/DatItemTests.cs index 32028d39..fc9a82f0 100644 --- a/SabreTools.Metadata.DatItems.Test/DatItemTests.cs +++ b/SabreTools.Metadata.DatItems.Test/DatItemTests.cs @@ -32,7 +32,7 @@ namespace SabreTools.Metadata.DatItems.Test /// public override object Clone() => new TestDatItem() { - _internal = _internal.DeepClone() as TestDatItemModel ?? [] + _internal = GetInternalClone(), }; /// diff --git a/SabreTools.Metadata.DatItems/Machine.cs b/SabreTools.Metadata.DatItems/Machine.cs index f772c721..eb5f7301 100644 --- a/SabreTools.Metadata.DatItems/Machine.cs +++ b/SabreTools.Metadata.DatItems/Machine.cs @@ -364,14 +364,14 @@ namespace SabreTools.Metadata.DatItems { return new Machine() { - _internal = _internal.DeepClone() as Data.Models.Metadata.Machine ?? [], + _internal = GetInternalClone(), }; } /// /// Get a clone of the current internal model /// - public Data.Models.Metadata.Machine GetInternalClone() => (_internal.DeepClone() as Data.Models.Metadata.Machine)!; + public Data.Models.Metadata.Machine GetInternalClone() => (_internal.DeepClone() as Data.Models.Metadata.Machine) ?? []; #endregion