SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-21 14:25:03 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Check for "null" literal string cases

Browse Source
This commit is contained in:
Matt Nadareski
2026-09-18 11:01:40 -04:00
parent 2cacaac9fd
commit 0b6af978ff
4 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
SabreTools.Metadata.DatFiles/DatFile.cs
View File

@@ -685,11 +685,11 @@ namespace SabreTools.Metadata.DatFiles
return rom;
// If the item has a SHA-1 but no size
if (rom.Size is null && rom.SHA1 is not null)
if (rom.Size is null && rom.SHA1 is not null && rom.SHA1 != "null")
return rom;
// If the item has a SHA-256 but no size
if (rom.Size is null && rom.SHA256 is not null)
if (rom.Size is null && rom.SHA256 is not null && rom.SHA256 != "null")
return rom;
// If the Rom has "null" characteristics, ensure all fields

4
SabreTools.Metadata.DatFiles/Formats/ClrMamePro.cs
View File

@@ -88,7 +88,9 @@ namespace SabreTools.Metadata.DatFiles.Formats
case Rom rom:
if (string.IsNullOrEmpty(rom.Name))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Name));
if ((rom.Size is null || rom.Size < 0) && rom.SHA1 is null && rom.SHA256 is null)
if ((rom.Size is null || rom.Size < 0)
&& (rom.SHA1 is null || rom.SHA1 == "null")
&& (rom.SHA256 is null || rom.SHA1 == "null"))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Size));
if (string.IsNullOrEmpty(rom.BLAKE3)
&& string.IsNullOrEmpty(rom.CRC16)

4
SabreTools.Metadata.DatFiles/Formats/Logiqx.cs
View File

@@ -282,7 +282,9 @@ namespace SabreTools.Metadata.DatFiles.Formats
case Rom rom:
if (string.IsNullOrEmpty(rom.Name))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Name));
if ((rom.Size is null || rom.Size < 0) && rom.SHA1 is null && rom.SHA256 is null)
if ((rom.Size is null || rom.Size < 0)
&& (rom.SHA1 is null || rom.SHA1 == "null")
&& (rom.SHA256 is null || rom.SHA1 == "null"))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Size));
if (string.IsNullOrEmpty(rom.BLAKE3)
&& string.IsNullOrEmpty(rom.CRC16)

4
SabreTools.Metadata.DatFiles/Formats/SeparatedValue.cs
View File

@@ -93,7 +93,9 @@ namespace SabreTools.Metadata.DatFiles.Formats
case Rom rom:
if (string.IsNullOrEmpty(rom.Name))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Name));
if ((rom.Size is null || rom.Size < 0) && rom.SHA1 is null && rom.SHA256 is null)
if ((rom.Size is null || rom.Size < 0)
&& (rom.SHA1 is null || rom.SHA1 == "null")
&& (rom.SHA256 is null || rom.SHA1 == "null"))
missingFields.Add(nameof(Data.Models.Metadata.Rom.Size));
if (string.IsNullOrEmpty(rom.CRC32)
&& string.IsNullOrEmpty(rom.MD5)