Rename Clone extension to DeepClone to avoid conflicts

This commit is contained in:
Matt Nadareski
2026-04-02 15:32:24 -04:00
parent 12ec3678b8
commit 11c4097cba
47 changed files with 51 additions and 51 deletions

View File

@@ -45,7 +45,7 @@ namespace SabreTools.Metadata.DatItems
/// <summary>
/// Get a clone of the current internal model
/// </summary>
public virtual T GetInternalClone() => (_internal.Clone() as T)!;
public virtual T GetInternalClone() => (_internal.DeepClone() as T)!;
#endregion

View File

@@ -59,7 +59,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Adjuster(_internal.Clone() as Data.Models.Metadata.Adjuster ?? []);
public override object Clone() => new Adjuster(_internal.DeepClone() as Data.Models.Metadata.Adjuster ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Adjuster GetInternalClone()

View File

@@ -37,7 +37,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Analog(_internal.Clone() as Data.Models.Metadata.Analog ?? []);
public override object Clone() => new Analog(_internal.DeepClone() as Data.Models.Metadata.Analog ?? []);
#endregion
}

View File

@@ -37,7 +37,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Archive(_internal.Clone() as Data.Models.Metadata.Archive ?? []);
public override object Clone() => new Archive(_internal.DeepClone() as Data.Models.Metadata.Archive ?? []);
#endregion
}

View File

@@ -49,7 +49,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new BiosSet(_internal.Clone() as Data.Models.Metadata.BiosSet ?? []);
public override object Clone() => new BiosSet(_internal.DeepClone() as Data.Models.Metadata.BiosSet ?? []);
#endregion
}

View File

@@ -27,7 +27,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Blank(_internal.Clone() as Data.Models.Metadata.Blank ?? []);
public override object Clone() => new Blank(_internal.DeepClone() as Data.Models.Metadata.Blank ?? []);
#endregion
}

View File

@@ -55,7 +55,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Chip(_internal.Clone() as Data.Models.Metadata.Chip ?? []);
public override object Clone() => new Chip(_internal.DeepClone() as Data.Models.Metadata.Chip ?? []);
#endregion
}

View File

@@ -55,7 +55,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Condition(_internal.Clone() as Data.Models.Metadata.Condition ?? []);
public override object Clone() => new Condition(_internal.DeepClone() as Data.Models.Metadata.Condition ?? []);
#endregion
}

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new ConfLocation(_internal.Clone() as Data.Models.Metadata.ConfLocation ?? []);
public override object Clone() => new ConfLocation(_internal.DeepClone() as Data.Models.Metadata.ConfLocation ?? []);
#endregion
}

View File

@@ -65,7 +65,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new ConfSetting(_internal.Clone() as Data.Models.Metadata.ConfSetting ?? []);
public override object Clone() => new ConfSetting(_internal.DeepClone() as Data.Models.Metadata.ConfSetting ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.ConfSetting GetInternalClone()

View File

@@ -100,7 +100,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Configuration(_internal.Clone() as Data.Models.Metadata.Configuration ?? []);
public override object Clone() => new Configuration(_internal.DeepClone() as Data.Models.Metadata.Configuration ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Configuration GetInternalClone()

View File

@@ -73,7 +73,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Control(_internal.Clone() as Data.Models.Metadata.Control ?? []);
public override object Clone() => new Control(_internal.DeepClone() as Data.Models.Metadata.Control ?? []);
#endregion
}

View File

@@ -54,7 +54,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DataArea(_internal.Clone() as Data.Models.Metadata.DataArea ?? []);
public override object Clone() => new DataArea(_internal.DeepClone() as Data.Models.Metadata.DataArea ?? []);
#endregion
}

View File

@@ -95,7 +95,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Device(_internal.Clone() as Data.Models.Metadata.Device ?? []);
public override object Clone() => new Device(_internal.DeepClone() as Data.Models.Metadata.Device ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Device GetInternalClone()

View File

@@ -37,7 +37,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DeviceRef(_internal.Clone() as Data.Models.Metadata.DeviceRef ?? []);
public override object Clone() => new DeviceRef(_internal.DeepClone() as Data.Models.Metadata.DeviceRef ?? []);
#endregion
}

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DipLocation(_internal.Clone() as Data.Models.Metadata.DipLocation ?? []);
public override object Clone() => new DipLocation(_internal.DeepClone() as Data.Models.Metadata.DipLocation ?? []);
#endregion
}

View File

@@ -128,7 +128,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DipSwitch(_internal.Clone() as Data.Models.Metadata.DipSwitch ?? []);
public override object Clone() => new DipSwitch(_internal.DeepClone() as Data.Models.Metadata.DipSwitch ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.DipSwitch GetInternalClone()

View File

@@ -65,7 +65,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DipValue(_internal.Clone() as Data.Models.Metadata.DipValue ?? []);
public override object Clone() => new DipValue(_internal.DeepClone() as Data.Models.Metadata.DipValue ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.DipValue GetInternalClone()

View File

@@ -109,7 +109,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Disk(_internal.Clone() as Data.Models.Metadata.Disk ?? []);
public override object Clone() => new Disk(_internal.DeepClone() as Data.Models.Metadata.Disk ?? []);
/// <summary>
/// Convert a disk to the closest Rom approximation

View File

@@ -38,7 +38,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new DiskArea(_internal.Clone() as Data.Models.Metadata.DiskArea ?? []);
public override object Clone() => new DiskArea(_internal.DeepClone() as Data.Models.Metadata.DiskArea ?? []);
#endregion
}

View File

@@ -147,7 +147,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Display(_internal.Clone() as Data.Models.Metadata.Display ?? []);
public override object Clone() => new Display(_internal.DeepClone() as Data.Models.Metadata.Display ?? []);
#endregion
}

View File

@@ -103,7 +103,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Driver(_internal.Clone() as Data.Models.Metadata.Driver ?? []);
public override object Clone() => new Driver(_internal.DeepClone() as Data.Models.Metadata.Driver ?? []);
#endregion
}

View File

@@ -37,7 +37,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Extension(_internal.Clone() as Data.Models.Metadata.Extension ?? []);
public override object Clone() => new Extension(_internal.DeepClone() as Data.Models.Metadata.Extension ?? []);
#endregion
}

View File

@@ -61,7 +61,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Feature(_internal.Clone() as Data.Models.Metadata.Feature ?? []);
public override object Clone() => new Feature(_internal.DeepClone() as Data.Models.Metadata.Feature ?? []);
#endregion
}

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Info(_internal.Clone() as Data.Models.Metadata.Info ?? []);
public override object Clone() => new Info(_internal.DeepClone() as Data.Models.Metadata.Info ?? []);
#endregion
}

View File

@@ -76,7 +76,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Input(_internal.Clone() as Data.Models.Metadata.Input ?? []);
public override object Clone() => new Input(_internal.DeepClone() as Data.Models.Metadata.Input ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Input GetInternalClone()

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Instance(_internal.Clone() as Data.Models.Metadata.Instance ?? []);
public override object Clone() => new Instance(_internal.DeepClone() as Data.Models.Metadata.Instance ?? []);
#endregion
}

View File

@@ -57,7 +57,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Media(_internal.Clone() as Data.Models.Metadata.Media ?? []);
public override object Clone() => new Media(_internal.DeepClone() as Data.Models.Metadata.Media ?? []);
/// <summary>
/// Convert a media to the closest Rom approximation

View File

@@ -54,7 +54,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Part(_internal.Clone() as Data.Models.Metadata.Part ?? []);
public override object Clone() => new Part(_internal.DeepClone() as Data.Models.Metadata.Part ?? []);
#endregion
}

View File

@@ -74,7 +74,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new PartFeature(_internal.Clone() as Data.Models.Metadata.Feature ?? []);
public override object Clone() => new PartFeature(_internal.DeepClone() as Data.Models.Metadata.Feature ?? []);
#endregion
}

View File

@@ -57,7 +57,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Port(_internal.Clone() as Data.Models.Metadata.Port ?? []);
public override object Clone() => new Port(_internal.DeepClone() as Data.Models.Metadata.Port ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Port GetInternalClone()

View File

@@ -49,7 +49,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new RamOption(_internal.Clone() as Data.Models.Metadata.RamOption ?? []);
public override object Clone() => new RamOption(_internal.DeepClone() as Data.Models.Metadata.RamOption ?? []);
#endregion
}

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Release(_internal.Clone() as Data.Models.Metadata.Release ?? []);
public override object Clone() => new Release(_internal.DeepClone() as Data.Models.Metadata.Release ?? []);
#endregion
}

View File

@@ -26,7 +26,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new ReleaseDetails(_internal.Clone() as Data.Models.Metadata.ReleaseDetails ?? []);
public override object Clone() => new ReleaseDetails(_internal.DeepClone() as Data.Models.Metadata.ReleaseDetails ?? []);
#endregion
}

View File

@@ -397,7 +397,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Rom(_internal.Clone() as Data.Models.Metadata.Rom ?? []);
public override object Clone() => new Rom(_internal.DeepClone() as Data.Models.Metadata.Rom ?? []);
#endregion

View File

@@ -37,7 +37,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Sample(_internal.Clone() as Data.Models.Metadata.Sample ?? []);
public override object Clone() => new Sample(_internal.DeepClone() as Data.Models.Metadata.Sample ?? []);
#endregion
}

View File

@@ -27,7 +27,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Serials(_internal.Clone() as Data.Models.Metadata.Serials ?? []);
public override object Clone() => new Serials(_internal.DeepClone() as Data.Models.Metadata.Serials ?? []);
#endregion
}

View File

@@ -43,7 +43,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new SharedFeat(_internal.Clone() as Data.Models.Metadata.SharedFeat ?? []);
public override object Clone() => new SharedFeat(_internal.DeepClone() as Data.Models.Metadata.SharedFeat ?? []);
#endregion
}

View File

@@ -57,7 +57,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Slot(_internal.Clone() as Data.Models.Metadata.Slot ?? []);
public override object Clone() => new Slot(_internal.DeepClone() as Data.Models.Metadata.Slot ?? []);
/// <inheritdoc/>
public override Data.Models.Metadata.Slot GetInternalClone()

View File

@@ -49,7 +49,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new SlotOption(_internal.Clone() as Data.Models.Metadata.SlotOption ?? []);
public override object Clone() => new SlotOption(_internal.DeepClone() as Data.Models.Metadata.SlotOption ?? []);
#endregion
}

View File

@@ -59,7 +59,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new SoftwareList(_internal.Clone() as Data.Models.Metadata.SoftwareList ?? []);
public override object Clone() => new SoftwareList(_internal.DeepClone() as Data.Models.Metadata.SoftwareList ?? []);
#endregion
}

View File

@@ -33,7 +33,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new Sound(_internal.Clone() as Data.Models.Metadata.Sound ?? []);
public override object Clone() => new Sound(_internal.DeepClone() as Data.Models.Metadata.Sound ?? []);
#endregion
}

View File

@@ -27,7 +27,7 @@ namespace SabreTools.Metadata.DatItems.Formats
#region Cloning Methods
/// <inheritdoc/>
public override object Clone() => new SourceDetails(_internal.Clone() as Data.Models.Metadata.SourceDetails ?? []);
public override object Clone() => new SourceDetails(_internal.DeepClone() as Data.Models.Metadata.SourceDetails ?? []);
#endregion
}

View File

@@ -68,7 +68,7 @@ namespace SabreTools.Metadata.DatItems
public Machine(Data.Models.Metadata.Machine machine)
{
_internal = machine.Clone() as Data.Models.Metadata.Machine ?? [];
_internal = machine.DeepClone() as Data.Models.Metadata.Machine ?? [];
// Remove all inverted fields
Remove(Data.Models.Metadata.Machine.AdjusterKey);
@@ -143,14 +143,14 @@ namespace SabreTools.Metadata.DatItems
{
return new Machine()
{
_internal = _internal.Clone() as Data.Models.Metadata.Machine ?? [],
_internal = _internal.DeepClone() as Data.Models.Metadata.Machine ?? [],
};
}
/// <summary>
/// Get a clone of the current internal model
/// </summary>
public Data.Models.Metadata.Machine GetInternalClone() => (_internal.Clone() as Data.Models.Metadata.Machine)!;
public Data.Models.Metadata.Machine GetInternalClone() => (_internal.DeepClone() as Data.Models.Metadata.Machine)!;
#endregion