From 2152ba43a8c63f1a0b147d64dd0a82fedee8f999 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Wed, 27 Nov 2024 22:07:48 -0500 Subject: [PATCH] Minor formatting changes in extensions --- .../Extensions.NewExecutable.cs | 8 ++------ .../Extensions.PortableExecutable.cs | 16 ++++------------ 2 files changed, 6 insertions(+), 18 deletions(-) diff --git a/SabreTools.Serialization/Extensions.NewExecutable.cs b/SabreTools.Serialization/Extensions.NewExecutable.cs index a5511100..f72afac1 100644 --- a/SabreTools.Serialization/Extensions.NewExecutable.cs +++ b/SabreTools.Serialization/Extensions.NewExecutable.cs @@ -10,9 +10,7 @@ namespace SabreTools.Serialization /// Resource type information entry to check /// True if the entry is an integer type, false if an offset, null on error public static bool IsIntegerType(this ResourceTypeInformationEntry entry) - { - return (entry.TypeID & 0x8000) != 0; - } + => (entry.TypeID & 0x8000) != 0; /// /// Determine if a resource type resource entry is an integer or offset @@ -20,9 +18,7 @@ namespace SabreTools.Serialization /// Resource type resource entry to check /// True if the entry is an integer type, false if an offset, null on error public static bool IsIntegerType(this ResourceTypeResourceEntry entry) - { - return (entry.ResourceID & 0x8000) != 0; - } + => (entry.ResourceID & 0x8000) != 0; /// /// Get the segment entry type for an entry table bundle diff --git a/SabreTools.Serialization/Extensions.PortableExecutable.cs b/SabreTools.Serialization/Extensions.PortableExecutable.cs index 4f492783..eb99a499 100644 --- a/SabreTools.Serialization/Extensions.PortableExecutable.cs +++ b/SabreTools.Serialization/Extensions.PortableExecutable.cs @@ -102,10 +102,7 @@ namespace SabreTools.Serialization public static NB10ProgramDatabase? AsNB10ProgramDatabase(this byte[] data, ref int offset) { var nb10ProgramDatabase = data.ReadType(ref offset); - - if (nb10ProgramDatabase == null) - return null; - if (nb10ProgramDatabase.Signature != 0x3031424E) + if (nb10ProgramDatabase?.Signature != 0x3031424E) return null; return nb10ProgramDatabase; @@ -120,10 +117,7 @@ namespace SabreTools.Serialization public static RSDSProgramDatabase? AsRSDSProgramDatabase(this byte[] data, ref int offset) { var rsdsProgramDatabase = data.ReadType(ref offset); - - if (rsdsProgramDatabase == null) - return null; - if (rsdsProgramDatabase.Signature != 0x53445352) + if (rsdsProgramDatabase?.Signature != 0x53445352) return null; #if NET20 || NET35 || NET40 || NET452 || NET462 @@ -211,6 +205,7 @@ namespace SabreTools.Serialization // Read in the table var header = new ResourceHeader(); + header.DataSize = data.ReadUInt32(ref offset); header.HeaderSize = data.ReadUInt32(ref offset); header.ResourceType = (ResourceType)data.ReadUInt32(ref offset); // TODO: Could be a string too @@ -1127,10 +1122,7 @@ namespace SabreTools.Serialization if (versionInfo.ValueLength > 0 && offset + versionInfo.ValueLength <= entry.Data.Length) { var fixedFileInfo = entry.Data.ReadType(ref offset); - - if (fixedFileInfo == null) - return null; - if (fixedFileInfo.Signature != 0xFEEF04BD) + if (fixedFileInfo?.Signature != 0xFEEF04BD) return null; versionInfo.Value = fixedFileInfo;