From 368c8b0533d27a6d6e87a23efe74e3f2f371aadf Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Tue, 9 Sep 2025 09:37:03 -0400 Subject: [PATCH] Add section table note --- .../Deserializers/PortableExecutable.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SabreTools.Serialization/Deserializers/PortableExecutable.cs b/SabreTools.Serialization/Deserializers/PortableExecutable.cs index 05b72a5e..0a6b0199 100644 --- a/SabreTools.Serialization/Deserializers/PortableExecutable.cs +++ b/SabreTools.Serialization/Deserializers/PortableExecutable.cs @@ -86,6 +86,13 @@ namespace SabreTools.Serialization.Deserializers #region Section Table + // TODO: Technically this needs to be seeked to + // It should be found by taking the the position after the + // signature and COFF file header and then adding the size + // of the optional header. This is effectively what the code + // is already doing since it is parsed after the optional + // header and not guessing otherwise. + // Set the section table executable.SectionTable = new SectionHeader[coffFileHeader.NumberOfSections]; for (int i = 0; i < coffFileHeader.NumberOfSections; i++)