SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-23 15:24:56 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Make inverted DataArea less impactful

Browse Source
This commit is contained in:
Matt Nadareski
2026-04-09 23:56:36 -04:00
parent 5f9eaef9f2
commit 3d33f44eca
12 changed files with 58 additions and 317 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
SabreTools.Metadata.DatFiles.Test/DatFileTests.FromMetadata.cs
View File

@@ -141,10 +141,12 @@ namespace SabreTools.Metadata.DatFiles.Test
ValidatePartFeature(partFeature);
// All other fields are tested separately
Rom? partRom = Array.Find(datItems, item => item is Rom rom && rom.DataAreaSpecified && rom.PartInterface is not null) as Rom;
Rom? partRom = Array.Find(datItems, item => item is Rom rom && rom.DataAreaName is not null && rom.PartInterface is not null) as Rom;
Assert.NotNull(partRom);
DataArea? romDataArea = partRom.DataArea;
ValidateDataArea(romDataArea);
Assert.Equal(Data.Models.Metadata.Endianness.Big, partRom.DataAreaEndianness);
Assert.Equal("name", partRom.DataAreaName);
Assert.Equal(12345, partRom.DataAreaSize);
Assert.Equal(Data.Models.Metadata.Width.Long, partRom.DataAreaWidth);
Assert.Equal("interface", partRom.PartInterface);
Assert.Equal("name", partRom.PartName);
@@ -157,7 +159,7 @@ namespace SabreTools.Metadata.DatFiles.Test
Release? release = Array.Find(datItems, item => item is Release) as Release;
ValidateRelease(release);
Rom? rom = Array.Find(datItems, item => item is Rom rom && !rom.DataAreaSpecified && rom.PartInterface is null && rom.OpenMSXMediaType is null) as Rom;
Rom? rom = Array.Find(datItems, item => item is Rom rom && rom.DataAreaName is null && rom.PartInterface is null && rom.OpenMSXMediaType is null) as Rom;
ValidateRom(rom);
Sample? sample = Array.Find(datItems, item => item is Sample) as Sample;
@@ -1205,15 +1207,6 @@ namespace SabreTools.Metadata.DatFiles.Test
Assert.Equal("ways3", control.Ways3);
}
private static void ValidateDataArea(DataArea? dataArea)
{
Assert.NotNull(dataArea);
Assert.Equal(Data.Models.Metadata.Endianness.Big, dataArea.Endianness);
Assert.Equal("name", dataArea.Name);
Assert.Equal(12345, dataArea.Size);
Assert.Equal(Data.Models.Metadata.Width.Long, dataArea.Width);
}
private static void ValidateDevice(Device? device)
{
Assert.NotNull(device);
@@ -1299,12 +1292,6 @@ namespace SabreTools.Metadata.DatFiles.Test
Assert.True(disk.Writable);
}
private static void ValidateDiskArea(DiskArea? diskArea)
{
Assert.NotNull(diskArea);
Assert.Equal("name", diskArea.Name);
}
private static void ValidateDisplay(Display? display)
{
Assert.NotNull(display);

12
SabreTools.Metadata.DatFiles.Test/DatFileTests.ToMetadata.cs
View File

@@ -152,13 +152,6 @@ namespace SabreTools.Metadata.DatFiles.Test
return item;
}
private static DataArea CreateDataArea(Machine machine)
{
DataArea item = new DataArea(CreateMetadataDataArea());
item.CopyMachineInformation(machine);
return item;
}
private static DeviceRef CreateDeviceRef(Machine machine)
{
DeviceRef item = new DeviceRef(CreateMetadataDeviceRef());
@@ -283,7 +276,10 @@ namespace SabreTools.Metadata.DatFiles.Test
{
Rom item = new Rom(CreateMetadataRom());
item.CopyMachineInformation(machine);
item.DataArea = CreateDataArea(machine);
item.DataAreaEndianness = Data.Models.Metadata.Endianness.Big;
item.DataAreaName = "name";
item.DataAreaSize = 12345;
item.DataAreaWidth = Data.Models.Metadata.Width.Long;
item.PartInterface = "interface";
item.PartName = "name";
return item;