Reduce generic DictionaryBase use

This commit is contained in:
Matt Nadareski
2026-04-04 13:31:12 -04:00
parent 0458489a4f
commit 4acd2d9fd6
5 changed files with 207 additions and 310 deletions

View File

@@ -151,7 +151,7 @@ namespace SabreTools.Metadata.DatItems.Formats
/// <returns></returns>
public Rom ConvertToRom()
{
var rom = new Rom(_internal.ConvertToRom()!);
var rom = new Rom((_internal as Data.Models.Metadata.Disk).ConvertToRom()!);
// Create a DataArea if there was an existing DiskArea
if (DiskArea is not null)
@@ -178,19 +178,19 @@ namespace SabreTools.Metadata.DatItems.Formats
/// </summary>
/// <param name="other">Disk to fill information from</param>
public void FillMissingInformation(Disk other)
=> _internal.FillMissingHashes(other._internal);
=> (_internal as Data.Models.Metadata.Disk).FillMissingHashes(other._internal as Data.Models.Metadata.Disk);
/// <summary>
/// Returns if the Rom contains any hashes
/// </summary>
/// <returns>True if any hash exists, false otherwise</returns>
public bool HasHashes() => _internal.HasHashes();
public bool HasHashes() => (_internal as Data.Models.Metadata.Disk)?.HasHashes() ?? false;
/// <summary>
/// Returns if all of the hashes are set to their 0-byte values
/// </summary>
/// <returns>True if any hash matches the 0-byte value, false otherwise</returns>
public bool HasZeroHash() => _internal.HasZeroHash();
public bool HasZeroHash() => (_internal as Data.Models.Metadata.Disk)?.HasZeroHash() ?? false;
#endregion

View File

@@ -104,7 +104,7 @@ namespace SabreTools.Metadata.DatItems.Formats
/// <returns></returns>
public Rom ConvertToRom()
{
var rom = new Rom(_internal.ConvertToRom()!);
var rom = new Rom((_internal as Data.Models.Metadata.Media).ConvertToRom()!);
rom.DupeType = DupeType;
rom.Machine = Machine?.Clone() as Machine;
@@ -123,19 +123,19 @@ namespace SabreTools.Metadata.DatItems.Formats
/// </summary>
/// <param name="other">Media to fill information from</param>
public void FillMissingInformation(Media other)
=> _internal.FillMissingHashes(other._internal);
=> (_internal as Data.Models.Metadata.Media).FillMissingHashes(other._internal as Data.Models.Metadata.Media);
/// <summary>
/// Returns if the Rom contains any hashes
/// </summary>
/// <returns>True if any hash exists, false otherwise</returns>
public bool HasHashes() => _internal.HasHashes();
public bool HasHashes() => (_internal as Data.Models.Metadata.Media)?.HasHashes() ?? false;
/// <summary>
/// Returns if all of the hashes are set to their 0-byte values
/// </summary>
/// <returns>True if any hash matches the 0-byte value, false otherwise</returns>
public bool HasZeroHash() => _internal.HasZeroHash();
public bool HasZeroHash() => (_internal as Data.Models.Metadata.Media)?.HasZeroHash() ?? false;
#endregion

View File

@@ -417,19 +417,19 @@ namespace SabreTools.Metadata.DatItems.Formats
/// </summary>
/// <param name="other">Rom to fill information from</param>
public void FillMissingInformation(Rom other)
=> _internal.FillMissingHashes(other._internal);
=> (_internal as Data.Models.Metadata.Rom).FillMissingHashes(other._internal as Data.Models.Metadata.Rom);
/// <summary>
/// Returns if the Rom contains any hashes
/// </summary>
/// <returns>True if any hash exists, false otherwise</returns>
public bool HasHashes() => _internal.HasHashes();
public bool HasHashes() => (_internal as Data.Models.Metadata.Rom)?.HasHashes() ?? false;
/// <summary>
/// Returns if all of the hashes are set to their 0-byte values
/// </summary>
/// <returns>True if any hash matches the 0-byte value, false otherwise</returns>
public bool HasZeroHash() => _internal.HasZeroHash();
public bool HasZeroHash() => (_internal as Data.Models.Metadata.Rom)?.HasZeroHash() ?? false;
#endregion