SabreTools/SabreTools.Serialization
1
0
Fork 0
mirror of https://github.com/SabreTools/SabreTools.Serialization.git synced 2026-09-22 06:45:11 +00:00
Code Issues 56 Packages Projects Releases 20 Wiki Activity

Make inverted Part less impactful

Browse Source
This commit is contained in:
Matt Nadareski
2026-04-09 23:29:00 -04:00
parent 5d4453fb1e
commit b0a9464d2b
14 changed files with 107 additions and 223 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
SabreTools.Metadata.DatFiles.Test/DatFileTests.FromMetadata.cs
View File

@@ -95,10 +95,10 @@ namespace SabreTools.Metadata.DatFiles.Test
DeviceRef? deviceRef = Array.Find(datItems, item => item is DeviceRef) as DeviceRef;
ValidateDeviceRef(deviceRef);
DipSwitch? dipSwitch = Array.Find(datItems, item => item is DipSwitch dipSwitch && !dipSwitch.PartSpecified) as DipSwitch;
DipSwitch? dipSwitch = Array.Find(datItems, item => item is DipSwitch dipSwitch && dipSwitch.PartInterface is null) as DipSwitch;
ValidateDipSwitch(dipSwitch);
Disk? disk = Array.Find(datItems, item => item is Disk disk && !disk.DiskAreaSpecified && !disk.PartSpecified) as Disk;
Disk? disk = Array.Find(datItems, item => item is Disk disk && !disk.DiskAreaSpecified && disk.PartInterface is null) as Disk;
ValidateDisk(disk);
Display? display = Array.Find(datItems, item => item is Display display && display.AspectX is null) as Display;
@@ -125,27 +125,28 @@ namespace SabreTools.Metadata.DatFiles.Test
ValidateMedia(media);
// All other fields are tested separately
DipSwitch? partDipSwitch = Array.Find(datItems, item => item is DipSwitch dipSwitch && dipSwitch.PartSpecified) as DipSwitch;
DipSwitch? partDipSwitch = Array.Find(datItems, item => item is DipSwitch dipSwitch && dipSwitch.PartInterface is not null) as DipSwitch;
Assert.NotNull(partDipSwitch);
Part? dipSwitchPart = partDipSwitch.Part;
ValidatePart(dipSwitchPart);
Assert.Equal("interface", partDipSwitch.PartInterface);
Assert.Equal("name", partDipSwitch.PartName);
// All other fields are tested separately
Disk? partDisk = Array.Find(datItems, item => item is Disk disk && disk.DiskAreaSpecified && disk.PartSpecified) as Disk;
Disk? partDisk = Array.Find(datItems, item => item is Disk disk && disk.DiskAreaSpecified && disk.PartInterface is not null) as Disk;
Assert.NotNull(partDisk);
ValidateDiskArea(partDisk.DiskArea);
ValidatePart(partDisk.Part);
Assert.Equal("interface", partDisk.PartInterface);
Assert.Equal("name", partDisk.PartName);
PartFeature? partFeature = Array.Find(datItems, item => item is PartFeature) as PartFeature;
ValidatePartFeature(partFeature);
// All other fields are tested separately
Rom? partRom = Array.Find(datItems, item => item is Rom rom && rom.DataAreaSpecified && rom.PartSpecified) as Rom;
Rom? partRom = Array.Find(datItems, item => item is Rom rom && rom.DataAreaSpecified && rom.PartInterface is not null) as Rom;
Assert.NotNull(partRom);
DataArea? romDataArea = partRom.DataArea;
ValidateDataArea(romDataArea);
Part? romPart = partRom.Part;
ValidatePart(romPart);
Assert.Equal("interface", partRom.PartInterface);
Assert.Equal("name", partRom.PartName);
Port? port = Array.Find(datItems, item => item is Port) as Port;
ValidatePort(port);
@@ -156,7 +157,7 @@ namespace SabreTools.Metadata.DatFiles.Test
Release? release = Array.Find(datItems, item => item is Release) as Release;
ValidateRelease(release);
Rom? rom = Array.Find(datItems, item => item is Rom rom && !rom.DataAreaSpecified && !rom.PartSpecified && rom.OpenMSXMediaType is null) as Rom;
Rom? rom = Array.Find(datItems, item => item is Rom rom && !rom.DataAreaSpecified && rom.PartInterface is null && rom.OpenMSXMediaType is null) as Rom;
ValidateRom(rom);
Sample? sample = Array.Find(datItems, item => item is Sample) as Sample;
@@ -1385,24 +1386,16 @@ namespace SabreTools.Metadata.DatFiles.Test
Assert.Equal(HashType.SpamSum.ZeroString, media.SpamSum);
}
private static void ValidatePart(Part? part)
{
Assert.NotNull(part);
Assert.Equal("interface", part.Interface);
Assert.Equal("name", part.Name);
}
private static void ValidatePartFeature(PartFeature? partFeature)
{
Assert.NotNull(partFeature);
Assert.Equal("name", partFeature.Name);
Assert.Equal(Data.Models.Metadata.FeatureStatus.Imperfect, partFeature.Overall);
Assert.Equal("interface", partFeature.PartInterface);
Assert.Equal("name", partFeature.PartName);
Assert.Equal(Data.Models.Metadata.FeatureStatus.Imperfect, partFeature.Status);
Assert.Equal(Data.Models.Metadata.FeatureType.Protection, partFeature.FeatureType);
Assert.Equal("value", partFeature.Value);
Part? part = partFeature.Part;
ValidatePart(part);
}
private static void ValidatePort(Port? port)

19
SabreTools.Metadata.DatFiles.Test/DatFileTests.ToMetadata.cs
View File

@@ -177,7 +177,8 @@ namespace SabreTools.Metadata.DatFiles.Test
{
DipSwitch item = new DipSwitch(CreateMetadataDipSwitch());
item.CopyMachineInformation(machine);
item.Part = CreatePart(machine);
item.PartInterface = "interface";
item.PartName = "name";
return item;
}
@@ -193,7 +194,8 @@ namespace SabreTools.Metadata.DatFiles.Test
Disk item = new Disk(CreateMetadataDisk());
item.CopyMachineInformation(machine);
item.DiskArea = CreateDiskArea(machine);
item.Part = CreatePart(machine);
item.PartInterface = "interface";
item.PartName = "name";
return item;
}
@@ -246,18 +248,12 @@ namespace SabreTools.Metadata.DatFiles.Test
return item;
}
private static Part CreatePart(Machine machine)
{
Part item = new Part(CreateMetadataPart());
item.CopyMachineInformation(machine);
return item;
}
private static PartFeature CreatePartFeature(Machine machine)
{
PartFeature item = new PartFeature(CreateMetadataFeature());
item.CopyMachineInformation(machine);
item.Part = CreatePart(machine);
item.PartInterface = "interface";
item.PartName = "name";
return item;
}
@@ -295,7 +291,8 @@ namespace SabreTools.Metadata.DatFiles.Test
Rom item = new Rom(CreateMetadataRom());
item.CopyMachineInformation(machine);
item.DataArea = CreateDataArea(machine);
item.Part = CreatePart(machine);
item.PartInterface = "interface";
item.PartName = "name";
return item;
}