From c216129b37c9c4c62fadfd09ea19dff0a61632fc Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 26 Mar 2026 09:05:58 -0400 Subject: [PATCH] Be more explicit about support --- SabreTools.Metadata.DatFiles/DatStatistics.cs | 18 ++++++++++++------ .../Formats/ClrMamePro.cs | 6 ++++-- .../Formats/DosCenter.cs | 6 ++++-- .../Formats/EverdriveSmdb.cs | 6 ++++-- .../Formats/Listrom.cs | 6 ++++-- .../Formats/Listxml.cs | 6 ++++-- SabreTools.Metadata.DatFiles/Formats/Logiqx.cs | 6 ++++-- .../Formats/Md2File.cs | 6 ++++-- .../Formats/Md4File.cs | 6 ++++-- .../Formats/Md5File.cs | 6 ++++-- .../Formats/OfflineList.cs | 8 +++++--- .../Formats/OpenMSX.cs | 6 ++++-- .../Formats/RipeMD128File.cs | 6 ++++-- .../Formats/RipeMD160File.cs | 6 ++++-- .../Formats/RomCenter.cs | 6 ++++-- .../Formats/SabreJSON.cs | 13 +++++++++++-- .../Formats/SeparatedValue.cs | 6 ++++-- .../Formats/SfvFile.cs | 6 ++++-- .../Formats/Sha1File.cs | 6 ++++-- .../Formats/Sha256File.cs | 6 ++++-- .../Formats/Sha384File.cs | 6 ++++-- .../Formats/Sha512File.cs | 6 ++++-- .../Formats/SoftwareList.cs | 6 ++++-- .../Formats/SpamSumFile.cs | 6 ++++-- SabreTools.Metadata.DatItems/DatItem.cs | 7 +++++-- 25 files changed, 117 insertions(+), 55 deletions(-) diff --git a/SabreTools.Metadata.DatFiles/DatStatistics.cs b/SabreTools.Metadata.DatFiles/DatStatistics.cs index bf20313f..ddf409f8 100644 --- a/SabreTools.Metadata.DatFiles/DatStatistics.cs +++ b/SabreTools.Metadata.DatFiles/DatStatistics.cs @@ -157,7 +157,6 @@ namespace SabreTools.Metadata.DatFiles // Increment the item count for the type AddItemCount(item.ReadString(Data.Models.Metadata.DatItem.TypeKey).AsItemType()); -#pragma warning disable IDE0010 // Some item types require special processing switch (item) { @@ -170,8 +169,11 @@ namespace SabreTools.Metadata.DatFiles case Data.Models.Metadata.Rom rom: AddItemStatistics(rom); break; + + default: + // Item type requires no special processing + break; } -#pragma warning restore IDE0010 } } @@ -278,7 +280,6 @@ namespace SabreTools.Metadata.DatFiles // Decrement the item count for the type RemoveItemCount(item.GetStringFieldValue(Data.Models.Metadata.DatItem.TypeKey).AsItemType()); -#pragma warning disable IDE0010 // Some item types require special processing switch (item) { @@ -294,8 +295,11 @@ namespace SabreTools.Metadata.DatFiles case Rom rom: RemoveItemStatistics(rom); break; + + default: + // Item type requires no special processing + break; } -#pragma warning restore IDE0010 } } @@ -321,7 +325,6 @@ namespace SabreTools.Metadata.DatFiles // Decrement the item count for the type RemoveItemCount(item.ReadString(Data.Models.Metadata.DatItem.TypeKey).AsItemType()); -#pragma warning disable IDE0010 // Some item types require special processing switch (item) { @@ -334,8 +337,11 @@ namespace SabreTools.Metadata.DatFiles case Data.Models.Metadata.Rom rom: RemoveItemStatistics(rom); break; + + default: + // Item type requires no special processing + break; } -#pragma warning restore IDE0010 } } diff --git a/SabreTools.Metadata.DatFiles/Formats/ClrMamePro.cs b/SabreTools.Metadata.DatFiles/Formats/ClrMamePro.cs index 3b5dddfc..3314c5a4 100644 --- a/SabreTools.Metadata.DatFiles/Formats/ClrMamePro.cs +++ b/SabreTools.Metadata.DatFiles/Formats/ClrMamePro.cs @@ -71,7 +71,6 @@ namespace SabreTools.Metadata.DatFiles.Formats { List missingFields = []; -#pragma warning disable IDE0010 switch (datItem) { case Release release: @@ -170,8 +169,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (driver.GetStringFieldValue(Data.Models.Metadata.Driver.EmulationKey).AsSupportStatus() == SupportStatus.NULL) missingFields.Add(Data.Models.Metadata.Driver.EmulationKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/DosCenter.cs b/SabreTools.Metadata.DatFiles/Formats/DosCenter.cs index 24a008e4..07d113b9 100644 --- a/SabreTools.Metadata.DatFiles/Formats/DosCenter.cs +++ b/SabreTools.Metadata.DatFiles/Formats/DosCenter.cs @@ -33,7 +33,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: @@ -46,8 +45,11 @@ namespace SabreTools.Metadata.DatFiles.Formats // if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA1Key))) // missingFields.Add(Data.Models.Metadata.Rom.SHA1Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/EverdriveSmdb.cs b/SabreTools.Metadata.DatFiles/Formats/EverdriveSmdb.cs index c57e3f55..65292d3b 100644 --- a/SabreTools.Metadata.DatFiles/Formats/EverdriveSmdb.cs +++ b/SabreTools.Metadata.DatFiles/Formats/EverdriveSmdb.cs @@ -33,7 +33,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: @@ -46,8 +45,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.CRCKey))) missingFields.Add(Data.Models.Metadata.Rom.CRCKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Listrom.cs b/SabreTools.Metadata.DatFiles/Formats/Listrom.cs index 400c2ae0..9dd664e7 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Listrom.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Listrom.cs @@ -34,7 +34,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Disk disk: @@ -54,8 +53,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA1Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA1Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Listxml.cs b/SabreTools.Metadata.DatFiles/Formats/Listxml.cs index aa839b02..c6db49ea 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Listxml.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Listxml.cs @@ -257,7 +257,6 @@ namespace SabreTools.Metadata.DatFiles.Formats { List missingFields = []; -#pragma warning disable IDE0010 switch (datItem) { case BiosSet biosset: @@ -388,8 +387,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(ramoption.GetName())) missingFields.Add(Data.Models.Metadata.RamOption.NameKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Logiqx.cs b/SabreTools.Metadata.DatFiles/Formats/Logiqx.cs index 0870f4ba..62a6b72a 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Logiqx.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Logiqx.cs @@ -263,7 +263,6 @@ namespace SabreTools.Metadata.DatFiles.Formats { List missingFields = []; -#pragma warning disable IDE0010 switch (datItem) { case Release release: @@ -362,8 +361,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (softwarelist.GetStringFieldValue(Data.Models.Metadata.SoftwareList.StatusKey).AsSoftwareListStatus() == SoftwareListStatus.None) missingFields.Add(Data.Models.Metadata.SoftwareList.StatusKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Md2File.cs b/SabreTools.Metadata.DatFiles/Formats/Md2File.cs index d2276ac3..bd967a14 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Md2File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Md2File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.MD2Key))) missingFields.Add(Data.Models.Metadata.Rom.MD2Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Md4File.cs b/SabreTools.Metadata.DatFiles/Formats/Md4File.cs index d1c919b6..9911bd1e 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Md4File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Md4File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.MD4Key))) missingFields.Add(Data.Models.Metadata.Rom.MD4Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Md5File.cs b/SabreTools.Metadata.DatFiles/Formats/Md5File.cs index cccfb603..f0569eb9 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Md5File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Md5File.cs @@ -38,7 +38,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Disk disk: @@ -55,8 +54,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.MD5Key))) missingFields.Add(Data.Models.Metadata.Rom.MD5Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/OfflineList.cs b/SabreTools.Metadata.DatFiles/Formats/OfflineList.cs index 22e05021..c89c736f 100644 --- a/SabreTools.Metadata.DatFiles/Formats/OfflineList.cs +++ b/SabreTools.Metadata.DatFiles/Formats/OfflineList.cs @@ -1,4 +1,4 @@ -using System.Collections.Generic; +using System.Collections.Generic; using SabreTools.Metadata.DatItems; using SabreTools.Metadata.DatItems.Formats; @@ -29,7 +29,6 @@ namespace SabreTools.Metadata.DatFiles.Formats { List missingFields = []; -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: @@ -38,8 +37,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.CRCKey))) missingFields.Add(Data.Models.Metadata.Rom.CRCKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/OpenMSX.cs b/SabreTools.Metadata.DatFiles/Formats/OpenMSX.cs index 7728873f..f4d56e16 100644 --- a/SabreTools.Metadata.DatFiles/Formats/OpenMSX.cs +++ b/SabreTools.Metadata.DatFiles/Formats/OpenMSX.cs @@ -72,15 +72,17 @@ The softwaredb.xml file contains information about rom mapper types if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA1Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA1Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/RipeMD128File.cs b/SabreTools.Metadata.DatFiles/Formats/RipeMD128File.cs index b83d819b..d6713a0f 100644 --- a/SabreTools.Metadata.DatFiles/Formats/RipeMD128File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/RipeMD128File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.RIPEMD128Key))) missingFields.Add(Data.Models.Metadata.Rom.RIPEMD128Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/RipeMD160File.cs b/SabreTools.Metadata.DatFiles/Formats/RipeMD160File.cs index 7ee26c48..d8269fea 100644 --- a/SabreTools.Metadata.DatFiles/Formats/RipeMD160File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/RipeMD160File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.RIPEMD160Key))) missingFields.Add(Data.Models.Metadata.Rom.RIPEMD160Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/RomCenter.cs b/SabreTools.Metadata.DatFiles/Formats/RomCenter.cs index a6a0aed5..94949ea7 100644 --- a/SabreTools.Metadata.DatFiles/Formats/RomCenter.cs +++ b/SabreTools.Metadata.DatFiles/Formats/RomCenter.cs @@ -33,7 +33,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: @@ -42,8 +41,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (rom.GetInt64FieldValue(Data.Models.Metadata.Rom.SizeKey) is null || rom.GetInt64FieldValue(Data.Models.Metadata.Rom.SizeKey) < 0) missingFields.Add(Data.Models.Metadata.Rom.SizeKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/SabreJSON.cs b/SabreTools.Metadata.DatFiles/Formats/SabreJSON.cs index 8fa8d3de..e8e818c8 100644 --- a/SabreTools.Metadata.DatFiles/Formats/SabreJSON.cs +++ b/SabreTools.Metadata.DatFiles/Formats/SabreJSON.cs @@ -248,7 +248,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (datItemObj is null) return; -#pragma warning disable IDE0010 switch (datItemObj.Value("type").AsItemType()) { case ItemType.Adjuster: @@ -320,6 +319,9 @@ namespace SabreTools.Metadata.DatFiles.Formats case ItemType.Feature: datItem = datItemObj.ToObject(); break; + case ItemType.File: + datItem = datItemObj.ToObject(); + break; case ItemType.Info: datItem = datItemObj.ToObject(); break; @@ -332,6 +334,9 @@ namespace SabreTools.Metadata.DatFiles.Formats case ItemType.Media: datItem = datItemObj.ToObject(); break; + case ItemType.Original: + // Cannot be converted to a DatItem + break; case ItemType.Part: datItem = datItemObj.ToObject(); break; @@ -377,8 +382,12 @@ namespace SabreTools.Metadata.DatFiles.Formats case ItemType.SourceDetails: datItem = datItemObj.ToObject(); break; + + case ItemType.NULL: + default: + // This should never happen + break; } -#pragma warning restore IDE0010 } // If we got a valid datitem, copy machine info and add diff --git a/SabreTools.Metadata.DatFiles/Formats/SeparatedValue.cs b/SabreTools.Metadata.DatFiles/Formats/SeparatedValue.cs index 85b292f7..0744677e 100644 --- a/SabreTools.Metadata.DatFiles/Formats/SeparatedValue.cs +++ b/SabreTools.Metadata.DatFiles/Formats/SeparatedValue.cs @@ -70,7 +70,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Disk disk: @@ -108,8 +107,11 @@ namespace SabreTools.Metadata.DatFiles.Formats } break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/SfvFile.cs b/SabreTools.Metadata.DatFiles/Formats/SfvFile.cs index 1907daf6..bbd02023 100644 --- a/SabreTools.Metadata.DatFiles/Formats/SfvFile.cs +++ b/SabreTools.Metadata.DatFiles/Formats/SfvFile.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.CRCKey))) missingFields.Add(Data.Models.Metadata.Rom.CRCKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Sha1File.cs b/SabreTools.Metadata.DatFiles/Formats/Sha1File.cs index e300499c..6a2025e1 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Sha1File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Sha1File.cs @@ -38,7 +38,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Disk disk: @@ -55,8 +54,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA1Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA1Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Sha256File.cs b/SabreTools.Metadata.DatFiles/Formats/Sha256File.cs index 17ecbf65..0a7334c4 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Sha256File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Sha256File.cs @@ -37,7 +37,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Media medium: @@ -49,8 +48,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA256Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA256Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Sha384File.cs b/SabreTools.Metadata.DatFiles/Formats/Sha384File.cs index dd64af2b..632190b5 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Sha384File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Sha384File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA384Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA384Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/Sha512File.cs b/SabreTools.Metadata.DatFiles/Formats/Sha512File.cs index 986d6395..d51e779d 100644 --- a/SabreTools.Metadata.DatFiles/Formats/Sha512File.cs +++ b/SabreTools.Metadata.DatFiles/Formats/Sha512File.cs @@ -36,15 +36,17 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Rom rom: if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SHA512Key))) missingFields.Add(Data.Models.Metadata.Rom.SHA512Key); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/SoftwareList.cs b/SabreTools.Metadata.DatFiles/Formats/SoftwareList.cs index 02dde29d..281ddcf1 100644 --- a/SabreTools.Metadata.DatFiles/Formats/SoftwareList.cs +++ b/SabreTools.Metadata.DatFiles/Formats/SoftwareList.cs @@ -104,7 +104,6 @@ namespace SabreTools.Metadata.DatFiles.Formats { List missingFields = []; -#pragma warning disable IDE0010 switch (datItem) { case DipSwitch dipSwitch: @@ -204,8 +203,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(sharedFeat.GetName())) missingFields.Add(Data.Models.Metadata.SharedFeat.NameKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatFiles/Formats/SpamSumFile.cs b/SabreTools.Metadata.DatFiles/Formats/SpamSumFile.cs index 8300f92b..8d59b407 100644 --- a/SabreTools.Metadata.DatFiles/Formats/SpamSumFile.cs +++ b/SabreTools.Metadata.DatFiles/Formats/SpamSumFile.cs @@ -37,7 +37,6 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(datItem.GetName())) missingFields.Add(Data.Models.Metadata.Rom.NameKey); -#pragma warning disable IDE0010 switch (datItem) { case Media medium: @@ -49,8 +48,11 @@ namespace SabreTools.Metadata.DatFiles.Formats if (string.IsNullOrEmpty(rom.GetStringFieldValue(Data.Models.Metadata.Rom.SpamSumKey))) missingFields.Add(Data.Models.Metadata.Rom.SpamSumKey); break; + + default: + // Item type is not supported + break; } -#pragma warning restore IDE0010 return missingFields; } diff --git a/SabreTools.Metadata.DatItems/DatItem.cs b/SabreTools.Metadata.DatItems/DatItem.cs index ded44f99..ae93a271 100644 --- a/SabreTools.Metadata.DatItems/DatItem.cs +++ b/SabreTools.Metadata.DatItems/DatItem.cs @@ -279,7 +279,6 @@ namespace SabreTools.Metadata.DatItems string sourceKeyPadded = source?.Index.ToString().PadLeft(10, '0') + '-'; string machineName = machine?.GetName() ?? "Default"; -#pragma warning disable IDE0010 // Now determine what the key should be based on the bucketedBy value switch (bucketedBy) { @@ -338,8 +337,12 @@ namespace SabreTools.Metadata.DatItems case ItemKey.SpamSum: key = HashType.SpamSum.ZeroString; break; + + case ItemKey.NULL: + default: + // This should never happen + break; } -#pragma warning restore IDE0010 // Double and triple check the key for corner cases key ??= string.Empty;